Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix can't pair with dApp on android with WalletConnect #20600

Merged
merged 2 commits into from
Jul 1, 2024
Merged

fix can't pair with dApp on android with WalletConnect #20600

merged 2 commits into from
Jul 1, 2024

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Jun 30, 2024 •
edited
Loading

fixes #20083

Summary

It seems this problem of android not pairing successfully was in 2.12.2 version and migrating to 2.11.2 fixes the issue.
(Thank you @shivekkhurana for suggestion about checking rainbow-wallet, they are also using same version)

But after migrating to, 2.11.2 it started to throw this error - WalletConnect/walletconnect-monorepo#3235
Which was fixed by adding big-integer package and assigning that to BigInt variable.

Video
output-2024-06-30_14.17.22.mp4

Testing Step (Only for devs)

  1. Connect on https://react-app.walletconnect.com (whatever network)
  2. Copy the url
  3. Login in the status app
  4. Make sure WalletConnect was initialized
  5. Run the :wallet-connect/pair with the copied url

status: ready

@Parveshdhull Parveshdhull self-assigned this Jun 30, 2024
@Parveshdhull Parveshdhull changed the title fix Can't pair with dApp on android with WalletConnect fix can't pair with dApp on android with WalletConnect Jun 30, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Jun 30, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cf86908 #1 2024-06-30 08:49:40 ~7 min android 🤖apk 📲
✔️ 3cac1a6 #2 2024-06-30 08:55:18 ~5 min tests 📄log
✔️ 3cac1a6 #2 2024-06-30 08:56:21 ~6 min android-e2e 🤖apk 📲
✔️ 3cac1a6 #2 2024-06-30 08:57:37 ~7 min android 🤖apk 📲
✔️ 3cac1a6 #2 2024-06-30 09:01:13 ~11 min ios 📱ipa 📲
✔️ 6e8db00 #3 2024-06-30 09:57:17 ~4 min tests 📄log
✔️ 6e8db00 #3 2024-06-30 09:59:20 ~6 min android-e2e 🤖apk 📲
✔️ 6e8db00 #3 2024-06-30 09:59:36 ~6 min android 🤖apk 📲
✔️ 6e8db00 #3 2024-06-30 10:01:46 ~8 min ios 📱ipa 📲
✔️ 22c797b #4 2024-06-30 10:19:53 ~5 min tests 📄log
✔️ 22c797b #4 2024-06-30 10:22:39 ~8 min android-e2e 🤖apk 📲
✔️ 22c797b #4 2024-06-30 10:22:39 ~8 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 72e7109 #5 2024-06-30 10:28:20 ~5 min tests 📄log
✔️ 72e7109 #5 2024-06-30 10:29:48 ~6 min android 🤖apk 📲
✔️ 72e7109 #5 2024-06-30 10:30:53 ~8 min android-e2e 🤖apk 📲
✔️ 72e7109 #5 2024-06-30 10:33:22 ~10 min ios 📱ipa 📲
✔️ d1a9426 #6 2024-07-01 11:59:28 ~10 min ios 📱ipa 📲
✔️ d1a9426 #6 2024-07-01 11:59:52 ~10 min android 🤖apk 📲
✔️ d1a9426 #6 2024-07-01 12:00:03 ~11 min tests 📄log
✔️ d1a9426 #6 2024-07-01 12:03:03 ~14 min android-e2e 🤖apk 📲

@Parveshdhull Parveshdhull force-pushed the fix/android-wc-bug-test branch 2 times, most recently from 3cac1a6 to 6e8db00 Compare June 30, 2024 09:52
@Parveshdhull Parveshdhull force-pushed the fix/android-wc-bug-test branch from 6e8db00 to 22c797b Compare June 30, 2024 10:14
@Parveshdhull Parveshdhull force-pushed the fix/android-wc-bug-test branch from 22c797b to 72e7109 Compare June 30, 2024 10:22
@status-im-auto
Copy link
Member

82% of end-end tests have passed

Total executed tests: 51
Failed tests: 6
Expected to fail tests: 3
Passed tests: 42

IDs of failed tests: 727230,702782,702733,702859,727229,702731 

IDs of expected to fail tests: 703495,727232,703629

Failed tests (6)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_one_image_send_reply, id: 702859

    Device 2: Find `EmojisNumber` by `xpath`: `//*[starts-with(@text,'reply to image')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-1']/android.widget.TextView[2]`
    Device 2: Element EmojisNumber text is equal to 1 

    critical/chats/test_public_chat_browsing.py:528: in test_community_one_image_send_reply
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Reply message was not received by the sender
E    Image message reaction is not shown for the sender



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 2: Find Button by accessibility id: top-bar
    Device 1: Find Button by accessibility id: top-bar 

    critical/test_wallet.py:173: in test_wallet_send_asset_from_drawer
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Sender balance is not updated on Etherscan, it is 0.0037038384 but expected to be 0.0037305798



    2. test_wallet_send_eth, id: 727229

    Device 2: Find Button by accessibility id: top-bar
    Device 1: Find Button by accessibility id: top-bar 

    critical/test_wallet.py:147: in test_wallet_send_eth
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Sender balance is not updated on Etherscan, it is 0.0038305798 but expected to be 0.0038573212



    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 1: Long press on ChatElementByText until expected element is shown
    Device 1: Find Button by xpath: //*[@text="Reply"] 

    critical/chats/test_1_1_public_chats.py:129: in test_1_1_chat_emoji_send_reply_and_open_link
    self.chat_1.quote_message(emoji_unicode)
../views/chat_view.py:1041: in quote_message
    self.reply_message_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@text="Reply"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 2: Find Text by xpath: //*[starts-with(@text,'smth I should edit')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']
    Device 2: Tap on found: Text 

    critical/chats/test_1_1_public_chats.py:483: in test_1_1_chat_text_message_delete_push_disappear
    self.chat_2.chat_element_by_text(message_after_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sending



    Device sessions

    3. test_1_1_chat_pin_messages, id: 702731

    Device 1: Find Button by xpath: //*[@content-desc='pins-count']//android.widget.TextView
    Device 1: Find Button by xpath: //*[@content-desc='pins-count']//android.widget.TextView 

    critical/chats/test_1_1_public_chats.py:198: in test_1_1_chat_pin_messages
    chat.pinned_messages_count.wait_for_element_text(text="2",
../views/base_element.py:190: in wait_for_element_text
    self.driver.fail(message if message else "`%s` is not equal to expected `%s` in %s sec" % (
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Pinned messages count is not 2 as expected!



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]
    Device 2: Wait for element Button for max 120s and click when it is available 

    critical/chats/test_public_chat_browsing.py:1158: in test_community_join_when_node_owner_offline
    self.community_2.join_community(open_community=False)
../views/chat_view.py:420: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element

    [[Can't enter channel after community is fetched for the first time, https://github.com//issues/20395]]

    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:497: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
    Device 1: Click system back button 

    critical/test_wallet.py:256: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'

    [[Missing networks in account address, https://github.com//issues/20166]]

    Device sessions

    Passed tests (42)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_discovery, id: 703503
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    6. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    3. test_1_1_chat_edit_message, id: 702855
    Device sessions

    4. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    5. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    shivekkhurana
    shivekkhurana approved these changes Jul 1, 2024
    View reviewed changes
    Copy link
    Contributor

    @shivekkhurana shivekkhurana left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks for looking into this Pravesh 🙏

    @alwx alwx mentioned this pull request Jul 1, 2024
    Closed
    @Parveshdhull
    Copy link
    Member Author

    @status-im/mobile-qa Please can you check failed e2e tests. Thank you

    @pavloburykh
    Copy link
    Contributor

    @status-im/mobile-qa Please can you check failed e2e tests. Thank you

    Thank you for the PR @Parveshdhull! Failed e2e are not PR related. Ready for merge.

    @Parveshdhull Parveshdhull merged commit 424d2d4 into develop Jul 1, 2024
    6 checks passed
    @Parveshdhull Parveshdhull deleted the fix/android-wc-bug-test branch July 1, 2024 12:32
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @alwx alwx alwx approved these changes

    @shivekkhurana shivekkhurana shivekkhurana approved these changes

    @clauxx clauxx clauxx approved these changes

    Assignees

    @Parveshdhull Parveshdhull

    Labels
    skip-manual-qa
    Projects
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Can't pair with dApp on android with WalletConnect
    6 participants
    @Parveshdhull @status-im-auto @pavloburykh @alwx @shivekkhurana @clauxx