Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use default IPFS Gateway URL #21106

Merged
merged 1 commit into from
Sep 13, 2024
Merged

ci: use default IPFS Gateway URL #21106

merged 1 commit into from
Sep 13, 2024

Conversation

siddarthkay
Copy link
Contributor

Summary

This PR removes the config for setting IPFS Gateway URL.
The default in status-go is https://ipfs.status.im/ which works well.

fixes : #20958

Testing notes

Please test stickers in PR builds and in release builds.

Additional notes

This PR should only be merged after https://github.com/status-im/status-jenkins-lib/pull/98 is merged and a tagged version is present in this PR.

Platforms

  • Android
  • iOS

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Aug 21, 2024

Jenkins Builds

Click to see older builds (58)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b8b18db #1 2024-08-21 13:42:20 ~5 min tests 📄log
✔️ b8b18db #1 2024-08-21 13:44:10 ~6 min android-e2e 🤖apk 📲
✔️ b8b18db #1 2024-08-21 13:47:47 ~10 min ios 📱ipa 📲
✔️ b8b18db #1 2024-08-21 13:48:42 ~11 min android 🤖apk 📲
✔️ 0580b42 #2 2024-08-21 14:20:34 ~4 min tests 📄log
✔️ 0580b42 #2 2024-08-21 14:22:42 ~6 min android-e2e 🤖apk 📲
✔️ 0580b42 #2 2024-08-21 14:24:54 ~8 min android 🤖apk 📲
✔️ 0580b42 #2 2024-08-21 14:35:21 ~19 min ios 📱ipa 📲
✔️ 6b6507b #3 2024-08-22 09:19:22 ~4 min tests 📄log
✔️ 6b6507b #3 2024-08-22 09:22:30 ~7 min android-e2e 🤖apk 📲
✔️ 6b6507b #3 2024-08-22 09:24:19 ~9 min android 🤖apk 📲
✔️ 6b6507b #3 2024-08-22 09:27:55 ~12 min ios 📱ipa 📲
✔️ 49ffbf9 #4 2024-08-23 09:31:33 ~5 min tests 📄log
✔️ 49ffbf9 #4 2024-08-23 09:32:53 ~7 min android-e2e 🤖apk 📲
✔️ 49ffbf9 #4 2024-08-23 09:34:16 ~8 min android 🤖apk 📲
✔️ 49ffbf9 #4 2024-08-23 09:36:03 ~10 min ios 📱ipa 📲
✔️ 3489c7e #5 2024-08-26 09:54:58 ~4 min tests 📄log
✔️ d7cce91 #6 2024-08-26 09:59:22 ~4 min tests 📄log
✔️ d7cce91 #6 2024-08-26 10:03:47 ~8 min android-e2e 🤖apk 📲
✔️ d7cce91 #6 2024-08-26 10:04:37 ~9 min android 🤖apk 📲
✔️ d7cce91 #6 2024-08-26 10:07:06 ~11 min ios 📱ipa 📲
✔️ 8811587 #7 2024-08-29 03:15:07 ~4 min tests 📄log
✔️ 8811587 #7 2024-08-29 03:18:30 ~7 min android-e2e 🤖apk 📲
✔️ 8811587 #7 2024-08-29 03:18:50 ~7 min android 🤖apk 📲
✔️ 8811587 #7 2024-08-29 03:20:53 ~9 min ios 📱ipa 📲
e7b75a0 #8 2024-09-02 11:44:21 ~3 min tests 📄log
✔️ e7b75a0 #8 2024-09-02 11:48:39 ~7 min android-e2e 🤖apk 📲
✔️ e7b75a0 #8 2024-09-02 11:49:12 ~7 min android 🤖apk 📲
✔️ e7b75a0 #8 2024-09-02 11:52:20 ~11 min ios 📱ipa 📲
✔️ b02e656 #9 2024-09-03 09:45:05 ~4 min tests 📄log
✔️ b02e656 #9 2024-09-03 09:46:39 ~6 min android-e2e 🤖apk 📲
✔️ b02e656 #9 2024-09-03 09:49:17 ~9 min android 🤖apk 📲
✔️ b02e656 #9 2024-09-03 09:51:43 ~11 min ios 📱ipa 📲
d1c3657 #10 2024-09-04 06:49:51 ~11 sec android-e2e 📄log
d1c3657 #10 2024-09-04 06:49:56 ~12 sec android 📄log
✔️ d1c3657 #10 2024-09-04 06:53:58 ~4 min tests 📄log
✔️ d1c3657 #10 2024-09-04 06:59:42 ~9 min ios 📱ipa 📲
d1c3657 #11 2024-09-04 07:04:13 ~12 sec android 📄log
✔️ 0e60f20 #11 2024-09-04 07:13:39 ~4 min tests 📄log
✔️ 0e60f20 #11 2024-09-04 07:15:43 ~6 min android-e2e 🤖apk 📲
✔️ 0e60f20 #12 2024-09-04 07:17:11 ~7 min android 🤖apk 📲
✔️ 0e60f20 #11 2024-09-04 07:19:15 ~9 min ios 📱ipa 📲
✔️ b93b700 #12 2024-09-12 09:12:29 ~4 min tests 📄log
✔️ b93b700 #12 2024-09-12 09:14:38 ~6 min android-e2e 🤖apk 📲
✔️ b93b700 #13 2024-09-12 09:16:16 ~7 min android 🤖apk 📲
✔️ b93b700 #12 2024-09-12 09:19:39 ~11 min ios 📱ipa 📲
✔️ 30a855e #13 2024-09-12 10:19:45 ~4 min tests 📄log
✔️ 30a855e #14 2024-09-12 10:22:37 ~7 min android 🤖apk 📲
✔️ 30a855e #13 2024-09-12 10:22:53 ~7 min android-e2e 🤖apk 📲
✔️ 30a855e #13 2024-09-12 10:24:50 ~9 min ios 📱ipa 📲
✔️ 786120f #14 2024-09-12 10:44:18 ~3 min tests 📄log
✔️ 786120f #14 2024-09-12 10:47:46 ~7 min android-e2e 🤖apk 📲
✔️ 786120f #15 2024-09-12 10:48:05 ~7 min android 🤖apk 📲
✔️ 786120f #14 2024-09-12 10:50:05 ~9 min ios 📱ipa 📲
✔️ 5024cce #15 2024-09-12 11:00:31 ~4 min tests 📄log
✔️ 5024cce #16 2024-09-12 11:02:39 ~6 min android 🤖apk 📲
✔️ 5024cce #15 2024-09-12 11:03:48 ~7 min android-e2e 🤖apk 📲
✔️ 5024cce #15 2024-09-12 11:05:49 ~9 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 301c7a6 #18 2024-09-12 11:53:00 ~4 min tests 📄log
✔️ 301c7a6 #18 2024-09-12 11:56:03 ~7 min android-e2e 🤖apk 📲
✔️ 301c7a6 #19 2024-09-12 11:57:10 ~8 min android 🤖apk 📲
✔️ 301c7a6 #18 2024-09-12 11:59:40 ~11 min ios 📱ipa 📲
✔️ 1ba3ae8 #19 2024-09-13 02:56:16 ~5 min tests 📄log
✔️ 1ba3ae8 #19 2024-09-13 02:58:42 ~7 min android-e2e 🤖apk 📲
✔️ 1ba3ae8 #20 2024-09-13 03:00:25 ~9 min android 🤖apk 📲
✔️ 1ba3ae8 #19 2024-09-13 03:02:30 ~11 min ios 📱ipa 📲

Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably will need to improve monitoring of this service.

@siddarthkay siddarthkay force-pushed the fix-infura-ipfs-url branch 2 times, most recently from 6b6507b to 49ffbf9 Compare August 23, 2024 09:25
@siddarthkay siddarthkay force-pushed the fix-infura-ipfs-url branch 3 times, most recently from d7cce91 to 8811587 Compare August 29, 2024 03:10
@siddarthkay siddarthkay force-pushed the fix-infura-ipfs-url branch 4 times, most recently from d1c3657 to 0e60f20 Compare September 4, 2024 07:09
@mariia-skrypnyk mariia-skrypnyk self-assigned this Sep 4, 2024
@status-im-auto
Copy link
Member

57% of end-end tests have passed

Total executed tests: 7
Failed tests: 3
Expected to fail tests: 0
Passed tests: 4
IDs of failed tests: 727230,727229,702843 

Failed tests (3)

Click to expand
  • Rerun failed tests

  • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
    Device 2: `Text` is `0.04719 ETH`

    critical/test_wallet.py:190: in test_wallet_send_asset_from_drawer
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Sender balance is not updated on Etherscan, it is 0.4409 but expected to be 0.4411
    



    2. test_wallet_send_eth, id: 727229

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]
    Device 2: Text is 0.04709 ETH

    critical/test_wallet.py:159: in test_wallet_send_eth
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Sender balance is not updated on Etherscan, it is 0.4412 but expected to be 0.4414
    



    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Looking for a message by text: Message AFTER edit 2 (Edited)
    Device 2: Find ChatElementByText by xpath: //*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']

    critical/chats/test_public_chat_browsing.py:378: in test_community_message_edit
        self.channel_2.set_reaction(message_text_after_edit)
    ../views/chat_view.py:1053: in set_reaction
        self.chat_element_by_text(message).long_press_until_element_is_shown(element)
    ../views/base_element.py:327: in long_press_until_element_is_shown
        element = self.find_element()
    ../views/chat_view.py:116: in find_element
        self.wait_for_visibility_of_element(20)
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Passed tests (4)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    @mariia-skrypnyk
    Copy link

    mariia-skrypnyk commented Sep 4, 2024

    Hey @siddarthkay !

    Checked issue on iOS PR build and on Android release build issue still exist.

    Screenshot 2024-09-04 at 11 41 58

    @mariia-skrypnyk
    Copy link

    @siddarthkay any updates on this?

    @siddarthkay
    Copy link
    Contributor Author

    @mariia-skrypnyk : I'll check today. thanks!

    @siddarthkay siddarthkay force-pushed the fix-infura-ipfs-url branch 5 times, most recently from 16aa8d2 to 301c7a6 Compare September 12, 2024 11:48
    @siddarthkay
    Copy link
    Contributor Author

    @mariia-skrypnyk
    I fixed the issue and could receive stickers from Desktop App on both PR and on release builds on my iPhone.

    IMG_6269

    @mariia-skrypnyk
    Copy link

    mariia-skrypnyk commented Sep 12, 2024

    Hey @siddarthkay !

    Thanks for your fix.
    Looks good on PR builds.
    Couldn't build android release build. Build is failed.
    Can you help me with iOS or Android release build for testing?

    @siddarthkay
    Copy link
    Contributor Author

    you can find iOS for this branch in Testflight -> 2.30.21106 (20240912141620)

    @status-im-auto
    Copy link
    Member

    86% of end-end tests have passed

    Total executed tests: 7
    Failed tests: 1
    Expected to fail tests: 0
    Passed tests: 6
    
    IDs of failed tests: 727229 
    

    Failed tests (1)

    Click to expand
  • Rerun failed tests

  • Class TestWalletMultipleDevice:

    1. test_wallet_send_eth, id: 727229

    Device 2: `Text` is `0.05569 ETH`
    Device 1: `Text` is `0.42924 ETH`

    critical/test_wallet.py:159: in test_wallet_send_eth
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Sender balance is not updated on Etherscan, it is 0.4292 but expected to be 0.4293
    



    Passed tests (6)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    @mariia-skrypnyk
    Copy link

    @siddarthkay checked on release too!

    All good!
    Thanks!

    PR can be merged!

    @siddarthkay siddarthkay merged commit ac8b06b into develop Sep 13, 2024
    6 checks passed
    @siddarthkay siddarthkay deleted the fix-infura-ipfs-url branch September 13, 2024 03:06
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Stickers sent from desktop are displayed as a blank message on mobile (Only on release Jenkins builds)
    5 participants