Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#20598] Onboarding - can't create profile #21170

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

ulisesmac
Copy link
Contributor

fixes #20598

Summary

This PR fixes the navigation in the "Continue" button for the "Create profile" screen. Demo:

Screencast.from.2024-09-03.17-06-51.mp4

Review notes

The problem was due to a flag set in the seed phrase flow and not being properly cleaned. This PR is cleaning it by using rn/use-unmount.

Testing notes

Please test the whole onboarding flow invloving the seed phrase and profile creation.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • onboarding

Steps to test

Please follow the steps specified in the issue #20598 also the video attached shows the issue being solved.

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Sep 3, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8a82e5f #1 2024-09-03 23:16:58 ~4 min tests 📄log
✔️ 8a82e5f #1 2024-09-03 23:19:02 ~6 min android-e2e 🤖apk 📲
✔️ 8a82e5f #1 2024-09-03 23:20:18 ~7 min android 🤖apk 📲
✔️ 8a82e5f #1 2024-09-03 23:25:08 ~12 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4f5fc79 #2 2024-09-07 08:51:49 ~6 min android-e2e 🤖apk 📲
✔️ 4f5fc79 #2 2024-09-07 10:12:42 ~10 min ios 📱ipa 📲
✔️ 4f5fc79 #2 2024-09-07 10:49:18 ~6 min android 🤖apk 📲
✔️ 4f5fc79 #2 2024-09-07 11:05:51 ~4 min tests 📄log
✔️ 42ada3e #3 2024-09-09 20:29:49 ~4 min tests 📄log
✔️ 42ada3e #3 2024-09-09 20:33:05 ~7 min android-e2e 🤖apk 📲
✔️ 42ada3e #3 2024-09-09 20:33:28 ~7 min android 🤖apk 📲
✔️ 42ada3e #3 2024-09-09 20:41:58 ~16 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 7
Failed tests: 1
Expected to fail tests: 0
Passed tests: 6
IDs of failed tests: 702843 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Test setup failed: critical/chats/test_public_chat_browsing.py:308: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:329: in create_shared_drivers
        raise e
    base_test_case.py:319: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    Device sessions

    Passed tests (6)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    Hi @ulisesmac thank you for PR. No issues from my side. PR is ready to be merged

    @ulisesmac ulisesmac merged commit fa4ea06 into develop Sep 9, 2024
    6 checks passed
    @ulisesmac ulisesmac deleted the 20598-onboarding-cant-create-profile branch September 9, 2024 20:43
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    5 participants