-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#20598] Onboarding - can't create profile #21170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (4)
|
briansztamfater
approved these changes
Sep 4, 2024
ilmotta
approved these changes
Sep 4, 2024
86% of end-end tests have passed
Failed tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (6)Click to expandClass TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
Hi @ulisesmac thank you for PR. No issues from my side. PR is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20598
Summary
This PR fixes the navigation in the "Continue" button for the "Create profile" screen. Demo:
Screencast.from.2024-09-03.17-06-51.mp4
Review notes
The problem was due to a flag set in the seed phrase flow and not being properly cleaned. This PR is cleaning it by using
rn/use-unmount
.Testing notes
Please test the whole onboarding flow invloving the seed phrase and profile creation.
Platforms
Areas that maybe impacted
Functional
Steps to test
Please follow the steps specified in the issue #20598 also the video attached shows the issue being solved.
status: ready