-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#21212] - Fix not joined options for token gated communities #21247
Conversation
(let [common [(show-qr id) (share-community id)] | ||
specific (if token-gated? | ||
[(invite-contacts id) (view-token-gating id)] | ||
[(view-members id) (view-rules id intro-message) (invite-contacts id)])] | ||
[(concat specific common)])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the user isn't joined we also showed the "Mark as read" button, but it's was wrong, here I'm also fixing it
Jenkins BuildsClick to see older builds (12)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little by little, one less 🐛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff ✅
Hi @Francesca-G ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ulisesmac it looks good to me, except the "View token requirements" option isn't showing up in the drawer
I used the linked community to test
e9c41ee
to
8ec27f5
Compare
Hey @ulisesmac @Francesca-G ! I also do not see "View token requirements" option neither on community from description no my testing token gated one. |
I've just checked it, the token gating was under a Now, we need to disable the test networks for the wallet and the option will appear. Please give it a second check. Thank you. |
725847f
to
e6476f5
Compare
@ulisesmac Thanks, looks good from my side. @Francesca-G please, check. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the fix, looks good 👍
81217ae
to
6f29c9a
Compare
6f29c9a
to
7d288c4
Compare
fixes #21212
Summary
This PR fixes a the options shown for token gated communities when the user isn't joined.
Options are now correct:
Additionally, changes the "Mark as read" icon, we were using:
Now (as in figma):
Platforms
Steps to test
https://status.app/c/G1EAAMTyFm0fBflGtiFYF5IgNAQzPiCADTgBCjTjlZ_tpjItNSiTKjz7Bvw2VF7r7XG_tFRcPsgFyoCnHC2MDzF5Bw==#zQ3shsQJt1uYuzLvQ1mpcDHSUnEYTV5wMmtzkoqER8kezGqAE
status: ready