Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#21212] - Fix not joined options for token gated communities #21247

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

ulisesmac
Copy link
Contributor

fixes #21212

Summary

This PR fixes a the options shown for token gated communities when the user isn't joined.

Options are now correct:

Additionally, changes the "Mark as read" icon, we were using:

Screenshot from 2024-09-10 17-03-36

Now (as in figma):

Screenshot from 2024-09-10 17-03-46

Platforms

  • Android
  • iOS

Steps to test

  • Open Status
  • Create a new profile and visit a token gated communitiy, you can use this one:

https://status.app/c/G1EAAMTyFm0fBflGtiFYF5IgNAQzPiCADTgBCjTjlZ_tpjItNSiTKjz7Bvw2VF7r7XG_tFRcPsgFyoCnHC2MDzF5Bw==#zQ3shsQJt1uYuzLvQ1mpcDHSUnEYTV5wMmtzkoqER8kezGqAE

  • Click on the 3 dots button and check the modal

status: ready

@ulisesmac ulisesmac self-assigned this Sep 10, 2024
Comment on lines 140 to 149
(let [common [(show-qr id) (share-community id)]
specific (if token-gated?
[(invite-contacts id) (view-token-gating id)]
[(view-members id) (view-rules id intro-message) (invite-contacts id)])]
[(concat specific common)]))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the user isn't joined we also showed the "Mark as read" button, but it's was wrong, here I'm also fixing it

@status-im-auto
Copy link
Member

status-im-auto commented Sep 10, 2024

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e9c41ee #2 2024-09-10 23:21:14 ~5 min tests 📄log
✔️ e9c41ee #2 2024-09-10 23:25:10 ~8 min ios 📱ipa 📲
✔️ e9c41ee #2 2024-09-10 23:25:10 ~9 min android-e2e 🤖apk 📲
✔️ e9c41ee #2 2024-09-10 23:25:34 ~9 min android 🤖apk 📲
✔️ 8ec27f5 #3 2024-09-17 11:58:36 ~4 min tests 📄log
✔️ 8ec27f5 #3 2024-09-17 12:00:21 ~6 min android-e2e 🤖apk 📲
✔️ 8ec27f5 #3 2024-09-17 12:02:06 ~8 min android 🤖apk 📲
✔️ 8ec27f5 #3 2024-09-17 12:05:11 ~11 min ios 📱ipa 📲
e6476f5 #5 2024-09-18 02:08:45 ~2 min tests 📄log
✔️ e6476f5 #5 2024-09-18 02:12:13 ~6 min android-e2e 🤖apk 📲
✔️ e6476f5 #5 2024-09-18 02:13:00 ~6 min android 🤖apk 📲
✔️ e6476f5 #5 2024-09-18 02:15:02 ~8 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
81217ae #6 2024-09-18 23:19:39 ~3 min tests 📄log
✔️ 7d288c4 #8 2024-09-18 23:26:15 ~4 min tests 📄log
✔️ 7d288c4 #8 2024-09-18 23:28:13 ~6 min android-e2e 🤖apk 📲
✔️ 7d288c4 #8 2024-09-18 23:28:48 ~6 min android 🤖apk 📲
✔️ 7d288c4 #8 2024-09-18 23:30:45 ~8 min ios 📱ipa 📲

Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little by little, one less 🐛

Copy link
Member

@seanstrom seanstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff ✅

@ulisesmac
Copy link
Contributor Author

Hi @Francesca-G !
Could you please give it a check?

@Francesca-G Francesca-G self-requested a review September 16, 2024 11:33
Copy link

@Francesca-G Francesca-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulisesmac it looks good to me, except the "View token requirements" option isn't showing up in the drawer

Screenshot 2024-09-16 alle 13 34 49

I used the linked community to test

@mariia-skrypnyk mariia-skrypnyk self-assigned this Sep 17, 2024
@mariia-skrypnyk mariia-skrypnyk force-pushed the 21212-token-gated-community-options branch from e9c41ee to 8ec27f5 Compare September 17, 2024 11:53
@mariia-skrypnyk
Copy link

mariia-skrypnyk commented Sep 17, 2024

Hey @ulisesmac @Francesca-G !

I also do not see "View token requirements" option neither on community from description no my testing token gated one.

@ulisesmac
Copy link
Contributor Author

@Francesca-G @mariia-skrypnyk

I've just checked it, the token gating was under a show not implemeted features flag, introduced in this PR:
#20240 (comment), so it wasn't shown.

Now, we need to disable the test networks for the wallet and the option will appear.

Please give it a second check. Thank you.

@ulisesmac ulisesmac force-pushed the 21212-token-gated-community-options branch 2 times, most recently from 725847f to e6476f5 Compare September 18, 2024 02:05
@mariia-skrypnyk
Copy link

@ulisesmac Thanks, looks good from my side.

@Francesca-G please, check. 🙏

Copy link

@Francesca-G Francesca-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fix, looks good 👍

@ulisesmac ulisesmac force-pushed the 21212-token-gated-community-options branch from 81217ae to 6f29c9a Compare September 18, 2024 23:20
@ulisesmac ulisesmac force-pushed the 21212-token-gated-community-options branch from 6f29c9a to 7d288c4 Compare September 18, 2024 23:21
@ulisesmac ulisesmac merged commit f606dc0 into develop Sep 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Token gated community context drawer has wrong options
6 participants