Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#21205] Update metadata for F-Droid #21320

Merged
merged 7 commits into from
Sep 26, 2024

Conversation

ulisesmac
Copy link
Contributor

@ulisesmac ulisesmac commented Sep 24, 2024

fixes #21205

Summary

Changes in this PR:

  1. Remove unsupported languages
    2. Rename folders to match Notion language names: ar -> ar-SA and uk->uk-UA (reverted)
  2. Update assets for all languages:
    • The aspect ratio of previous images doesn't match the new ones, so the previous resolution is
      1284 x 2568 and the picked for the new ones is 1440 x 2560.

status: ready

@ulisesmac ulisesmac requested a review from ilmotta September 24, 2024 23:54
@ulisesmac ulisesmac self-assigned this Sep 24, 2024
@ulisesmac
Copy link
Contributor Author

@ilmotta Could you please tell me if the changes 2 and 3 listed in the description are fine?

@status-im-auto
Copy link
Member

status-im-auto commented Sep 24, 2024

Jenkins Builds

Click to see older builds (15)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cdda52e #1 2024-09-24 23:59:25 ~4 min tests 📄log
✔️ cdda52e #1 2024-09-25 00:01:06 ~6 min android-e2e 🤖apk 📲
✔️ cdda52e #1 2024-09-25 00:02:44 ~8 min android 🤖apk 📲
✔️ cdda52e #1 2024-09-25 00:08:05 ~13 min ios 📱ipa 📲
✔️ ecdb5a2 #2 2024-09-26 01:04:20 ~4 min tests 📄log
✔️ ecdb5a2 #2 2024-09-26 01:08:25 ~8 min android-e2e 🤖apk 📲
✔️ ecdb5a2 #2 2024-09-26 01:08:50 ~9 min android 🤖apk 📲
✔️ ecdb5a2 #2 2024-09-26 01:12:21 ~12 min ios 📱ipa 📲
✔️ e246c01 #3 2024-09-26 20:52:23 ~4 min tests 📄log
✔️ e246c01 #3 2024-09-26 20:55:58 ~8 min android-e2e 🤖apk 📲
✔️ e246c01 #3 2024-09-26 20:56:38 ~9 min android 🤖apk 📲
✔️ fda28f4 #4 2024-09-26 21:04:06 ~4 min tests 📄log
✔️ fda28f4 #4 2024-09-26 21:07:40 ~8 min android-e2e 🤖apk 📲
✔️ fda28f4 #4 2024-09-26 21:08:01 ~8 min android 🤖apk 📲
✔️ fda28f4 #4 2024-09-26 21:12:42 ~13 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 34d4161 #5 2024-09-26 21:18:26 ~4 min tests 📄log
✔️ 34d4161 #5 2024-09-26 21:22:25 ~8 min android-e2e 🤖apk 📲
✔️ 34d4161 #5 2024-09-26 21:22:51 ~9 min android 🤖apk 📲
✔️ 34d4161 #5 2024-09-26 21:26:33 ~12 min ios 📱ipa 📲
✔️ ac59577 #6 2024-09-26 21:38:05 ~4 min tests 📄log
✔️ ac59577 #6 2024-09-26 21:41:39 ~8 min android-e2e 🤖apk 📲
✔️ ac59577 #6 2024-09-26 21:42:18 ~9 min android 🤖apk 📲
✔️ ac59577 #6 2024-09-26 21:50:34 ~17 min ios 📱ipa 📲

@ulisesmac ulisesmac force-pushed the 21205-update-metadata-for-f-Droid branch from cdda52e to ecdb5a2 Compare September 26, 2024 00:59
@ulisesmac ulisesmac marked this pull request as ready for review September 26, 2024 01:00
@ulisesmac ulisesmac requested a review from jakubgs as a code owner September 26, 2024 01:00
@licaon-kter
Copy link

licaon-kter commented Sep 26, 2024

there's no reason to add English screenshots to other languages. Nor duplicate the other like featureGraphic and icon

If images are missing English ones are used by default, afaik

@ulisesmac ulisesmac force-pushed the 21205-update-metadata-for-f-Droid branch from ecdb5a2 to e246c01 Compare September 26, 2024 20:47
@ulisesmac
Copy link
Contributor Author

there's no reason to add English screenshots to other languages. Nor duplicate the other like featureGraphic and icon

If images are missing English ones are used by default, afaik

@licaon-kter Thank you. I've fixed the duplicates

@ulisesmac ulisesmac force-pushed the 21205-update-metadata-for-f-Droid branch from e246c01 to fda28f4 Compare September 26, 2024 20:58
@ilmotta
Copy link
Contributor

ilmotta commented Sep 26, 2024

@ulisesmac, the images seem too large for our repo. They will probably shrink significantly if you use the recently merged script scripts/compress_image.sh. Could you try it and see if you get images that look similar in quality? You might even want to play and reduce the quality in the magick command, which is currently set at 100.

@ilmotta
Copy link
Contributor

ilmotta commented Sep 26, 2024

@ilmotta Could you please tell me if the changes 2 and 3 listed in the description are fine?

@ulisesmac:

Rename folders to match Notion language names: ar -> ar-SA and uk->uk-UA

Unfortunately I'm not sure as well. But I found this, which suggests we should perhaps prefer to keep ar, and not the country variations:

First and foremost, Android must already support the specific language and locale you want to add. We cannot work with languages that Android and the SDK do not support, the tools simply break down. Next, if you are considering adding a country-specific variant of a language (e.g. de-AT), first make sure that the main language is well maintained (e.g. de). Your contribution might be useful to more people if you contribute to the existing version of your language rather than the country-specific variant.

-- https://f-droid.org/docs/Translation_and_Localization/

The aspect ratio of previous images doesn't match the new ones

I couldn't find anything in F-Droid docs, but because Android phones vary a lot in aspect ratio, it's probably fine that we are slightly changing them.

@ulisesmac
Copy link
Contributor Author

@ulisesmac, the images seem too large for our repo. They will probably shrink significantly if you use the recently merged script scripts/compress_image.sh. Could you try it and see if you get images that look similar in quality? You might even want to play and reduce the quality in the magick command, which is currently set at 100.

@ilmotta
Weird that our script created slightly heavier images (added around 200KB).

Now I compressed the images, they look identical IMO, I compressed them to get 90% of their quality, previously our heavier image was 1.45MB and now it is 450 KB 🥳

LMK if any other change is needed.

@ulisesmac
Copy link
Contributor Author

@ilmotta Could you please tell me if the changes 2 and 3 listed in the description are fine?

@ulisesmac:

Rename folders to match Notion language names: ar -> ar-SA and uk->uk-UA

Unfortunately I'm not sure as well. But I found this, which suggests we should perhaps prefer to keep ar, and not the country variations:

First and foremost, Android must already support the specific language and locale you want to add. We cannot work with languages that Android and the SDK do not support, the tools simply break down. Next, if you are considering adding a country-specific variant of a language (e.g. de-AT), first make sure that the main language is well maintained (e.g. de). Your contribution might be useful to more people if you contribute to the existing version of your language rather than the country-specific variant.
-- https://f-droid.org/docs/Translation_and_Localization/

The aspect ratio of previous images doesn't match the new ones

I couldn't find anything in F-Droid docs, but because Android phones vary a lot in aspect ratio, it's probably fine that we are slightly changing them.

Done 👍

Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's go F-Droid!

@licaon-kter
Copy link

Also note, these will be used by the next release that includes them. They won't magically appear in F-Droid on merge. ;)

@ilmotta
Copy link
Contributor

ilmotta commented Sep 26, 2024

Also note, these will be used by the next release that includes them. They won't magically appear in F-Droid on merge. ;)

F-Droid will only use metadata files from the latest release. This means that fdroidserver will check out the latest version it knows and scan the repository at the state of that version for metadata files.

-- https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/

@licaon-kter, my mistake on that. From the docs I had the impression the repo would be scanned for the metadata every so often because I read the word "latest" carelessly, but of course, in retrospect, makes no sense. The next release should happen in less a month from now, well 🤷🏼

@ulisesmac ulisesmac merged commit 93f00c4 into develop Sep 26, 2024
6 checks passed
@ulisesmac ulisesmac deleted the 21205-update-metadata-for-f-Droid branch September 26, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update application page metadata for F-Droid
5 participants