-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#21205] Update metadata for F-Droid #21320
Conversation
@ilmotta Could you please tell me if the changes |
Jenkins BuildsClick to see older builds (15)
|
cdda52e
to
ecdb5a2
Compare
there's no reason to add English screenshots to other languages. Nor duplicate the other like featureGraphic and icon If images are missing English ones are used by default, afaik |
ecdb5a2
to
e246c01
Compare
@licaon-kter Thank you. I've fixed the duplicates |
e246c01
to
fda28f4
Compare
@ulisesmac, the images seem too large for our repo. They will probably shrink significantly if you use the recently merged script |
Unfortunately I'm not sure as well. But I found this, which suggests we should perhaps prefer to keep
I couldn't find anything in F-Droid docs, but because Android phones vary a lot in aspect ratio, it's probably fine that we are slightly changing them. |
@ilmotta Now I compressed the images, they look identical IMO, I compressed them to get 90% of their quality, previously our heavier image was 1.45MB and now it is 450 KB 🥳 LMK if any other change is needed. |
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's go F-Droid!
Also note, these will be used by the next release that includes them. They won't magically appear in F-Droid on merge. ;) |
@licaon-kter, my mistake on that. From the docs I had the impression the repo would be scanned for the metadata every so often because I read the word "latest" carelessly, but of course, in retrospect, makes no sense. The next release should happen in less a month from now, well 🤷🏼 |
fixes #21205
Summary
Changes in this PR:
2. Rename folders to match Notion language names:(reverted)ar
->ar-SA
anduk
->uk-UA
1284 x 2568
and the picked for the new ones is1440 x 2560
.status: ready