-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable swap and bridge options on testnet mode #21343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansztamfater
requested review from
alwx,
shivekkhurana,
vkjr,
smohamedjavid,
clauxx and
mohsen-ghafouri
September 27, 2024 17:54
Jenkins Builds
|
hi @briansztamfater could you please rebase and resolve existing conflicts? Thanx |
mohsen-ghafouri
approved these changes
Sep 30, 2024
Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater
force-pushed
the
feat/disable-swaps-on-testnet
branch
from
September 30, 2024 14:32
0881bc8
to
47e56d8
Compare
@VolodLytvynenko done! |
✔️ status-mobile/prs/tests/PR-21343#2 🔹 ~4 min 59 sec 🔹 47e56d8 🔹 📦 tests package |
86% of end-end tests have passed
Failed tests (1)Click to expandClass TestWalletMultipleDevice:
Passed tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
|
hi @briansztamfater thank you for PR. No issues from my side. PR is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21342
Summary
This PR disables swap and bridge options when the user is in testnet mode
Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready