Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable swap and bridge options on testnet mode #21343

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

briansztamfater
Copy link
Member

fixes #21342

Summary

This PR disables swap and bridge options when the user is in testnet mode


Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • wallet / transactions

Steps to test

  • Open Status
  • Go to wallet
  • Verify either Swap and Bridge options are accessible when the user is in testnet mode

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Sep 27, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0881bc8 #1 2024-09-27 18:01:03 ~5 min tests 📄log
✔️ 0881bc8 #1 2024-09-27 18:04:32 ~9 min android-e2e 🤖apk 📲
✔️ 0881bc8 #1 2024-09-27 18:05:14 ~9 min android 🤖apk 📲
✔️ 0881bc8 #1 2024-09-27 18:07:18 ~12 min ios 📱ipa 📲
✔️ 47e56d8 #2 2024-09-30 14:37:31 ~4 min tests 📄log
✔️ 47e56d8 #2 2024-09-30 14:39:31 ~6 min android 🤖apk 📲
✔️ 47e56d8 #2 2024-09-30 14:40:14 ~7 min android-e2e 🤖apk 📲
✔️ 47e56d8 #2 2024-09-30 14:41:33 ~8 min ios 📱ipa 📲

@VolodLytvynenko VolodLytvynenko self-assigned this Sep 30, 2024
@VolodLytvynenko
Copy link
Contributor

hi @briansztamfater could you please rebase and resolve existing conflicts? Thanx

@briansztamfater briansztamfater force-pushed the feat/disable-swaps-on-testnet branch from 0881bc8 to 47e56d8 Compare September 30, 2024 14:32
@briansztamfater
Copy link
Member Author

@VolodLytvynenko done!

@status-im-auto
Copy link
Member

✔️ status-mobile/prs/tests/PR-21343#2 🔹 ~4 min 59 sec 🔹 47e56d8 🔹 📦 tests package

@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 7
Failed tests: 1
Expected to fail tests: 0
Passed tests: 6
IDs of failed tests: 727230 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
    Device 2: `Text` is `0.07489 ETH`

    critical/test_wallet.py:190: in test_wallet_send_asset_from_drawer
        self.errors.verify_no_errors()
    base_test_case.py:192: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Sender balance is not updated on Etherscan, it is 0.4076 but expected to be 0.4077
    



    Passed tests (6)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_eth, id: 727229

    @VolodLytvynenko
    Copy link
    Contributor

    hi @briansztamfater thank you for PR. No issues from my side. PR is ready to be merged

    @briansztamfater briansztamfater merged commit 0c3e836 into develop Sep 30, 2024
    6 of 7 checks passed
    @briansztamfater briansztamfater deleted the feat/disable-swaps-on-testnet branch September 30, 2024 16:13
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Disable swap and bridge features on Testnet Mode
    4 participants