Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove run-tests from wallet-send event tests #21373

Merged
merged 1 commit into from
Oct 3, 2024
Merged

chore: remove run-tests from wallet-send event tests #21373

merged 1 commit into from
Oct 3, 2024

Conversation

seanstrom
Copy link
Member

@seanstrom seanstrom commented Oct 3, 2024 •
edited
Loading

Summary

  • This PR removes an unneeded (run-tests) expression that can emit false failures in CI and running unit tests locally

Platforms

  • CI

status: ready

@seanstrom seanstrom self-assigned this Oct 3, 2024
@seanstrom seanstrom requested a review from clauxx October 3, 2024 10:54
clauxx
clauxx approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@clauxx clauxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@status-im-auto
Copy link
Member

status-im-auto commented Oct 3, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (1)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 350a8df #1 2024-10-03 10:56:04 ~2 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ a5be4e9 #2 2024-10-03 11:01:52 ~2 min tests 📄log
❌ 761f8ad #3 2024-10-03 11:08:34 ~3 min tests 📄log
✔️ 761f8ad #3 2024-10-03 11:11:36 ~6 min android 🤖apk 📲
✔️ 761f8ad #3 2024-10-03 11:12:12 ~7 min android-e2e 🤖apk 📲
✔️ 761f8ad #3 2024-10-03 11:15:04 ~10 min ios 📱ipa 📲
✔️ 761f8ad #4 2024-10-03 11:18:40 ~1 min tests 📄log

@seanstrom seanstrom force-pushed the seanstrom/remove-run-tests-from-tests branch from 350a8df to a5be4e9 Compare October 3, 2024 10:59
@seanstrom seanstrom force-pushed the seanstrom/remove-run-tests-from-tests branch from a5be4e9 to 761f8ad Compare October 3, 2024 11:04
@seanstrom seanstrom merged commit 1691e2f into develop Oct 3, 2024
6 checks passed
@seanstrom seanstrom deleted the seanstrom/remove-run-tests-from-tests branch October 3, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clauxx clauxx clauxx approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

@shivekkhurana shivekkhurana shivekkhurana approved these changes

Assignees

@seanstrom seanstrom

Labels
skip-manual-qa
Projects
Pipeline for QA
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seanstrom @status-im-auto @shivekkhurana @flexsurfer @clauxx