Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swap): update max value when the account is switched #21395

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

briansztamfater
Copy link
Member

fixes #21304

Summary

This PR fixes a bug that makes max value to not be updated when the account is switched on the swap page

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • wallet / transactions

Steps to test

  • Open Status
  • Log in
  • Go to swap
  • Select a token
  • Change the account on the setup swap screen
  • Verify the max value is properly updated

status: ready

@status-im-auto
Copy link
Member

✔️ status-mobile/prs/tests/PR-21395#1 🔹 ~4 min 44 sec 🔹 fc78b39 🔹 📦 tests package

@status-im-auto
Copy link
Member

status-im-auto commented Oct 8, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fc78b39 #1 2024-10-08 05:01:44 ~4 min tests 📄log
✔️ fc78b39 #1 2024-10-08 05:04:43 ~7 min android-e2e 🤖apk 📲
✔️ fc78b39 #1 2024-10-08 05:06:00 ~8 min android 🤖apk 📲
✔️ fc78b39 #1 2024-10-08 05:07:55 ~10 min ios 📱ipa 📲
✔️ b5e05d8 #2 2024-10-08 21:10:26 ~4 min tests 📄log
✔️ b5e05d8 #2 2024-10-08 21:13:07 ~6 min android-e2e 🤖apk 📲
✔️ b5e05d8 #2 2024-10-08 21:14:48 ~8 min android 🤖apk 📲
✔️ b5e05d8 #2 2024-10-08 21:16:27 ~10 min ios 📱ipa 📲

@briansztamfater briansztamfater added the wallet-core Issues for mobile wallet team label Oct 8, 2024
@pavloburykh pavloburykh self-assigned this Oct 8, 2024
@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 7
Failed tests: 0
Expected to fail tests: 0
Passed tests: 7

Passed tests (7)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

@pavloburykh
Copy link
Contributor

@briansztamfater thank you for the PR! no issues from my side. Ready for merge.

@briansztamfater briansztamfater force-pushed the fix/swap-update-max-value branch from fc78b39 to b5e05d8 Compare October 8, 2024 21:06
@briansztamfater briansztamfater merged commit 874ecec into develop Oct 8, 2024
6 checks passed
@briansztamfater briansztamfater deleted the fix/swap-update-max-value branch October 8, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

Max value is not updated when the account is switched on the swap page
6 participants