-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(swap): update max value when the account is switched #21395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansztamfater
requested review from
alwx,
shivekkhurana,
vkjr,
smohamedjavid,
clauxx and
mohsen-ghafouri
October 8, 2024 04:57
✔️ status-mobile/prs/tests/PR-21395#1 🔹 ~4 min 44 sec 🔹 fc78b39 🔹 📦 tests package |
Jenkins Builds
|
clauxx
approved these changes
Oct 8, 2024
shivekkhurana
approved these changes
Oct 8, 2024
vkjr
approved these changes
Oct 8, 2024
100% of end-end tests have passed
Passed tests (7)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
|
@briansztamfater thank you for the PR! no issues from my side. Ready for merge. |
Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater
force-pushed
the
fix/swap-update-max-value
branch
from
October 8, 2024 21:06
fc78b39
to
b5e05d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21304
Summary
This PR fixes a bug that makes max value to not be updated when the account is switched on the swap page
Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready