Keycard - Allow user to migrate existing Profile [Part 2] #21408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flexsurfer
commented
Oct 9, 2024
| :phrase mnemonic | ||
| :on-error | ||
| set-invalid-seed-phrase}) | ||
| (rf/dispatch |
There was a problem hiding this comment.
onboarding still a special case, should be refactored later
flexsurfer
commented
Oct 9, 2024
| (rn/use-unmount | ||
| #(rf/dispatch [:onboarding/clear-navigated-to-enter-seed-phrase-from-screen])) | ||
| (when-not on-success | ||
| #(rf/dispatch [:onboarding/clear-navigated-to-enter-seed-phrase-from-screen]))) |
flexsurfer
commented
Oct 9, 2024
| on-error]}])}]) | ||
| (rf/dispatch [:open-modal :screen/backup-recovery-phrase | ||
| {:on-success (fn [{:keys [masked-seed-phrase | ||
| random-phrase]}])}]))} |
There was a problem hiding this comment.
this is the end of the task, and will be continued in the next PRs
Jenkins BuildsClick to see older builds (4)
|
flexsurfer
changed the title
71% of end-end tests have passedFailed tests (2)Click to expandClass TestWalletMultipleDevice:
Passed tests (5)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
|
pavloburykh
force-pushed
the
feature/Backup_profile_recovery_#21366
branch
from
e05973e to
ab27849
Compare
94% of end-end tests have passedFailed tests (3)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Passed tests (51)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestFallbackMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
|
Parveshdhull
approved these changes
Oct 14, 2024
| :profile/recovery-phrase-backed-up? | ||
| :<- [:profile/profile] | ||
| (fn [profile] | ||
| (not (boolean (seq (:mnemonic profile)))))) |
There was a problem hiding this comment.
I think we can remove boolean here.
alwx
approved these changes
Oct 14, 2024
100% of end-end tests have passedPassed tests (3)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
|
|
hi @flexsurfer thank you for PR. No issues from my side. PR can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21366
fixes #21367
This PR makes two screens used by onboarding and wallet more general, so they could be used anywhere in the app
:screen/wallet.backup-recovery-phraseis now more general:screen/backup-recovery-phraseand
:screen/wallet.enter-seed-phraseis:screen/use-recovery-phrase:screen/use-recovery-phraseis still not perfect, because it was implemented for onboarding and is still used there, but the onboarding code is a nightmare, and should be completely refactored laterQA: we need to make sure
backup-recovery-phraseworks fine in wallet still, anduse-recovery-phrasework on onboarding and in walletin this PR we still don't test keycard, thank you