Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: fix sha256 of nixpkgs release 24-05 #21416

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

siddarthkay
Copy link
Contributor

Summary

Pavlo reported :

(mypython) Pavlos-MBP:status-mobile pavloburykh$ make shell
Configuring Nix shell for target 'default'...
warning: ignoring untrusted substituter 'https://nix-cache.status.im/'
error: hash mismatch in file downloaded from 'https://github.com/NixOS/nixpkgs/archive/df27247e6f3e636c119e2610bf12d38b5e98cc79.tar.gz':
         specified: sha256:0zynbk52khdfhg4qfv26h3r5156xff5p0cga2cin7b07i7lqminh
         got:       sha256:0bbvimk7xb7akrx106mmsiwf9nzxnssisqmqffla03zz51d0kz2n
(use '--show-trace' to show detailed location information)
make: *** [shell] Error 102

Which indicates mismatch of hashes. This change was introduced in #21374
Why this was not caught sooner or in the PR?
Because I just copy pasted the nix hash and cache was used, Hence it was not caught back then.

Platforms

  • Android
  • iOS

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Oct 11, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2ec5643 #1 2024-10-11 07:29:17 ~21 min ios 📱ipa 📲
✔️ 2ec5643 #3 2024-10-11 07:43:13 ~4 min tests 📄log
✔️ 2ec5643 #2 2024-10-11 08:02:14 ~8 min android 🤖apk 📲
✔️ 2ec5643 #2 2024-10-11 08:10:18 ~6 min android-e2e 🤖apk 📲

@pavloburykh
Copy link
Contributor

make shell works fine in this branch, thanks @siddarthkay

Let's wait for green light from @Horupa-Olena regarding manual smoke check. And for e2e results.

@status-im-auto
Copy link
Member

71% of end-end tests have passed

Total executed tests: 7
Failed tests: 2
Expected to fail tests: 0
Passed tests: 5
IDs of failed tests: 703133,702843 

Failed tests (2)

Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
    Device 2: Wait for element `Button` for max 120s and click when it is available

    Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:420: in join_community
        self.join_button.wait_and_click(120)
    ../views/base_element.py:100: in wait_and_click
        self.wait_for_visibility_of_element(sec)
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button

    critical/chats/test_public_chat_browsing.py:244: in test_restore_multiaccount_with_waku_backup_remove_switch
        self.errors.verify_no_errors()
    base_test_case.py:192: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     zQ3...dWXh5 was not restored as a contact from waku backup!
    E    zQ3...Vacac was not restored as a contact from waku backup!
    E    admin_open was not restored from waku-backup!!
    E    member_open was not restored from waku-backup!!
    E    admin_closed was not restored from waku-backup!!
    E    member_closed was not restored from waku-backup!!
    



    Device sessions

    Passed tests (5)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    @Horupa-Olena
    Copy link

    @siddarthkay Thank you for the PR!
    My smoke testing didn't reveal any issues, you can proceed with the merge.

    @siddarthkay siddarthkay merged commit 66f1773 into develop Oct 11, 2024
    6 of 7 checks passed
    @siddarthkay siddarthkay deleted the fix-hash-of-stable-nixpkgs branch October 11, 2024 09:46
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants