fix(swap): round values for very small values in fiat and crypto

[briansztamfater]

fixes #21415
fixes #21419

Summary

This PR fixes fiat values shown as 0 when the value is less than 0.01, and also the same for crypto tokens when the value is less than 0.000001. Also fixes an error when long-tapping on an asset from the wallet main page and selecting "Swap".

Platforms

• Android
• iOS

Areas that maybe impacted

Functional

• wallet / transactions

Steps to test

Issue #21415

• Go to swap
• Enter value with a lot of decimals (example: 0.000000000001 DAI)
• Go to check rounding

Issue #21419

• Go to wallet main page
• Long tap asset (in my case WBTC)
• Tap "Swap"
• Verify no error is shown

status: ready

[status-im-auto]

Jenkins Builds

Click to see older builds (14)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	bc749b5	#1	2024-10-15 22:47:45	~3 min	tests	📄log
❌	bc749b5	#1	2024-10-15 22:50:14	~6 min	ios	📄log
✔️	bc749b5	#1	2024-10-15 22:53:13	~9 min	android-e2e	🤖apk 📲
✔️	bc749b5	#1	2024-10-15 22:54:45	~11 min	android	🤖apk 📲
❌	227360e	#2	2024-10-15 23:09:07	~2 min	ios	📄log
✔️	227360e	#2	2024-10-15 23:11:16	~4 min	tests	📄log
✔️	227360e	#2	2024-10-15 23:13:22	~6 min	android-e2e	🤖apk 📲
✔️	227360e	#2	2024-10-15 23:14:39	~7 min	android	🤖apk 📲
❌	227360e	#3	2024-10-15 23:25:38	~1 min	ios	📄log
✔️	227360e	#4	2024-10-16 03:34:17	~9 min	ios	📱ipa 📲
✔️	7ff75fc	#3	2024-10-16 16:32:15	~4 min	tests	📄log
✔️	7ff75fc	#3	2024-10-16 16:34:48	~7 min	android	🤖apk 📲
✔️	7ff75fc	#3	2024-10-16 16:35:10	~7 min	android-e2e	🤖apk 📲
✔️	7ff75fc	#5	2024-10-16 16:36:27	~8 min	ios	📱ipa 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	369a375	#4	2024-10-18 09:59:57	~4 min	tests	📄log
✔️	369a375	#4	2024-10-18 10:03:08	~7 min	android-e2e	🤖apk 📲
✔️	369a375	#4	2024-10-18 10:03:12	~8 min	android	🤖apk 📲
✔️	369a375	#6	2024-10-18 10:03:55	~8 min	ios	📱ipa 📲
✔️	d0f2db0	#5	2024-10-18 14:56:52	~4 min	tests	📄log
✔️	d0f2db0	#5	2024-10-18 14:58:58	~6 min	android	🤖apk 📲
✔️	d0f2db0	#5	2024-10-18 14:59:54	~7 min	android-e2e	🤖apk 📲
✔️	d0f2db0	#7	2024-10-18 15:01:18	~9 min	ios	📱ipa 📲

[alwx]

why "0" and not 0?

[briansztamfater]

That's because number/to-fixed calls remove-trailing-zeroes fn which returns a string

[alwx]

I wonder if we don't have this constant somewhere already

[alwx]

Approved but added two small comments

[status-im-auto]

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 2
Expected to fail tests: 0
Passed tests: 6

IDs of failed tests: 740490,702843 

Failed tests (2)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843

Test setup failed: critical/chats/test_public_chat_browsing.py:311: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:310: in create_shared_drivers drivers = loop.run_until_complete(start_threads(test_suite_data.current_test.name, /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:26: in start_threads returns[k] = await returns[k] /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(*self.args, **self.kwargs) ../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/appium/webdriver/webdriver.py:257: in __init__ super().__init__( ../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:206: in __init__ self.start_session(capabilities) ../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/appium/webdriver/webdriver.py:346: in start_session response = self.execute(RemoteCommand.NEW_SESSION, w3c_caps) ../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute self.error_handler.check_response(response) ../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:229: in check_response raise exception_class(message, screen, stacktrace) Sauce could not start your job. For more information on what happened, please visit https://app.eu-central-1.saucelabs.com/tests/eb8ebda6a8284de29682e5aede2e0211

Class TestWalletOneDevice:

1. test_wallet_balance_mainnet, id: 740490

Device 1: Find Button by accessibility id: network-dropdown Device 1: Tap on found: Button critical/test_wallet.py:249: in test_wallet_balance_mainnet self.errors.verify_no_errors() base_test_case.py:192: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) For the Ether the wrong value 0.0051 is shown, expected 0.0052 in total E For the Uniswap the wrong value 0.127 is shown, expected 0.627 in total E For the Ether the wrong value 0.0 is shown, expected 0.0001 on Arbitrum E For the Uniswap the wrong value 0.0 is shown, expected 0.5 on Arbitrum

Passed tests (6)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions Device 1: Steps, video, logs

2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

[mohsen-ghafouri]

LGTM

[Horupa-Olena]

@briansztamfater Thank you for your PR.
Regarding the symbols, everything is fine.
As for the long tap bug, I tried different combinations under various conditions but couldn’t reproduce the issue. So, we’ll assume it's fixed.

You can go ahead and merge this PR.