[#20593] fix: show name of saved address in sending flow

[mohsen-ghafouri]

fixes #20593

Summary

The name of the saved address is not shown on the confirmation page.

Areas that maybe impacted

• Sending flow from saved addresses bottom sheet

Steps to test

1. Go to wallet settings -> select 'Saved Addresses' -> select any saved address.
2. Tap 'Send to ' option.
3. Go to the send flow.
4. Check the confirmation page.

Result

Simulator.Screen.Recording.-.iPhone.13.-.2024-10-16.at.17.01.58.mp4

status: ready

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	d5a8ea9	#1	2024-10-16 14:15:15	~4 min	tests	📄log
✔️	d5a8ea9	#1	2024-10-16 14:17:59	~7 min	android-e2e	🤖apk 📲
✔️	d5a8ea9	#1	2024-10-16 14:18:09	~7 min	android	🤖apk 📲
✔️	d5a8ea9	#1	2024-10-16 14:23:43	~12 min	ios	📱ipa 📲
✔️	d5a8ea9	#2	2024-10-16 14:31:02	~7 min	tests	📄log
✔️	94fba2d	#3	2024-10-17 16:38:59	~5 min	tests	📄log
✔️	94fba2d	#2	2024-10-17 16:42:05	~8 min	android-e2e	🤖apk 📲
✔️	94fba2d	#2	2024-10-17 16:42:55	~9 min	android	🤖apk 📲
✔️	94fba2d	#2	2024-10-17 16:45:04	~11 min	ios	📱ipa 📲

[status-im-auto]

50% of end-end tests have passed

Total executed tests: 8
Failed tests: 4
Expected to fail tests: 0
Passed tests: 4

IDs of failed tests: 727230,740490,703133,702843 

Failed tests (4)

Click to expand

Rerun failed tests

Class TestWalletOneDevice:

1. test_wallet_balance_mainnet, id: 740490

Device 1: Find `Button` by `accessibility id`: `network-dropdown` Device 1: Tap on found: Button critical/test_wallet.py:249: in test_wallet_balance_mainnet self.errors.verify_no_errors() base_test_case.py:192: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) For the Ether the wrong value 0.0051 is shown, expected 0.0052 in total E For the Uniswap the wrong value 0.127 is shown, expected 0.627 in total E For the Ether the wrong value 0.0 is shown, expected 0.0001 on Arbitrum E For the Uniswap the wrong value 0.0 is shown, expected 0.5 on Arbitrum

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843

Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')] Device 2: Wait for element Button for max 120s and click when it is available Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices self.community_2.join_community() ../views/chat_view.py:420: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device 1: Find Button by accessibility id: show-profiles Device 1: Tap on found: Button critical/chats/test_public_chat_browsing.py:244: in test_restore_multiaccount_with_waku_backup_remove_switch self.errors.verify_no_errors() base_test_case.py:192: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) zQ3...dWXh5 was not restored as a contact from waku backup! E zQ3...Vacac was not restored as a contact from waku backup! E admin_open was not restored from waku-backup!! E member_open was not restored from waku-backup!! E admin_closed was not restored from waku-backup!! E member_closed was not restored from waku-backup!! Device sessions Device 1: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3] Device 2: Text is 0.09019 ETH critical/test_wallet.py:189: in test_wallet_send_asset_from_drawer self.errors.verify_no_errors() base_test_case.py:192: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Sender balance is not updated on Etherscan, it is 0.3909 but expected to be 0.391

Passed tests (4)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions Device 1: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_eth, id: 727229

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

[Horupa-Olena]

@mohsen-ghafouri Thanks for your PR.

Please, check the foloow issue.

ISSUE 1: The saved address is displayed without the name on the "Recent" tab.

Note: If the saved address is selected from the "Recent" tab, the address name is also not shown on the confirmation page for transaction.
Step:

1. Send some tokens to the saved address.
2. Go to Wallet -> select the account.
3. Click "Send."

Expected results: The saved address on the "Recent" tab should be displayed correctly, showing both the name and the address. https://www.figma.com/design/xLs1KYmF4e6WwRTZVJKeUK/Wallet?node-id=16655-177561&node-type=frame&t=vuKgz2Nz7RgBR01L-0

Actual results: The saved address is displayed without the name on the "Recent" tab.

[mohsen-ghafouri]

Hi @Horupa-Olena, thanks for checking this PR, the issue is not exactly related to what i fixed as it's related to issue about recent tab in send flow. but i will check if it's a small issue to fix or not.

[mohsen-ghafouri]

@Horupa-Olena as far as i'm checking it's not a bug, it just not implemented yet, it shows everything in recent tab with simple address view, it should be handled in separate issue and according to own priority.

[Horupa-Olena]

@mohsen-ghafouri Thanks so much for your help. I will create a separate issue.
I didn’t find any other issues, so you can merge this PR.