Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet-settings)_: Icon color in missing keypair section #21498

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

smohamedjavid
Copy link
Member

Summary

This PR fixes the icon color in the missing keypair section

Design Link

Figma Bug Fix

Testing notes

Manual QA can be skipped as it's just a line change

Platforms

  • Android
  • iOS

Steps to test

Prerequisite: A profile with one or more missing key pair
  • Open Status
  • Navigate to Profile > Wallet > Key pair and accounts
  • Verify the icon is blur variant

status: ready

@smohamedjavid smohamedjavid force-pushed the fix/icon-color-in-missing-keypair branch from 249a7db to 4b7f0c7 Compare October 24, 2024 10:58
@status-im-auto
Copy link
Member

status-im-auto commented Oct 24, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4b7f0c7 #2 2024-10-24 11:03:56 ~5 min tests 📄log
✔️ 4b7f0c7 #2 2024-10-24 11:06:26 ~7 min android 🤖apk 📲
✔️ 4b7f0c7 #2 2024-10-24 11:08:09 ~9 min android-e2e 🤖apk 📲
✔️ 4b7f0c7 #2 2024-10-24 11:10:48 ~11 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 2
Expected to fail tests: 0
Passed tests: 6
IDs of failed tests: 703133,702843 

Failed tests (2)

Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
    Device 2: Wait for element `Button` for max 120s and click when it is available

    Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:420: in join_community
        self.join_button.wait_and_click(120)
    ../views/base_element.py:100: in wait_and_click
        self.wait_for_visibility_of_element(sec)
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    # STEP: Check that removed user is not shown in the list anymore
    Device 1: Wait for element Button for max 30s and click when it is available

    critical/chats/test_public_chat_browsing.py:240: in test_restore_multiaccount_with_waku_backup_remove_switch
        self.sign_in.show_profiles_button.wait_and_click()
    ../views/base_element.py:100: in wait_and_click
        self.wait_for_visibility_of_element(sec)
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: Button by accessibility id:`show-profiles` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Passed tests (6)

    Click to expand

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    @smohamedjavid smohamedjavid merged commit 4aef762 into develop Oct 28, 2024
    5 of 6 checks passed
    @smohamedjavid smohamedjavid deleted the fix/icon-color-in-missing-keypair branch October 28, 2024 10:23
    ilmotta pushed a commit that referenced this pull request Oct 28, 2024
    This commit fixes the icon color in the missing keypair section
    
    Signed-off-by: Mohamed Javid <[email protected]>
    ilmotta pushed a commit that referenced this pull request Oct 28, 2024
    This commit fixes the icon color in the missing keypair section
    
    Signed-off-by: Mohamed Javid <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Status: DONE
    Development

    Successfully merging this pull request may close these issues.

    3 participants