request messages history after background #3493

rasom · 2018-03-01T14:31:28Z

status: ready

rasom · 2018-03-02T08:46:42Z

testcase №1

device A enters background
wait 2 min
send a message from B
wait 2 min
turn on airplane mode on A
send a message from B
close app on B
wait 2 min
open app on A
turn off airplane mode on A

flexsurfer · 2018-03-02T09:26:02Z

src/status_im/utils/datetime.cljs

@@ -111,6 +111,12 @@
 (defn now-ms []
  (to-long (now)))

+(defn now-s! []


what the purpose of ! ?

side effect in this case, though we don't have a convention

Since now-ms doesn't have a bang I wouldn't put one here

oskarth · 2018-03-06T03:19:03Z

@rasom WDYT about resolving conflicts and getting this (tested&)merged, even if it isn't 100% covering all cases yet?

oskarth · 2018-03-06T03:24:43Z

src/status_im/protocol/handlers.cljs

-                  :web3  web3}})))
+   (when web3
+     (let [wnode-id (get db :inbox/wnode)
+           wnode    (get-in db [:inbox/wnodes wnode-id :address])]


I think there's a fn get-wnode or something, Eric used this in other PR

rasom · 2018-03-10T15:18:31Z

conflicts resolved, let's test it

statustestbot · 2018-03-10T16:05:22Z

53% of end-end tests have passed

Total executed tests: 15
Failed tests: 7
Passed tests: 8

Failed tests (7)

Click to expand

1. test_send_transaction_from_daap
Tap on ToggleNavigationButton Looking for NewAuctionButton `E selenium.common.exceptions.NoSuchElementException: Message: 'NewAuctionButton' is not found on screen, using: 'accessibility id:New Auction'` Device sessions: Device 1
2. test_send_eth_from_wallet_sign_now
Looking for OkButton `E selenium.common.exceptions.WebDriverException: Message: The test with session id 7ba791baa3a249209c440bea8690904f has already finished, and can't receive further commands. You can learn more at https://saucelabs.com/jobs/7ba791baa3a249209c440bea8690904f For help, please check https://wiki.saucelabs.com/display/DOCS/Common+Error+Messages`
3. test_one_to_one_chat_messages_and_delete_chat
Wait for PlusButton Looking for an element by text part: 'Test Name' `E Failed: Message with text "abc !@#$%%^&(() bold" was not received` Device sessions: Device 1 Device 2
4. test_network_switch
Tap on ProfileButton Looking for full text: 'RINKEBY WITH UPSTREAM RPC' `E selenium.common.exceptions.TimeoutException: Message: 'BaseElement' is not found on screen, using: 'xpath://*[@text="RINKEBY WITH UPSTREAM RPC"]', during '20' seconds` Device sessions: Device 1
5. test_group_chat_messages
Scrolling down to UsernameCheckbox Looking for UsernameCheckbox `E selenium.common.exceptions.NoSuchElementException: Message: 'UsernameCheckbox' is not found on screen, using: 'xpath://[@text='Test Name']/../../android.view.ViewGroup[2]/'` Device sessions: Device 1 Device 2 Device 3
6. test_transaction_send_command_one_to_one_chat
Waiting 290 seconds for donation Waiting 300 seconds for donation `E Failed: Donation was not received during 300 seconds!` Device sessions: Device 1
7. test_send_eth_to_request_in_one_to_one_chat
Looking for an element by text part: 'Evergreen Handsome Cotton' Looking for an element by text part: 'Brief Organic Xenops' `E selenium.common.exceptions.NoSuchElementException: Message: 'BaseButton' is not found on screen, using: 'xpath://*[contains(@text, "Brief Organic Xenops")]'` Device sessions: Device 1 Device 2

Passed tests (8)

Click to expand

1. test_send_eth_to_request_from_wallet
Device sessions: Device 1 Device 2
2. test_public_chat
Device sessions: Device 1 Device 2
3. test_browse_link_entering_url_in_dapp_view
Device sessions: Device 1
4. test_transaction_send_command_wrong_password
Device sessions: Device 1
5. test_send_stt_from_wallet_via_enter_recipient_address
Device sessions: Device 1
6. test_send_eth_to_request_in_group_chat
Device sessions: Device 1 Device 2
7. test_transaction_send_command_group_chat
Device sessions: Device 1
8. test_send_eth_from_wallet_sign_later
Device sessions: Device 1

yenda · 2018-03-12T20:58:26Z

src/status_im/ui/screens/events.cljs

@@ -71,6 +72,11 @@
 (fn [coeffects _]
   (assoc coeffects :now (time/now-ms))))

+(re-frame/reg-cofx


since we already have now and it is a coeffect added to all event, I think it is better to just have an to-s function that turns now into now-s rather than a second coeffect that also produces a timestamp

yeah thought also about this

lukaszfryc · 2018-03-13T11:50:31Z

I tested it on Android 7 (Samsung Galaxy S8) and iOS 11.2.1 (iPhone 6). Here is what I found.

No new 1-1 message after going back online from long offline session (~4 min). Happens on Android and iOS
a. Transit app to background on device A
b. Turn on airplane mode on device A
c. Send message from device B to device A
d. Close app on device B
e. Wait 3-5 minutes
f. Turn off airplane mode on device A
g. Wait for message notification and open the chat
Now, device A receives notification but the chat does not have the new message. The message is received when app on device B is opened and user is logged again.
Everyting works fine when device A is offline only for very short period of time.
Group chat message is not received after going back online from long offline session (~4 min). Tested only on Android
Like in 1) a new group chat message is not received when device was offline for a long period of time. The difference is that the message is not received even when the second device opens the app (and group chat) or sends another message. Looks like the message is basically lost.
Here is the scenario:
a. Create group chat for devices A and B
b. Send some messages between devices in the group chat
c. Turn on airplane mode on device A
d. Send group chat message on device B
e. Wait for 3-5 min
f. Turn off airplane mode on device A
Device A will not receive the message that was sent before going offline.
@rasom could this be an issue on our side or it's just the way the protocol works at this moment?

statustestbot · 2018-03-13T12:25:13Z

56% of end-end tests have passed

Total executed tests: 16
Failed tests: 7
Passed tests: 9

Failed tests (7)

Click to expand

1. test_send_eth_from_wallet_sign_now
Tap on SignTransactionButton Looking for EnterPasswordInput `E selenium.common.exceptions.NoSuchElementException: Message: 'EnterPasswordInput' is not found on screen, using: 'xpath://android.widget.EditText[@NAF='true']'` Device sessions: Device 1
2. test_one_to_one_chat_messages_and_delete_chat
Wait for PlusButton Looking for an element by text part: 'Test Name' `E Failed: Message with text "abc !@#$%%^&(() bold" was not received` Device sessions: Device 1 Device 2
3. test_network_switch
Tap on ProfileButton Looking for full text: 'RINKEBY WITH UPSTREAM RPC' `E selenium.common.exceptions.TimeoutException: Message: 'BaseElement' is not found on screen, using: 'xpath://*[@text="RINKEBY WITH UPSTREAM RPC"]', during '20' seconds` Device sessions: Device 1
4. test_group_chat_messages
`E selenium.common.exceptions.WebDriverException: Message: The Sauce VMs failed to start the browser or device. For more info, please check https://wiki.saucelabs.com/display/DOCS/Common+Error+Messages`
5. test_transaction_send_command_one_to_one_chat
Waiting 290 seconds for donation Waiting 300 seconds for donation `E Failed: Donation was not received during 300 seconds!` Device sessions: Device 1
6. test_send_eth_to_request_in_group_chat
Tap on ContinueButtonAPK Looking for OkButton `E selenium.common.exceptions.WebDriverException: Message: The test with session id 1742a1d69db542e7ab0cdfe578f32769 has already finished, and can't receive further commands. You can learn more at https://saucelabs.com/jobs/1742a1d69db542e7ab0cdfe578f32769 For help, please check https://wiki.saucelabs.com/display/DOCS/Common+Error+Messages` Device sessions: Device 1 Device 2
7. test_transaction_send_command_group_chat
Waiting 290 seconds for donation Waiting 300 seconds for donation `E Failed: Donation was not received during 300 seconds!` Device sessions: Device 1

Passed tests (9)

Click to expand

1. test_send_transaction_from_daap
Device sessions: Device 1
2. test_send_eth_to_request_from_wallet
Device sessions: Device 1 Device 2
3. test_contact_profile_view
Device sessions: Device 1
4. test_public_chat
Device sessions: Device 1 Device 2
5. test_browse_link_entering_url_in_dapp_view
Device sessions: Device 1
6. test_transaction_send_command_wrong_password
Device sessions: Device 1
7. test_send_eth_to_request_in_one_to_one_chat
Device sessions: Device 1 Device 2
8. test_send_stt_from_wallet_via_enter_recipient_address
Device sessions: Device 1
9. test_send_eth_from_wallet_sign_later
Device sessions: Device 1

request history when network connection is reestablished

rasom force-pushed the bugfix/request-history-on-network-or-app-state-changes branch from 46a3049 to 40466d8 Compare March 1, 2018 16:01

rasom self-assigned this Mar 1, 2018

rasom force-pushed the bugfix/request-history-on-network-or-app-state-changes branch from b887034 to 2b4615d Compare March 2, 2018 07:27

flexsurfer approved these changes Mar 2, 2018

View reviewed changes

flexsurfer requested review from yenda and janherich March 2, 2018 09:42

oskarth mentioned this pull request Mar 6, 2018

Push notification is shown but no message received #3467

Closed

oskarth approved these changes Mar 6, 2018

View reviewed changes

rasom force-pushed the bugfix/request-history-on-network-or-app-state-changes branch from a542f6a to d934a44 Compare March 10, 2018 15:18

yenda reviewed Mar 12, 2018

View reviewed changes

lukaszfryc self-assigned this Mar 13, 2018

lukaszfryc added the Tested - Issues label Mar 13, 2018

rasom mentioned this pull request Mar 22, 2018

Confidence in Messaging status-im/swarms#99

Closed

rasom force-pushed the bugfix/request-history-on-network-or-app-state-changes branch from d934a44 to 46fe7e6 Compare March 23, 2018 19:47

request messages history after background

239a21e

request history when network connection is reestablished

rasom force-pushed the bugfix/request-history-on-network-or-app-state-changes branch from 46fe7e6 to 239a21e Compare April 4, 2018 15:25

fix :status-go-app-state-change effect

c2ddd4b

rasom closed this Apr 7, 2018

rasom deleted the bugfix/request-history-on-network-or-app-state-changes branch May 19, 2018 06:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

request messages history after background #3493

request messages history after background #3493

rasom commented Mar 1, 2018 •

edited

Loading

rasom commented Mar 2, 2018 •

edited

Loading

flexsurfer Mar 2, 2018

rasom Mar 2, 2018

yenda Mar 3, 2018

rasom Mar 10, 2018

oskarth commented Mar 6, 2018

oskarth Mar 6, 2018

rasom commented Mar 10, 2018

statustestbot commented Mar 10, 2018

yenda Mar 12, 2018

flexsurfer Mar 13, 2018

lukaszfryc commented Mar 13, 2018

statustestbot commented Mar 13, 2018

request messages history after background #3493

request messages history after background #3493

Conversation

rasom commented Mar 1, 2018 • edited Loading

rasom commented Mar 2, 2018 • edited Loading

flexsurfer Mar 2, 2018

Choose a reason for hiding this comment

rasom Mar 2, 2018

Choose a reason for hiding this comment

yenda Mar 3, 2018

Choose a reason for hiding this comment

rasom Mar 10, 2018

Choose a reason for hiding this comment

oskarth commented Mar 6, 2018

oskarth Mar 6, 2018

Choose a reason for hiding this comment

rasom commented Mar 10, 2018

statustestbot commented Mar 10, 2018

53% of end-end tests have passed

Failed tests (7)

Passed tests (8)

yenda Mar 12, 2018

Choose a reason for hiding this comment

flexsurfer Mar 13, 2018

Choose a reason for hiding this comment

lukaszfryc commented Mar 13, 2018

statustestbot commented Mar 13, 2018

56% of end-end tests have passed

Failed tests (7)

Passed tests (9)

rasom commented Mar 1, 2018 •

edited

Loading

rasom commented Mar 2, 2018 •

edited

Loading