bug #4917 and #4914 - not showing message in chat after wallet send

[goranjovic]

fixes #4917
fixes #4914

Summary:

A recent regression caused chat messages to be sent after Wallet Send. Those messages are currently supposed to only be generated after /send command, not directly from Wallet. Since this is not yet supported, what happened instead was that an old payment message would appear in the last chat the user interacted with.

This PR reintroduces the condition that app should only send payment messages if the transaction was initiated from chat.

Steps to test:

see #4917 and #4914

status: ready

[status-comment-bot]

branch PR-4918:
apk uploaded to https://i.diawi.com/nvPWiy
ipa uploaded to https://i.diawi.com/HBMrBk

Install - Diawi - Development and In-house Apps Wireless Installation

Install - Diawi - Development and In-house Apps Wireless Installation

[statustestbot]

97% of end-end tests have passed

Total executed tests: 33
Failed tests: 1
Passed tests: 32

Failed tests (1)

Click to expand

1. test_network_mismatch_for_send_request_commands

Tap on GotItButton Looking for full text: '0.0623103158' E selenium.common.exceptions.TimeoutException: Message: 'ProgressBar' is still present on screen, using: 'xpath://*[starts-with(@text,'0.0623103158')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//android.widget.ProgressBar', during '10' seconds Device sessions: Device 1 Device 2

Passed tests (32)

Click to expand

1. test_sign_transaction_twice

Device sessions: Device 1

2. test_swipe_and_delete_1_1_chat

Device sessions: Device 1

3. test_one_to_one_chat_messages

Device sessions: Device 1 Device 2

4. test_copy_and_paste_messages

Device sessions: Device 1

5. test_send_transaction_from_daap

Device sessions: Device 1

6. test_faucet_console_command

Device sessions: Device 1

7. test_username_and_profile_picture_in_chats

Device sessions: Device 1 Device 2

8. test_send_eth_from_wallet_sign_now

Device sessions: Device 1

9. test_offline_login

Device sessions: Device 1

10. test_open_transaction_on_etherscan

Device sessions: Device 1

11. test_send_eth_to_request_from_wallet

Device sessions: Device 1 Device 2

12. test_incorrect_password

Device sessions: Device 1

13. test_backup_seed_phrase_and_recover_account

Device sessions: Device 1

14. test_offline_messaging_1_1_chat

Device sessions: Device 1 Device 2

15. test_contact_profile_view

Device sessions: Device 1

16. test_public_chat

Device sessions: Device 1 Device 2

17. test_public_chat_management

Device sessions: Device 1 Device 2

18. test_network_switch

Device sessions: Device 1

19. test_delete_1_1_chat

Device sessions: Device 1

20. test_messaging_in_different_networks

Device sessions: Device 1 Device 2

21. test_wallet_error_messages

Device sessions: Device 1

22. test_transaction_send_command_one_to_one_chat

Device sessions: Device 1

23. test_browse_link_entering_url_in_dapp_view

Device sessions: Device 1

24. test_transaction_send_command_wrong_password

Device sessions: Device 1

25. test_resend_message_offline

Device sessions: Device 1 Device 2

26. test_send_eth_to_request_in_one_to_one_chat

Device sessions: Device 1 Device 2

27. test_profile_picture

Device sessions: Device 1

28. test_switch_users

Device sessions: Device 1

29. test_set_up_wallet

Device sessions: Device 1

30. test_send_stt_from_wallet_via_enter_recipient_address

Device sessions: Device 1

31. test_qr_code_and_its_value

Device sessions: Device 1

32. test_sign_message_from_daap

Device sessions: Device 1

[jeluard]

How about some comment to clarify the flow?