No browsing history kept on iOS [#5078] #5090

flexsurfer · 2018-07-06T19:49:25Z

status-comment-bot · 2018-07-06T20:11:26Z

branch PR-5090:
apk uploaded to https://i.diawi.com/Z7hmfu
ipa uploaded to https://i.diawi.com/BK6D5x

Install - Diawi - Development and In-house Apps Wireless Installation

jeluard · 2018-07-07T06:12:57Z

src/status_im/ui/screens/browser/events.cljs

+          history       (:history browser)
+          history-url   (try (nth history history-index) (catch js/Error _))
+          new-history   (if (not= history-url url)
+                          (conj (subvec history 0 (inc history-index))


Worth a separate fn with proper name?

too many params and too small function don't worth it from my pov

Small fns are never an issue :) Mostly useful to understand what this thing is doing. Or maybe a small comment?

jeluard · 2018-07-07T06:13:39Z

src/status_im/ui/screens/browser/events.cljs

+   (let [browser {:browser-id    (random/id)
+                  :name          (i18n/label :t/browser)
+                  :history-index 0
+                  :history       [(http/normalize-and-decode-url url)]}]


Some parts in common with code above. Introduce a fn?

do you mean for creating new browser map?

jeluard · 2018-07-07T06:14:27Z

src/status_im/ui/screens/browser/views.cljs

@@ -64,6 +63,13 @@
   [react/view styles/web-view-loading
    [components/activity-indicator {:animating true}]]))

+(defn on-bridge-message [message browser]
+  (let [{:strs [type navState]} (js->clj (.parse js/JSON message))
+        {:strs [url title]} navState]


title not used?

jeluard · 2018-07-07T06:14:46Z

src/status_im/ui/screens/browser/views.cljs

+           :render-error                          web-view-error
+           :render-loading                        web-view-loading
+           :on-bridge-message                     #(on-bridge-message % browser)
+           ;:on-navigation-state-change            #(on-navigation-change % browser)


jeluard · 2018-07-07T06:15:24Z

test/cljs/status_im/test/models/browser_history.cljs

@@ -1,117 +0,0 @@
-(ns status-im.test.models.browser-history


No more tests?

yeah no model, and now it's super simple code, nothing to test

@flexsurfer there's much to test browser-back browser-forward update-browser-history-tx, if we don't start adding tests to the codebase (instead of removing them :) ) it makes it harder for everyone to modify and improve it

cammellos · 2018-07-07T06:38:56Z

test/cljs/status_im/test/models/browser_history.cljs

@@ -1,117 +0,0 @@
-(ns status-im.test.models.browser-history


@flexsurfer there's much to test browser-back browser-forward update-browser-history-tx, if we don't start adding tests to the codebase (instead of removing them :) ) it makes it harder for everyone to modify and improve it

rasom · 2018-07-09T04:34:22Z

src/status_im/ui/screens/browser/events.cljs

+ [re-frame/trim-v]
+ (fn [cofx [browser]]
+   (let [back-index (:history-index browser)]
+     (when (not (zero? back-index))


(when (pos??

rasom · 2018-07-09T04:37:04Z

src/status_im/ui/screens/browser/events.cljs

+ :browser-nav-forward
+ [re-frame/trim-v]
+ (fn [cofx [browser]]
+   (let [forward-index (:history-index browser)]


we could destruct browser at params declaration, not a big deal though

rasom · 2018-07-09T04:37:25Z

src/status_im/ui/screens/browser/views.cljs

+  (let [{:strs [type navState]} (js->clj (.parse js/JSON message))
+        {:strs [url title]} navState]
+    (when (= type "navStateChange")
+      (when (not= "about:blank" url)


might be and instead of the second when

there will be more types, will be condition

rasom · 2018-07-09T04:38:28Z

src/status_im/ui/screens/browser/views.cljs

-     (when-not dapp?
-       [tooltip/bottom-tooltip-info
-        (i18n/label :t/browser-warning)])]))
+    (let [can-go-back?    (not (zero? history-index))


again, can we use pos? here? or index can be negative?

rasom · 2018-07-09T04:39:44Z

src/status_im/ui/screens/browser/views.cljs

+        [react/touchable-highlight {:on-press            #(re-frame/dispatch [:browser-nav-forward browser])
+                                    :disabled            (not can-go-forward?)
+                                    :style               (merge styles/forward-button
+                                                                (when (not can-go-forward?) styles/disabled-button))


flexsurfer · 2018-07-09T11:27:36Z

@jeluard @cammellos done!

cammellos

@flexsurfer thanks!

status-comment-bot · 2018-07-09T12:07:37Z

branch PR-5090:
apk uploaded to https://i.diawi.com/GfGv6h
ipa uploaded to https://i.diawi.com/H9AmFh

Install - Diawi - Development and In-house Apps Wireless Installation

status-comment-bot · 2018-07-09T13:51:09Z

branch PR-5090:
apk uploaded to https://i.diawi.com/qyRJgF
ipa uploaded to https://i.diawi.com/CNoPMe

Install - Diawi - Development and In-house Apps Wireless Installation

statustestbot · 2018-07-09T16:17:08Z

81% of end-end tests have passed

Total executed tests: 64
Failed tests: 12
Passed tests: 52

Failed tests (12)

Click to expand

1. test_request_and_receive_tokens_in_1_1_chat
`E selenium.common.exceptions.WebDriverException: Message: Sauce could not start your job. For more information on what happened, please visit https://saucelabs.com/jobs/8c279e6e72cd424c85073985813421b3`
2. test_open_invalid_link
Type 'user_79153829' to NameInput Looking for NextButton `E selenium.common.exceptions.NoSuchElementException: Message: 'NextButton' is not found on screen, using: 'xpath://android.widget.TextView[@text='NEXT']'` Device sessions: Device 1
3. test_back_forward_buttons_browsing_website
Tap on BrowserPreviousPageButton Looking for a text part: 'English' `E selenium.common.exceptions.TimeoutException: Message: 'BaseElement' is not found on screen, using: 'xpath://*[contains(@text, "English")]', during '15' seconds` Device sessions: Device 1
4. test_text_message_1_1_chat
`E selenium.common.exceptions.WebDriverException: Message: Sauce could not start your job. For more information on what happened, please visit https://saucelabs.com/jobs/1aa5e67818524d0fbba3798dacd2a911`
5. test_add_to_contacts
Tap on ViewProfileButton Looking for ProfilePictureElement `E Failed: user_1 is not added to contacts. Real username 'user_2' is not shown in one-to-one chat. Updated profile picture is not shown in one-to-one chat` Device sessions: Device 1 Device 2
6. test_send_and_open_links
Type 'user_2' to NameInput Looking for NextButton `E selenium.common.exceptions.NoSuchElementException: Message: 'NextButton' is not found on screen, using: 'xpath://android.widget.TextView[@text='NEXT']'` Device sessions: Device 1 Device 2
7. test_messaging_in_different_networks
Looking for ConnectionStatusText ConnectionStatusText is Fetching messages... `E AttributeError: 'NoneType' object has no attribute 'click'` Device sessions: Device 1 Device 2
8. test_resend_message_offline
Looking for a message by text: 'test message' Looking for StatusText `E selenium.common.exceptions.NoSuchElementException: Message: 'StatusText' is not found on screen, using: 'xpath://*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/android.widget.TextView'` Device sessions: Device 1 Device 2
9. test_send_eth_in_1_1_chat
Waiting 60 seconds for ETH update Looking for EthAssetText `E AttributeError: 'NoneType' object has no attribute 'text'` Device sessions: Device 1 Device 2
10. test_public_chat_clear_history
`E selenium.common.exceptions.WebDriverException: Message: Sauce could not start your job. For more information on what happened, please visit https://saucelabs.com/jobs/a285e37ae8fc4414b539b36be7625326`
11. test_request_eth_in_wallet
`E selenium.common.exceptions.WebDriverException: Message: Sauce could not start your job. For more information on what happened, please visit https://saucelabs.com/jobs/d95ce9015329444a9d1a271a0ab7af13`
12. test_contact_profile_send_transaction
`E selenium.common.exceptions.WebDriverException: Message: Sauce could not start your job. For more information on what happened, please visit https://saucelabs.com/jobs/2dad6060a5ad446eb34330068385edfa`

Passed tests (52)

Click to expand

1. test_create_account
Device sessions: Device 1
2. test_copy_and_paste_messages
Device sessions: Device 1
3. test_send_transaction_from_daap
Device sessions: Device 1
4. test_faucet_console_command
Device sessions: Device 1
5. test_delete_cut_and_paste_messages
Device sessions: Device 1
6. test_send_eth_from_wallet_incorrect_address
Device sessions: Device 1
7. test_offline_login
Device sessions: Device 1
8. test_delete_one_to_one_chat_via_delete_button
Device sessions: Device 1
9. test_create_account_short_and_mismatch_password
Device sessions: Device 1
10. test_open_transaction_on_etherscan
Device sessions: Device 1
11. test_public_chat_messaging
Device sessions: Device 1 Device 2
12. test_copy_transaction_hash
Device sessions: Device 1
13. test_invite_friends
Device sessions: Device 1
14. test_set_profile_picture
Device sessions: Device 1
15. test_home_view
Device sessions: Device 1
16. test_copy_contact_code_and_wallet_address
Device sessions: Device 1
17. test_transaction_appears_in_history
Device sessions: Device 1
18. test_set_currency
Device sessions: Device 1
19. test_add_custom_network
Device sessions: Device 1
20. test_offline_messaging_1_1_chat
Device sessions: Device 1 Device 2
21. test_send_eth_from_wallet_to_address
Device sessions: Device 1
22. test_manage_assets
Device sessions: Device 1
23. test_wallet_set_up
Device sessions: Device 1
24. test_request_and_receive_eth_in_1_1_chat
Device sessions: Device 1 Device 2
25. test_swipe_to_delete_public_chat
Device sessions: Device 1
26. test_send_emoji
Device sessions: Device 1
27. test_add_contact_by_pasting_public_key
Device sessions: Device 1
28. test_transaction_wrong_password_wallet
Device sessions: Device 1
29. test_web3_block_number
Device sessions: Device 1
30. test_connection_is_not_secure
Device sessions: Device 1
31. test_delete_public_chat_via_delete_button
Device sessions: Device 1
32. test_send_tokens_in_1_1_chat
Device sessions: Device 1 Device 2
33. test_network_mismatch_for_send_request_commands
Device sessions: Device 1 Device 2
34. test_swipe_to_delete_1_1_chat
Device sessions: Device 1
35. test_switch_users_and_add_new_account
Device sessions: Device 1
36. test_send_stt_from_wallet
Device sessions: Device 1
37. test_login_with_new_account
Device sessions: Device 1
38. test_send_eth_from_wallet_to_contact
Device sessions: Device 1
39. test_login_with_incorrect_password
Device sessions: Device 1
40. test_add_contact_from_public_chat
Device sessions: Device 1
41. test_send_request_not_enabled_tokens
Device sessions: Device 1
42. test_send_message_to_newly_added_contact
Device sessions: Device 1 Device 2
43. test_browse_page_with_non_english_text
Device sessions: Device 1
44. test_change_profile_picture_several_times
Device sessions: Device 1
45. test_clear_history_one_to_one_chat
Device sessions: Device 1
46. test_offline_status
Device sessions: Device 1
47. test_backup_seed_phrase
Device sessions: Device 1
48. test_open_google_com_via_open_dapp
Device sessions: Device 1
49. test_sign_message_from_daap
Device sessions: Device 1
50. test_share_contact_code_and_wallet_address
Device sessions: Device 1
51. test_swipe_to_delete_browser_entry
Device sessions: Device 1
52. test_recover_account
Device sessions: Device 1

Serhy · 2018-07-09T17:15:01Z

Builds apk https://i.diawi.com/qyRJgF and ipa https://i.diawi.com/CNoPMe has been tested on iOS (11.2.5) and Andorid (6.0, 7.0)
Those Dapps which failed to track history before (outlines in the respective issue) are working now, yes (with one issue though - see the (II) item below). But major regressions introduced at the same time:

@flexsurfer, few issues we faced here:

I) Those Dapps which kept the browsing history fine on iOS before (e.g. Etheremons, CryptoPunks) AND webpages (like google.com / wikipedia.org) - does not keep browsing history not only on iOS but on Android as well now.
To reproduce:

Navigate to google.com -> search something -> navigat to any of the links avaialble on page and check if Back button active
Navigate to CryptoPunks -> Writing -> check whether browser `Back' button is active

II) No browsing history cut off when user navigates to any link from the middle of his browsing history. It becomes a bit confusing for where browser navigates then. See the scenario:

Open status and create an account
Navigate to Open Dapps ->CryptoKitties->Open`
From CryptoKitties home screen navigate to Marketplace (you appear on Page How to handle multiple numbers on phone account? #1)
Scroll down and navigate to Page 2 -> then Page 3 -> then Page 4 - then Page 5 (Note: so at this point 6 records in the browsing history)
Tap browser Back button
6)Tap browser Back button again (you appear on 3rd page)
Tap on any Kitty label to navigate to its details screen
Actual result: Fwd browser button is available.
Expected result: Fwd browser button is disabled. Browsing history with all links used after 3rd CryptoKitties page in the current example is flushed.
Tap -> Fwd browser button now
Actual result: 4th page appears
Tap <- Back browser button
Actual result: 3rd page appears

III) On the Home page screen any Dapp/web page has instead of the actual last visited URL the 'Dapp' labels

TF session showing all three issues above: https://app.testfairy.com/projects/4803622-status/builds/8518521/sessions/4395906530/?accessToken=vP/BJVyUO/qs6g8pUdSj7vkIwc4

flexsurfer · 2018-07-10T12:06:29Z

thanks @Serhy , fixed

status-comment-bot · 2018-07-11T08:35:11Z

branch PR-5090:
apk uploaded to https://i.diawi.com/ETn3YX
ipa uploaded to https://i.diawi.com/j6hSws

Install - Diawi - Development and In-house Apps Wireless Installation

statustestbot · 2018-07-11T12:09:45Z

88% of end-end tests have passed

Total executed tests: 72
Failed tests: 9
Passed tests: 63

Failed tests (9)

Click to expand

1. test_open_transaction_on_etherscan
Tap on IHaveAccountButton Looking for PassphraseInput `E selenium.common.exceptions.NoSuchElementException: Message: 'PassphraseInput' is not found on screen, using: 'xpath://android.widget.TextView[@text='Passphrase']'` Device sessions: Device 1
2. test_add_to_contacts
Tap on ViewProfileButton Looking for ProfilePictureElement `E Failed: user_1 is not added to contacts. Real username 'user_2' is not shown in one-to-one chat. Updated profile picture is not shown in one-to-one chat` Device sessions: Device 1 Device 2
3. test_logcat_backup_seed_phrase
Looking for OkGotItButton Tap on OkGotItButton `Passphrase in logcat!!!` Device sessions: Device 1
4. test_logcat_send_transaction_from_daap
Looking for GotItButton Tap on GotItButton `Password in logcat!!!` Device sessions: Device 1
5. test_offline_messaging_1_1_chat
Looking for ConnectionStatusText ConnectionStatusText is Connecting to peers... `E selenium.common.exceptions.TimeoutException: Message: 'ChatElement' is not found on screen, using: 'xpath://[@content-desc='chat-item'][.//[starts-with(@text,'user_2')]]', during '20' seconds` Device sessions: Device 1 Device 2
6. test_logcat_send_transaction_in_1_1_chat
Looking for StatusText StatusText is Sent `Password in logcat!!!` Device sessions: Device 1
7. test_messaging_in_different_networks
Wait for ConnectionStatusText Wait for ConnectionStatusText `E AttributeError: 'NoneType' object has no attribute 'click'` Device sessions: Device 1 Device 2
8. test_logcat_sign_message_from_daap
Looking for SignTransactionButton Tap on SignTransactionButton `Password in logcat!!!` Device sessions: Device 1
9. test_resend_message_offline
Looking for a message by text: 'test message' Looking for StatusText `E selenium.common.exceptions.NoSuchElementException: Message: 'StatusText' is not found on screen, using: 'xpath://*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/android.widget.TextView'` Device sessions: Device 1 Device 2

Passed tests (63)

Click to expand

1. test_create_account
Device sessions: Device 1
2. test_copy_and_paste_messages
Device sessions: Device 1
3. test_send_transaction_from_daap
Device sessions: Device 1
4. test_faucet_console_command
Device sessions: Device 1
5. test_request_and_receive_tokens_in_1_1_chat
Device sessions: Device 1 Device 2
6. test_delete_cut_and_paste_messages
Device sessions: Device 1
7. test_send_eth_from_wallet_incorrect_address
Device sessions: Device 1
8. test_open_invalid_link
Device sessions: Device 1
9. test_offline_login
Device sessions: Device 1
10. test_delete_one_to_one_chat_via_delete_button
Device sessions: Device 1
11. test_create_account_short_and_mismatch_password
Device sessions: Device 1
12. test_public_chat_messaging
Device sessions: Device 1 Device 2
13. test_copy_transaction_hash
Device sessions: Device 1
14. test_back_forward_buttons_browsing_website
Device sessions: Device 1
15. test_password_in_logcat_sign_in
Device sessions: Device 1
16. test_invite_friends
Device sessions: Device 1
17. test_set_profile_picture
Device sessions: Device 1
18. test_text_message_1_1_chat
Device sessions: Device 1 Device 2
19. test_home_view
Device sessions: Device 1
20. test_send_and_open_links
Device sessions: Device 1 Device 2
21. test_copy_contact_code_and_wallet_address
Device sessions: Device 1
22. test_transaction_appears_in_history
Device sessions: Device 1
23. test_logcat_send_transaction_from_wallet
Device sessions: Device 1
24. test_set_currency
Device sessions: Device 1
25. test_add_custom_network
Device sessions: Device 1
26. test_send_eth_from_wallet_to_address
Device sessions: Device 1
27. test_manage_assets
Device sessions: Device 1
28. test_wallet_set_up
Device sessions: Device 1
29. test_request_and_receive_eth_in_1_1_chat
Device sessions: Device 1 Device 2
30. test_swipe_to_delete_public_chat
Device sessions: Device 1
31. test_send_emoji
Device sessions: Device 1
32. test_add_contact_by_pasting_public_key
Device sessions: Device 1
33. test_logcat_recovering_account
Device sessions: Device 1
34. test_transaction_wrong_password_wallet
Device sessions: Device 1
35. test_web3_block_number
Device sessions: Device 1
36. test_connection_is_not_secure
Device sessions: Device 1
37. test_delete_public_chat_via_delete_button
Device sessions: Device 1
38. test_send_tokens_in_1_1_chat
Device sessions: Device 1 Device 2
39. test_network_mismatch_for_send_request_commands
Device sessions: Device 1 Device 2
40. test_swipe_to_delete_1_1_chat
Device sessions: Device 1
41. test_switch_users_and_add_new_account
Device sessions: Device 1
42. test_send_stt_from_wallet
Device sessions: Device 1
43. test_send_eth_in_1_1_chat
Device sessions: Device 1 Device 2
44. test_login_with_new_account
Device sessions: Device 1
45. test_send_eth_from_wallet_to_contact
Device sessions: Device 1
46. test_login_with_incorrect_password
Device sessions: Device 1
47. test_add_contact_from_public_chat
Device sessions: Device 1
48. test_send_request_not_enabled_tokens
Device sessions: Device 1
49. test_send_message_to_newly_added_contact
Device sessions: Device 1 Device 2
50. test_browse_page_with_non_english_text
Device sessions: Device 1
51. test_password_in_logcat_creating_account
Device sessions: Device 1
52. test_change_profile_picture_several_times
Device sessions: Device 1
53. test_clear_history_one_to_one_chat
Device sessions: Device 1
54. test_public_chat_clear_history
Device sessions: Device 1 Device 2
55. test_offline_status
Device sessions: Device 1
56. test_backup_seed_phrase
Device sessions: Device 1
57. test_open_google_com_via_open_dapp
Device sessions: Device 1
58. test_sign_message_from_daap
Device sessions: Device 1
59. test_share_contact_code_and_wallet_address
Device sessions: Device 1
60. test_request_eth_in_wallet
Device sessions: Device 1 Device 2
61. test_contact_profile_send_transaction
Device sessions: Device 1
62. test_swipe_to_delete_browser_entry
Device sessions: Device 1
63. test_recover_account
Device sessions: Device 1

Serhy · 2018-07-11T14:18:43Z

@flexsurfer latest changes look really good! We keep the history now on iOS and Android app browsers for Dapps/websites and I was able to navigate through history with Back/Fwd browser buttons!

However, there are issues we need to look at:

Upgrading on the version with current changes flushes the history of previously used Dapp/Browser items. But the Dapp/Browser elements are kept on Home screen. Navigating to Dapp with such empty history leads to error followed by app crash:
Steps to reproduce:

Install the 0.9.22 release app and create new account
Navigate to Open Dapp -> CryptoKitties -> Open
Upgrade to the app version (Android build https://i.diawi.com/ETn3YX / iOS build https://i.diawi.com/j6hSws)
Log in to the same account. (Note: CryptoKitties Dapp item is on Home screen)
Tap on CryptoKitties from Home screen
Actual result: TypeError: re-find must match against a string error appears.

TF session from 01:00 https://app.testfairy.com/projects/4803622-status/builds/8521278/sessions/4396102337/?accessToken=ayUtWG7xTPNwdt5g8TCNi1zkS8g

On Android app browser, there is a weird behavior with 'OpenSea' dapp: it keep return user back to particular crypto asset detail screen if it has been navigated to at least once. Please, see steps to reproduce:

Open Status on Android and create new account
Navigate to Open Dapps -> OpenSea -> Open
Tap 'Explore the sea' button (You'll land on summary screen of erc721 items)
Tap on the first item you see
Tap Back app browser button and wait up to 10-15 seconds
TF session https://app.testfairy.com/projects/4803622-status/builds/8521278/sessions/4396102794/?accessToken=bHaMZqWOJmVZrPNBoxuGu2NMnKs

Note: iOS app browser it looks good here. On latest nightly I could not reproduce the same issue with the steps above (no auto-return back when I don't touch anything), but browser history for OpenSea looks a bit weird on nightly develop build as well - just need to navigate between summary/detail screens of this Dapp a bit more. (I'm OK if consider to fix it separately off this PR changes)

Install - Diawi - Development and In-house Apps Wireless Installation

TestFairy: Status 0.9.23 (6192) @2018

status-comment-bot · 2018-07-11T15:14:36Z

branch PR-5090:
apk uploaded to https://i.diawi.com/2CCvuG
ipa uploaded to https://i.diawi.com/2iozMv

Install - Diawi - Development and In-house Apps Wireless Installation

flexsurfer · 2018-07-11T16:04:08Z

@Serhy fixed

status-comment-bot · 2018-07-11T16:46:05Z

branch PR-5090:
apk uploaded to https://i.diawi.com/zvZY23
ipa uploaded to https://i.diawi.com/sETtcP

Install - Diawi - Development and In-house Apps Wireless Installation

status-comment-bot · 2018-07-12T10:30:57Z

branch PR-5090:
apk uploaded to https://i.diawi.com/uW3rDy
ipa uploaded to https://i.diawi.com/Y6pDWB

Install - Diawi - Development and In-house Apps Wireless Installation

Serhy · 2018-07-12T12:03:31Z

All above issues are fixed!
Users on iOS and Android are able now to navigate in Status withing Dapps and we keep the browsing history. After re-login / app restart - we keep browsing history as well!

Thanks a lot @flexsurfer! Lets merge!

Signed-off-by: Andrey Shovkoplyas <[email protected]>

statustestbot · 2018-07-12T12:57:37Z

76% of end-end tests have passed

Total executed tests: 38
Failed tests: 9
Passed tests: 29

Failed tests (9)

Click to expand

1. test_request_and_receive_tokens_in_1_1_chat
Wait for ConnectionStatusText Wait for ConnectionStatusText `E AttributeError: 'NoneType' object has no attribute 'click'` Device sessions: Device 1 Device 2
2. test_offline_messaging_1_1_chat
Wait for ConnectionStatusText Wait for ConnectionStatusText `E selenium.common.exceptions.TimeoutException: Message: 'ChatElement' is not found on screen, using: 'xpath://[@content-desc='chat-item'][.//[starts-with(@text,'user_2')]]', during '20' seconds` Device sessions: Device 1 Device 2
3. test_swipe_to_delete_public_chat
Tap on LogoutButton Looking for AccountButton `E IndexError: list index out of range` `During handling of the above exception, another exception occurred: E selenium.common.exceptions.NoSuchElementException: Message: Unable to find account by position 0` Device sessions: Device 1
4. test_send_tokens_in_1_1_chat
Wait for EnterPasswordInput Looking for EnterPasswordInput `E selenium.common.exceptions.NoSuchElementException: Message: 'EnterPasswordInput' is not found on screen, using: 'accessibility id:enter-password-input'` Device sessions: Device 1 Device 2
5. test_network_mismatch_for_send_request_commands
Tap on ConnectButton Looking for AccountButton `E IndexError: list index out of range` `During handling of the above exception, another exception occurred: E selenium.common.exceptions.NoSuchElementException: Message: Unable to find account by position 0` Device sessions: Device 1 Device 2
6. test_resend_message_offline
Looking for an element by text: 'Resend' Wait for ChatElementByText `E selenium.common.exceptions.TimeoutException: Message: 'StatusText' is not found on screen, using: 'xpath://[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/android.widget.TextView', during '10' seconds` Device sessions: Device 1 Device 2
7. test_add_contact_from_public_chat
Tap on ConnectionStatusText Looking for Username `E selenium.common.exceptions.NoSuchElementException: Message: 'Username' is not found on screen, using: 'xpath://[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/[1][name()='android.widget.TextView']'` Device sessions: Device 1
8. test_offline_status
Wait for HomeButton Looking for ConnectionStatusText `E selenium.common.exceptions.NoSuchElementException: Message: 'ConnectionStatusText' is not found on screen, using: 'xpath://[@content-desc='connection-status-text']/android.widget.TextView'` Device sessions: Device 1
9. test_backup_seed_phrase
Tap on LogoutButton Looking for AccountButton `E IndexError: list index out of range` `During handling of the above exception, another exception occurred: E selenium.common.exceptions.NoSuchElementException: Message: Unable to find account by position 0` Device sessions: Device 1

Passed tests (29)

Click to expand

1. test_create_account
Device sessions: Device 1
2. test_copy_and_paste_messages
Device sessions: Device 1
3. test_send_transaction_from_daap
Device sessions: Device 1
4. test_faucet_console_command
Device sessions: Device 1
5. test_delete_cut_and_paste_messages
Device sessions: Device 1
6. test_public_chat_messaging
Device sessions: Device 1 Device 2
7. test_back_forward_buttons_browsing_website
Device sessions: Device 1
8. test_set_profile_picture
Device sessions: Device 1
9. test_text_message_1_1_chat
Device sessions: Device 1 Device 2
10. test_add_to_contacts
Device sessions: Device 1 Device 2
11. test_send_and_open_links
Device sessions: Device 1 Device 2
12. test_copy_contact_code_and_wallet_address
Device sessions: Device 1
13. test_contact_profile_view
Device sessions: Device 1
14. test_manage_assets
Device sessions: Device 1
15. test_wallet_set_up
Device sessions: Device 1
16. test_request_and_receive_eth_in_1_1_chat
Device sessions: Device 1 Device 2
17. test_send_emoji
Device sessions: Device 1
18. test_add_contact_by_pasting_public_key
Device sessions: Device 1
19. test_web3_block_number
Device sessions: Device 1
20. test_swipe_to_delete_1_1_chat
Device sessions: Device 1
21. test_send_eth_in_1_1_chat
Device sessions: Device 1 Device 2
22. test_login_with_new_account
Device sessions: Device 1
23. test_send_request_not_enabled_tokens
Device sessions: Device 1
24. test_send_message_to_newly_added_contact
Device sessions: Device 1 Device 2
25. test_open_google_com_via_open_dapp
Device sessions: Device 1
26. test_sign_message_from_daap
Device sessions: Device 1
27. test_share_contact_code_and_wallet_address
Device sessions: Device 1
28. test_request_eth_in_wallet
Device sessions: Device 1 Device 2
29. test_recover_account
Device sessions: Device 1

flexsurfer self-assigned this Jul 6, 2018

flexsurfer requested review from jeluard and goranjovic July 6, 2018 19:49

goranjovic approved these changes Jul 6, 2018

View reviewed changes

jeluard suggested changes Jul 7, 2018

View reviewed changes

cammellos suggested changes Jul 7, 2018

View reviewed changes

rasom reviewed Jul 9, 2018

View reviewed changes

flexsurfer force-pushed the bug/make-browser-grate-again branch from 7a2a093 to d44e4cd Compare July 9, 2018 11:27

cammellos approved these changes Jul 9, 2018

View reviewed changes

jeluard approved these changes Jul 9, 2018

View reviewed changes

flexsurfer force-pushed the bug/make-browser-grate-again branch from d44e4cd to cab5c4d Compare July 9, 2018 13:04

Serhy added the Tested - Issues label Jul 9, 2018

flexsurfer force-pushed the bug/make-browser-grate-again branch from cab5c4d to f3662e6 Compare July 10, 2018 12:06

flexsurfer removed the Tested - Issues label Jul 10, 2018

flexsurfer force-pushed the bug/make-browser-grate-again branch from f3662e6 to 63efadb Compare July 11, 2018 07:45

Serhy self-assigned this Jul 11, 2018

Serhy added the Tested - Issues label Jul 11, 2018

flexsurfer force-pushed the bug/make-browser-grate-again branch from 63efadb to 059c56e Compare July 11, 2018 14:52

flexsurfer force-pushed the bug/make-browser-grate-again branch from 059c56e to 871e871 Compare July 11, 2018 16:02

jeluard removed the Tested - Issues label Jul 12, 2018

Serhy added the Tested - OK label Jul 12, 2018

No browsing history kept on iOS [#5078]

a644075

Signed-off-by: Andrey Shovkoplyas <[email protected]>

flexsurfer force-pushed the bug/make-browser-grate-again branch from 871e871 to a644075 Compare July 12, 2018 12:04

flexsurfer merged commit a644075 into develop Jul 12, 2018

rasom deleted the bug/make-browser-grate-again branch September 3, 2018 09:46

No browsing history kept on iOS [#5078] #5090

No browsing history kept on iOS [#5078] #5090

Conversation

flexsurfer commented Jul 6, 2018

status-comment-bot commented Jul 6, 2018 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flexsurfer commented Jul 9, 2018

cammellos left a comment

Choose a reason for hiding this comment

status-comment-bot commented Jul 9, 2018 • edited by ghost Loading

status-comment-bot commented Jul 9, 2018 • edited by ghost Loading

statustestbot commented Jul 9, 2018

81% of end-end tests have passed

Failed tests (12)

Passed tests (52)

Serhy commented Jul 9, 2018 • edited Loading

flexsurfer commented Jul 10, 2018

status-comment-bot commented Jul 11, 2018 • edited by ghost Loading

statustestbot commented Jul 11, 2018

88% of end-end tests have passed

Failed tests (9)

Passed tests (63)

Serhy commented Jul 11, 2018 • edited by ghost Loading

status-comment-bot commented Jul 11, 2018 • edited by ghost Loading

flexsurfer commented Jul 11, 2018

status-comment-bot commented Jul 11, 2018 • edited by ghost Loading

status-comment-bot commented Jul 12, 2018 • edited by ghost Loading

Serhy commented Jul 12, 2018

statustestbot commented Jul 12, 2018

76% of end-end tests have passed

Failed tests (9)

Passed tests (29)

status-comment-bot commented Jul 6, 2018 •

edited by ghost

Loading

status-comment-bot commented Jul 9, 2018 •

edited by ghost

Loading

status-comment-bot commented Jul 9, 2018 •

edited by ghost

Loading

Serhy commented Jul 9, 2018 •

edited

Loading

status-comment-bot commented Jul 11, 2018 •

edited by ghost

Loading

Serhy commented Jul 11, 2018 •

edited by ghost

Loading

status-comment-bot commented Jul 11, 2018 •

edited by ghost

Loading

status-comment-bot commented Jul 11, 2018 •

edited by ghost

Loading

status-comment-bot commented Jul 12, 2018 •

edited by ghost

Loading