Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system warnings, delivery notifications, general unread messages #5318

Merged
merged 16 commits into from
Sep 13, 2018
Merged

Add system warnings, delivery notifications, general unread messages #5318

merged 16 commits into from
Sep 13, 2018

Conversation

vitvly
Copy link
Contributor

@vitvly vitvly commented Jul 27, 2018 •
edited by chadyj
Loading

Fixes #5018
Duplicate of #5241 created in order to circumvent Jenkins build issues (branch base changed from desktop to develop).

@status-comment-bot
Copy link

status-comment-bot commented Jul 27, 2018 •
edited by ghost
Loading

branch PR-5318:
apk uploaded to https://i.diawi.com/Nc9cCv
ipa uploaded to https://i.diawi.com/8MRriR

cammellos
cammellos reviewed Jul 27, 2018
View reviewed changes
src/status_im/ui/components/connectivity/view.cljs Outdated
@@ -3,6 +3,7 @@
(:require [re-frame.core :as re-frame]
[reagent.core :as reagent]
[status-im.ui.components.react :as react]
[taoensso.timbre :as log]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused import?

@statustestbot
Copy link

90% of end-end tests have passed

Total executed tests: 51
Failed tests: 5
Passed tests: 46

Failed tests (5)

Click to expand
1. test_send_tokens_in_1_1_chat

Type '0x049191be3d0b0258732a4c3bd66d2e68cf7e536a0a975fd501a3265cba9ff5f7c78f51345417e42f56e16926b685f99448ac05b9608b0d42cf65ee58853f104696' to PublicKeyEditBox
Tap 'Confirm' on native keyboard

E selenium.common.exceptions.TimeoutException: Message: 'ChatMessageInput' is not found on screen, using: 'accessibility id:chat-message-input', during '60' seconds

Device sessions:

2. test_network_mismatch_for_send_request_commands

Looking for a message by text: '0.0727123031'
Looking for StatusText

E selenium.common.exceptions.NoSuchElementException: Message: 'StatusText' is not found on screen, using: 'xpath://*[starts-with(@text,'0.0727123031')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[@text='Seen' or @text='Sent' or @text='Not sent. Tap for options' or @text='Network mismatch']'

Device sessions:

3. test_send_eth_in_1_1_chat

Looking for SignTransactionButton
Tap on SignTransactionButton

E selenium.common.exceptions.TimeoutException: Message: 'ProgressBar' is still present on screen, using: 'xpath://android.widget.ProgressBar', during '60' seconds

Device sessions:

4. test_refresh_button_browsing_app_webview

Tap on BrowserRefreshPageButton
Looking for full text: 'defaultAccount'

E selenium.common.exceptions.TimeoutException: Message: 'BaseElement' is not found on screen, using: 'xpath://*[@text="defaultAccount"]', during '60' seconds

Device sessions:

5. test_transaction_confirmed_on_recipient_side

Transaction with unique amount 0.0727124217 is found in list of transactions, address is 616874dc6cc2810cdc930dea26496fcf217d58ca
Looking for a message by text: '0.0727124217'

E Failed: Transaction state is not updated on the recipient side

Device sessions:

Passed tests (46)

Click to expand
1. test_create_account
Device sessions:

2. test_filters_from_daap
Device sessions:

3. test_copy_and_paste_messages
Device sessions:

4. test_send_transaction_from_daap
Device sessions:

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions:

6. test_delete_cut_and_paste_messages
Device sessions:

7. test_deploy_contract_from_daap
Device sessions:

8. test_public_chat_messaging
Device sessions:

9. test_back_forward_buttons_browsing_website
Device sessions:

10. test_set_profile_picture
Device sessions:

11. test_text_message_1_1_chat
Device sessions:

12. test_add_to_contacts
Device sessions:

13. test_home_view
Device sessions:

14. test_send_and_open_links
Device sessions:

15. test_transaction_message_sending_from_wallet
Device sessions:

16. test_copy_contact_code_and_wallet_address
Device sessions:

17. test_message_marked_as_sent_and_seen_1_1_chat
Device sessions:

18. test_send_token_with_7_decimals
Device sessions:

19. test_offline_messaging_1_1_chat
Device sessions:

20. test_token_with_more_than_allowed_decimals
Device sessions:

21. test_send_eth_from_wallet_to_address
Device sessions:

22. test_send_transaction_details_in_1_1_chat
Device sessions:

23. test_request_eth_in_status_test_dapp
Device sessions:

24. test_manage_assets
Device sessions:

25. test_wallet_set_up
Device sessions:

26. test_request_and_receive_eth_in_1_1_chat
Device sessions:

27. test_swipe_to_delete_public_chat
Device sessions:

28. test_send_emoji
Device sessions:

29. test_add_contact_by_pasting_public_key
Device sessions:

30. test_messaging_in_different_networks
Device sessions:

31. test_resend_message_offline
Device sessions:

32. test_swipe_to_delete_1_1_chat
Device sessions:

33. test_send_stt_from_wallet
Device sessions:

34. test_login_with_new_account
Device sessions:

35. test_send_eth_from_wallet_to_contact
Device sessions:

36. test_add_contact_from_public_chat
Device sessions:

37. test_send_request_not_enabled_tokens
Device sessions:

38. test_send_message_to_newly_added_contact
Device sessions:

39. test_backup_recovery_phrase
Device sessions:

40. test_transaction_confirmed_on_sender_side
Device sessions:

41. test_offline_status
Device sessions:

42. test_open_google_com_via_open_dapp
Device sessions:

43. test_sign_message_from_daap
Device sessions:

44. test_share_contact_code_and_wallet_address
Device sessions:

45. test_request_eth_in_wallet
Device sessions:

46. test_recover_account
Device sessions:

@status-comment-bot
Copy link

status-comment-bot commented Jul 30, 2018 •
edited by ghost
Loading

branch PR-5318:
apk uploaded to https://i.diawi.com/SQqinX
ipa uploaded to https://i.diawi.com/KQnPcF

@churik churik added the desktop label Jul 30, 2018
@vitvly vitvly self-assigned this Jul 30, 2018
@churik
Copy link
Member

churik commented Jul 30, 2018 •
edited
Loading

#5200 is fixed.

#5018 - for all messages can see "Not sent, tap for options" state
upd
Log:
StatusIm.txt

@vitvly vitvly force-pushed the fix/system-warnings-notifications branch from 43bef7a to 12a1db2 Compare August 1, 2018 17:34
@status-comment-bot
Copy link

status-comment-bot commented Aug 1, 2018 •
edited by ghost
Loading

branch PR-5318:
apk uploaded to https://i.diawi.com/Qj9Cvx
ipa uploaded to https://i.diawi.com/2aSokj

@status-comment-bot
Copy link

status-comment-bot commented Aug 1, 2018 •
edited by ghost
Loading

branch PR-5318:
apk uploaded to https://i.diawi.com/KY2k68
ipa uploaded to https://i.diawi.com/G8URXV

@status-comment-bot
Copy link

status-comment-bot commented Aug 6, 2018 •
edited by ghost
Loading

branch PR-5318:
apk uploaded to https://i.diawi.com/pj6WKA
ipa uploaded to https://i.diawi.com/FPUYJ8

@status-comment-bot
Copy link

status-comment-bot commented Aug 18, 2018 •
edited by ghost
Loading

Desktop Jenkins build job started at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5318/6/

@status-comment-bot
Copy link

status-comment-bot commented Aug 18, 2018 •
edited by ghost
Loading

Desktop Jenkins build was failed or cancelled. More details at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5318/6/

@vitvly vitvly force-pushed the fix/system-warnings-notifications branch from acc60b9 to c9952fb Compare August 27, 2018 12:34
@status-comment-bot
Copy link

status-comment-bot commented Aug 27, 2018 •
edited by ghost
Loading

Desktop Jenkins build job started at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5318/8/

@status-comment-bot
Copy link

status-comment-bot commented Aug 27, 2018 •
edited by ghost
Loading

Desktop Jenkins build was failed or cancelled. More details at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5318/8/

@status-comment-bot
Copy link

status-comment-bot commented Aug 27, 2018 •
edited by ghost
Loading

Desktop Jenkins build job started at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5318/9/

@status-comment-bot
Copy link

status-comment-bot commented Aug 27, 2018 •
edited by ghost
Loading

Desktop Jenkins build was failed or cancelled. More details at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5318/9/

@vitvly vitvly force-pushed the fix/system-warnings-notifications branch from 7c3c244 to 59c1eb1 Compare September 12, 2018 13:23
@status-comment-bot
Copy link

✅ CI BUILD SUCCESSFUL

Jenkins job: #9

Mobile
Desktop

@statustestbot
Copy link

95% of end-end tests have passed

Total executed tests: 59
Failed tests: 3
Passed tests: 56

Failed tests (3)

Click to expand
1. test_add_to_contacts

Device 2: Tap on ContinueButton
Device 2: Wait for CreateAccountButton

Device 1: 'CreateAccountButton' is not found on the screen

Device sessions

2. test_offline_messaging_1_1_chat

Device 2: Type 'test message' to ChatMessageInput
Device 2: Tap on SendMessageButton

Device 1: 'ConnectionStatusText' is still visible on the screen after 20 seconds

Device sessions

3. test_transaction_confirmed_on_sender_side

Device 1: Tap on SignTransactionButton
Device 1: Wait for EnterPasswordInput

Device 1: 'EnterPasswordInput' is not found on the screen

Device sessions

Passed tests (56)

Click to expand
1. test_create_account
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_delete_cut_and_paste_messages
Device sessions

7. test_deploy_contract_from_daap
Device sessions

8. test_public_chat_messaging
Device sessions

9. test_back_forward_buttons_browsing_website
Device sessions

10. test_password_in_logcat_sign_in
Device sessions

11. test_set_profile_picture
Device sessions

12. test_text_message_1_1_chat
Device sessions

13. test_home_view
Device sessions

14. test_send_and_open_links
Device sessions

15. test_transaction_message_sending_from_wallet
Device sessions

16. test_logcat_send_transaction_from_daap
Device sessions

17. test_copy_contact_code_and_wallet_address
Device sessions

18. test_logcat_send_transaction_from_wallet
Device sessions

19. test_message_marked_as_sent_and_seen_1_1_chat
Device sessions

20. test_send_token_with_7_decimals
Device sessions

21. test_token_with_more_than_allowed_decimals
Device sessions

22. test_send_eth_from_wallet_to_address
Device sessions

23. test_send_transaction_details_in_1_1_chat
Device sessions

24. test_request_eth_in_status_test_dapp
Device sessions

25. test_manage_assets
Device sessions

26. test_wallet_set_up
Device sessions

27. test_logcat_send_transaction_in_1_1_chat
Device sessions

28. test_request_and_receive_eth_in_1_1_chat
Device sessions

29. test_swipe_to_delete_public_chat
Device sessions

30. test_send_emoji
Device sessions

31. test_add_contact_by_pasting_public_key
Device sessions

32. test_logcat_recovering_account
Device sessions

33. test_messaging_in_different_networks
Device sessions

34. test_logcat_backup_recovery_phrase
Device sessions

35. test_send_tokens_in_1_1_chat
Device sessions

36. test_network_mismatch_for_send_request_commands
Device sessions

37. test_logcat_sign_message_from_daap
Device sessions

38. test_resend_message_offline
Device sessions

39. test_swipe_to_delete_1_1_chat
Device sessions

40. test_send_stt_from_wallet
Device sessions

41. test_send_eth_in_1_1_chat
Device sessions

42. test_login_with_new_account
Device sessions

43. test_send_eth_from_wallet_to_contact
Device sessions

44. test_add_contact_from_public_chat
Device sessions

45. test_send_request_not_enabled_tokens
Device sessions

46. test_send_message_to_newly_added_contact
Device sessions

47. test_password_in_logcat_creating_account
Device sessions

48. test_backup_recovery_phrase
Device sessions

49. test_offline_status
Device sessions

50. test_open_google_com_via_open_dapp
Device sessions

51. test_sign_message_from_daap
Device sessions

52. test_share_contact_code_and_wallet_address
Device sessions

53. test_request_eth_in_wallet
Device sessions

54. test_refresh_button_browsing_app_webview
Device sessions

55. test_transaction_confirmed_on_recipient_side
Device sessions

56. test_recover_account
Device sessions

@status-comment-bot
Copy link

✅ CI BUILD SUCCESSFUL

Jenkins job: #11

Mobile
Desktop

@churik churik mentioned this pull request Sep 13, 2018
Closed
@vitvly vitvly merged commit ca2e779 into develop Sep 13, 2018
@churik
Copy link
Member

churik commented Sep 13, 2018

Tested on desktop build (OS: Mac OSx High Sierra 10.13.6):

  • installation
  • account creating/restoring
  • login/logout
  • fetching 24 h history for public channels
  • adding user to contact
  • 1-1 chat
  • mailservers switching
  • offline mode
  • messages statuses in 1-1 / public chats ('Not sent' is not implemented yet due to NetInfo isConnected event listener not firing react-native-desktop-qt#328), separate issue will be created
  • all issues above are fixed

Tested on IOS:

  • installation
  • account creating
  • fetching 24 h history for public channels
  • adding user to contact
  • 1-1 chat
  • messages statuses in 1-1 / public chats

@chadyj
Copy link
Contributor

chadyj commented Sep 14, 2018

I ran into some issues with offline. Message was reported as sent.

@chadyj chadyj mentioned this pull request Sep 14, 2018
Closed
@churik churik mentioned this pull request Sep 14, 2018
Closed
@rasom rasom deleted the fix/system-warnings-notifications branch September 24, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammellos cammellos cammellos approved these changes

@maxhora maxhora maxhora approved these changes

@vkjr vkjr vkjr approved these changes

@rcullito rcullito Awaiting requested review from rcullito

Assignees

@vitvly vitvly

Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vitvly @status-comment-bot @statustestbot @churik @maxhora @chadyj @cammellos @vkjr