Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remove-chat button next to chat title #5329

Merged
merged 3 commits into from
Aug 20, 2018
Merged

Add remove-chat button next to chat title #5329

merged 3 commits into from
Aug 20, 2018

Conversation

vitvly
Copy link
Contributor

@vitvly vitvly commented Jul 30, 2018

This replaces #4636 due to Jenkins being unable to build a rebased branch

@vitvly vitvly self-assigned this Jul 30, 2018
@vitvly vitvly added the desktop label Jul 30, 2018
@vitvly vitvly requested review from vkjr, maxhora and rcullito July 30, 2018 09:58
@status-comment-bot
Copy link

status-comment-bot commented Jul 30, 2018 •
edited by ghost
Loading

branch PR-5329:
apk uploaded to https://i.diawi.com/JsZPpe
ipa uploaded to https://i.diawi.com/cVAAQA

@vitvly vitvly force-pushed the fix/4435-add-delete-chat-option branch from 64043b5 to 2acd795 Compare July 30, 2018 10:31
@status-comment-bot
Copy link

status-comment-bot commented Jul 30, 2018 •
edited by ghost
Loading

branch PR-5329:
apk uploaded to https://i.diawi.com/hahPEL
ipa uploaded to https://i.diawi.com/ui8fJS

@vitvly
Copy link
Contributor Author

vitvly commented Jul 30, 2018

Fixed #3 (User photos are mixed in chat header)

@status-comment-bot
Copy link

status-comment-bot commented Jul 30, 2018 •
edited by ghost
Loading

branch PR-5329:
apk uploaded to https://i.diawi.com/dKdxoR
ipa uploaded to https://i.diawi.com/mehL2Y

@churik
Copy link
Member

churik commented Jul 30, 2018 •
edited
Loading

Continue #4636 (comment):

  • 1) "Add to contacts" button doesn't work
  • 2) The app is unusable after deleting chat or clearing history
  • 3) User photos are mixed in chat header
  • 4) During chat switching, I still face with behavior that username is cut( [video]
  • 5) after deleting chat, switching to profile and coming back to "Home" - Unknown chat is shown

Steps:

  • Sign Up
  • Join public chat
  • Delete chat
  • Go to Profile
  • Go to Home
    Expected result: Status.im page is shown, when no chat is selected
    Actual result:

upl

Video is here
this issue also can be reproducible when switching between Home and Profile, when user doesn't have chats.

@vitvly vitvly force-pushed the fix/4435-add-delete-chat-option branch from 06f60c9 to b055ffd Compare August 1, 2018 16:03
@status-comment-bot
Copy link

status-comment-bot commented Aug 1, 2018 •
edited by ghost
Loading

branch PR-5329:
apk uploaded to https://i.diawi.com/MxGnvX
ipa uploaded to https://i.diawi.com/d9CBvB

@vitvly
Copy link
Contributor Author

vitvly commented Aug 1, 2018

Fixed #5 - after deleting chat home screen is shown after navigating to Profile and back.

@status-comment-bot
Copy link

status-comment-bot commented Aug 1, 2018 •
edited by ghost
Loading

branch PR-5329:
apk uploaded to https://i.diawi.com/6yGNd5
ipa uploaded to https://i.diawi.com/Geybg7

@status-comment-bot
Copy link

status-comment-bot commented Aug 6, 2018 •
edited by ghost
Loading

branch PR-5329:
apk uploaded to https://i.diawi.com/4hcp6Z
ipa uploaded to https://i.diawi.com/QununA

@status-comment-bot
Copy link

status-comment-bot commented Aug 6, 2018 •
edited by ghost
Loading

branch PR-5329:
apk uploaded to https://i.diawi.com/KPWTGE
ipa uploaded to https://i.diawi.com/ThvkX7

@churik
Copy link
Member

churik commented Aug 7, 2018

Tested:

  • 5 issues are fixed
  • account is created;
  • add new contact;
  • join public chat;
  • 1-1 chat, public chat - deleting chat, clearing history;
  • relogin after deleting chat, clearing history;

@status-comment-bot
Copy link

status-comment-bot commented Aug 8, 2018 •
edited by ghost
Loading

branch PR-5329:
apk uploaded to https://i.diawi.com/x1ez5V
ipa uploaded to https://i.diawi.com/yhcf7Y

@status-comment-bot
Copy link

status-comment-bot commented Aug 10, 2018 •
edited by ghost
Loading

branch PR-5329:
apk uploaded to https://i.diawi.com/cj48JN
ipa uploaded to https://i.diawi.com/ufrdmx

@status-comment-bot
Copy link

status-comment-bot commented Aug 14, 2018 •
edited by ghost
Loading

branch PR-5329:
apk uploaded to https://i.diawi.com/Fuqqrh
ipa uploaded to https://i.diawi.com/QGNuNe

@vkjr vkjr force-pushed the fix/4435-add-delete-chat-option branch from 1877e83 to 703276f Compare August 16, 2018 10:26
@status-comment-bot
Copy link

status-comment-bot commented Aug 16, 2018 •
edited by ghost
Loading

Branch: PR-5329, Android build uploaded to diawi: https://i.diawi.com/ebmUUp

@status-comment-bot
Copy link

status-comment-bot commented Aug 16, 2018 •
edited by ghost
Loading

Branch: PR-5329, iOS build uploaded to diawi: https://i.diawi.com/VHCP6n

@status-comment-bot
Copy link

status-comment-bot commented Aug 16, 2018 •
edited by ghost
Loading

Branch: PR-5329, Android build uploaded to diawi: https://i.diawi.com/PBRAgf

@status-comment-bot
Copy link

status-comment-bot commented Aug 16, 2018 •
edited by ghost
Loading

Desktop Jenkins build job started at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5329/6/

@status-comment-bot
Copy link

status-comment-bot commented Aug 18, 2018 •
edited by ghost
Loading

Desktop Jenkins build job started at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5329/8/

@status-comment-bot
Copy link

status-comment-bot commented Aug 18, 2018 •
edited by ghost
Loading

Desktop Jenkins build was failed or cancelled. More details at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5329/8/

Vitaliy Vlasov added 3 commits August 20, 2018 13:42
Add remove-chat button next to chat title
88740ea 
Update chat header design

Aligh header heights

Add 'Clear history'; some reformatting

Add confirmations

Formatting

Member photo fix; increase font size for 9+ unviewed messages indicator

Fix chat view autoloading upon tab switching; Merge with desktop

Fix add-to-contacts
Fix photos not updating
e40d06f
Set current-chat-id to nil once chat is deleted (desktop only)
1186b73
@vitvly vitvly force-pushed the fix/4435-add-delete-chat-option branch from 703276f to 1186b73 Compare August 20, 2018 10:42
@status-comment-bot
Copy link

status-comment-bot commented Aug 20, 2018 •
edited by ghost
Loading

Desktop Jenkins build job started at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5329/9/

@vitvly vitvly merged commit 7ea9e63 into develop Aug 20, 2018
@status-comment-bot
Copy link

status-comment-bot commented Aug 20, 2018 •
edited by ghost
Loading

Desktop Jenkins build was failed or cancelled. More details at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5329/9/

@rasom rasom deleted the fix/4435-add-delete-chat-option branch September 3, 2018 09:47
This was referenced Sep 25, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhora maxhora maxhora approved these changes

@vkjr vkjr vkjr approved these changes

@rcullito rcullito Awaiting requested review from rcullito

Assignees

@vitvly vitvly

Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vitvly @status-comment-bot @churik @maxhora @vkjr