Test react-native-desktop TextInput changes #6247

vkjr · 2018-10-10T13:37:44Z

Supplemental changes to react-native-desktop fixes - status-im/react-native-desktop-qt#365.

:on-submit-editing now supported in multiline TextInputs, so chat input was adjusted to use it.

Should be fixed right after status-im/react-native-desktop-qt#365

ghost · 2018-10-10T13:37:50Z

Pull Request Checklist

Have you updated the documentation, if impacted (e.g. docs.status.im)?

status-comment-bot · 2018-10-10T14:02:53Z

✅ CI BUILD SUCCESSFUL

Jenkins job: #1

Mobile

Android, (e2e)
iOS

Desktop

vkjr · 2018-10-10T17:15:40Z

@churik, could you please check that my changes in react-native-desktop has no negative impact on status-react?
Changes are TextInput component fixes all inputs affected.

SlizkovaGanna · 2018-10-11T13:39:40Z

@vkjr
Issues found within this PR:

1. Leftover input from a sent reply message when switching between chats

Steps to reproduce:

Open two any chats for your user, one of them - with at leas 1 message from a contact
Reply to a message (click on it and add a reply under a box with the message) and send it
Click on a different chat to move to it
Click on the previous chat to move back and check your message input field

Actual result:
The reply message you've already sent is displayed in your input message box again
Expected result:
Input message box should be empty

Additional data:
Video: https://monosnap.com/file/YFNFR82vHS2xpm8pKLSgsLeTajFsbV
Reproduces for MacOS and Linux. Not reproducible on nightly 11/10/18

2. Icons are broken when user is inserting data between the icons

Steps to reproduce:

Open any chat
Input a line of emojis (ex. 😌😩💁💕✌️🙈😄)
Put your cursor in between any of them and start typing any text

Actual result:
Text starts to go past emojis, breaking the encoding in the process, check the screenshot below:

Expected result:
Text is inserted between the selected emojis, the emojis are not affected or changed in any way

Additional data:
Reproduces for MacOS and Linux. Not reproducible on nightly 11/10/18

3. Question - when switching between chats with input on 1 chat, should focus be at the end of text when you are switching back to 1 chat?

yenda · 2018-10-12T12:19:59Z

@SlizkovaGanna regarding 1. I think it's more a problem because of the hack that we used to go around this bug so we'll need to fix it in status-react. For 2. it's probably a problem with this fix ? @vkjr

vkjr · 2018-10-17T11:11:12Z

@SlizkovaGanna, thanks for finding these!

@yenda, regarding 2 - yes, that was a bug, I fixed it.
regarding 1 - it is because TextInput was fixed :)
This code works on desktop differently from mobile - https://github.com/status-im/status-react/blob/develop/src/status_im/ui/screens/desktop/main/chat/views.cljs#L330
On mobile we press button, send message and clear input-text.
But on desktop we have following:

user presses Enter
we catch it in on-key-press and send message, plus clear input-text value in db and call clear() on TextInput
after that on-change comes, because Enter is also key on desktop and that triggers setting input-text again. And we have a problem :)

Before that wasn't a problem because calling clear() on TextInput had a side effect of calling onChange. But it is wrong and mobile also doesn't behave like this. Now, when it is fixed, problem come up.

GitHub
status-im/status-react
a free (libre) open source, mobile OS for Ethereum - status-im/status-react

vkjr · 2018-10-17T11:14:01Z

@yenda, do you have suggestion on how we can change clojure code to avoid this? Theoretically we can set some flag when message sent and do not process onChange that comes right after sending. But that looks a bit... okay not a bit, just ugly :)

yenda · 2018-10-18T12:20:01Z

@vkjr after cleaning up the input field to have it like the one in mobile, it still doesn't have the same behavior. When sending the message with the button, it doesn't empty the input-field as it does in mobile.

yenda · 2018-10-18T12:22:58Z

I also got a few crashes:

"UIManager:" ::manageChildren for containerReactTag:  28275  moveFromIndicies:  (0)  moveToIndices:  (1)  addChildReactTags:  ()  addAtIndices:  ()  removeAtIndices:  ()
"UIManager:" ::manageChildren container->childItems().size():  0
"UIManager:" ::manageChildren container->childItems():  ()
"Flexbox:" utilities::removeFlexboxChilds remove children at indexes (0)  from parent item:  ReactView_QMLTYPE_33(0x5650ef2dc8b0, parent=0x0, geometry=0,0 340x328)  parent flexbox:  Flexbox(0x5650ef2dcf70)
"Flexbox:" ::removeChilds YGNode:  0x5650ef228e50  will be removed at index:  0  from:  Flexbox(0x5650ef2dcf70)
"UIManager:" ::manageChildren containerFlexbox->addChild Parent container:  ReactView_QMLTYPE_33(0x5650ef2dc8b0, parent=0x0, geometry=0,0 340x328)  parent container flexbox:  Flexbox(0x5650ef2dcf70)  Child item:  ReactView_QMLTYPE_33(0x5650ef280c90, parent=0x5650ef2e85b0, geometry=0,0 340x94)  child flexbox:  Flexbox(0x5650ef281aa0)  position to add at:  1
"Flexbox:" ::addChild new YGNode:  0x5650ef281b50  for flexbox:  Flexbox(0x5650ef281aa0)  will be inserted at:  1  into parent:  Flexbox(0x5650ef2dcf70)
Child already has a owner, it must be removed first.
Received signal 6
#0 0x7f529dc7452f <unknown>
#1 0x7f529c6a5b1d <unknown>
#2 0x7f529dc74a3e <unknown>
#3 0x7f530418b890 <unknown>
#4 0x7f5303482e97 gsignal
#5 0x7f5303484801 abort
#6 0x5650db0b149c YGVLog()
#7 0x5650db0b165b YGLog
#8 0x5650db0b16fa YGAssertWithNode
#9 0x5650db0a1d68 YGNodeInsertChild
#10 0x5650db0889a2 Flexbox::addChild()
#11 0x5650db064a3d UIManager::manageChildren()
#12 0x5650db0387f7 UIManager::qt_static_metacall()
#13 0x7f530460a4c9 QMetaMethod::invoke()
#14 0x5650db0504d9 QMetaMethod::invoke()
#15 0x5650db04f77f ModuleMethod::invoke()
#16 0x5650db044325 Bridge::invokeModuleMethod()
#17 0x5650db02d47d Bridge::qt_static_metacall()
#18 0x7f530462a0e1 QObject::event()
#19 0x7f53045fe2d8 QCoreApplication::notifyInternal2()
#20 0x7f5304600ceb QCoreApplicationPrivate::sendPostedEvents()
#21 0x7f5304652d93 postEventSourceDispatch()
#22 0x7f5300242287 g_main_context_dispatch
#23 0x7f53002424c0 <unknown>
#24 0x7f530024254c g_main_context_iteration
#25 0x7f53046523ff QEventDispatcherGlib::processEvents()
#26 0x7f52fc3160d1 QPAEventDispatcherGlib::processEvents()
#27 0x7f53045fcc3a QEventLoop::exec()
#28 0x7f5304605640 QCoreApplication::exec()
#29 0x5650db01d659 main
#30 0x7f5303465b97 __libc_start_main
#31 0x5650db01c3da _start
  r8: 0000000000000000  r9: 00007ffdecf0b8b0 r10: 0000000000000008 r11: 0000000000000246
 r12: 0000000000000001 r13: 0000000000000007 r14: 00005650de1385e0 r15: 00005650dc2ac920
  di: 0000000000000002  si: 00007ffdecf0b8b0  bp: 00007ffdecf0bb40  bx: 00005650ef281b50
  dx: 0000000000000000  ax: 0000000000000000  cx: 00007f5303482e97  sp: 00007ffdecf0b8b0
  ip: 00007f5303482e97 efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.

vkjr · 2018-10-19T07:52:43Z

@yenda, yeah, I also have crashes. Checking now.

status-comment-bot · 2018-10-24T09:46:37Z

✅ CI BUILD SUCCESSFUL

Jenkins job: #3

Mobile

Android, (e2e)
iOS

Desktop

vkjr · 2018-10-24T10:22:08Z

@SlizkovaGanna, could you please check again. Problems you mentioned fixed now

statustestbot · 2018-10-24T15:24:46Z

90% of end-end tests have passed

Total executed tests: 60
Failed tests: 6
Passed tests: 54

Failed tests (6)

Click to expand

1. test_offline_messaging_1_1_chat
Device 2: Type 'test message' to ChatMessageInput Device 2: Tap on SendMessageButton `Device 1: 'ConnectionStatusText' is still visible on the screen after 20 seconds` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_modify_transaction_fee_values
Device 1: Tap on SignTransactionButton Device 1: Looking for an element by text: 'intrinsic gas too low' `Device 1: 'BaseText' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
3. test_onboarding_screen_is_shown_for_account_when_requesting_tokens
Device 1: Wait for RequestSTTButton Device 1: Wait for RequestSTTButton `Device 1: 'RequestSTTButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
4. test_send_tokens_in_1_1_chat
Device 2: Wait for CreateAccountButton Device 1: Wait for OtherAccountsButton `Device 1: 'IHaveAccountButton' is not found on the screen` Device sessions Device 2: Steps, video, logs Failure screenshot Device 1: Steps, video, logs Failure screenshot
5. test_network_mismatch_for_send_request_commands
Device 1: Tap on GotItButton Device 1: Looking for a message by text: '0.0102414421' `Device 1: 'ChatElementByText' is not found on the screen` Device sessions Device 2: Steps, video, logs Failure screenshot Device 1: Steps, video, logs Failure screenshot
6. test_offline_status
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://wiki.saucelabs.com/display/DOCS/Common+Error+Messages`

Passed tests (54)

Click to expand

1. test_create_account
Device sessions Device 1: Steps, video, logs
2. test_user_can_switch_network
Device sessions Device 1: Steps, video, logs
3. test_filters_from_daap
Device sessions Device 1: Steps, video, logs
4. test_copy_and_paste_messages
Device sessions Device 1: Steps, video, logs
5. test_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
6. test_request_and_receive_tokens_in_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
7. test_delete_cut_and_paste_messages
Device sessions Device 1: Steps, video, logs
8. test_deploy_contract_from_daap
Device sessions Device 1: Steps, video, logs
9. test_offline_login
Device sessions Device 1: Steps, video, logs
10. test_pass_phrase_validation
Device sessions Device 1: Steps, video, logs
11. test_public_chat_messaging
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
12. test_back_forward_buttons_browsing_website
Device sessions Device 1: Steps, video, logs
13. test_password_in_logcat_sign_in
Device sessions Device 1: Steps, video, logs
14. test_set_profile_picture
Device sessions Device 1: Steps, video, logs
15. test_text_message_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
16. test_add_to_contacts
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
17. test_unread_messages_counter_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
18. test_logcat_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
19. test_privacy_policy_is_accessible
Device sessions Device 1: Steps, video, logs
20. test_logcat_send_transaction_from_wallet
Device sessions Device 1: Steps, video, logs
21. test_send_token_with_7_decimals
Device sessions Device 1: Steps, video, logs
22. test_token_with_more_than_allowed_decimals
Device sessions Device 1: Steps, video, logs
23. test_send_eth_from_wallet_to_address
Device sessions Device 1: Steps, video, logs
24. test_send_transaction_details_in_1_1_chat
Device sessions Device 1: Steps, video, logs
25. test_manage_assets
Device sessions Device 1: Steps, video, logs
26. test_wallet_set_up
Device sessions Device 1: Steps, video, logs
27. test_logcat_send_transaction_in_1_1_chat
Device sessions Device 1: Steps, video, logs
28. test_request_and_receive_eth_in_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
29. test_swipe_to_delete_public_chat
Device sessions Device 1: Steps, video, logs
30. test_passphrase_whitespaces_ignored_while_recovering_access
Device sessions Device 1: Steps, video, logs
31. test_send_emoji
Device sessions Device 1: Steps, video, logs
32. test_add_contact_by_pasting_public_key
Device sessions Device 1: Steps, video, logs
33. test_logcat_recovering_account
Device sessions Device 1: Steps, video, logs
34. test_messaging_in_different_networks
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
35. test_logcat_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
36. test_swipe_to_delete_1_1_chat
Device sessions Device 1: Steps, video, logs
37. test_switch_users_and_add_new_account
Device sessions Device 1: Steps, video, logs
38. test_send_stt_from_wallet
Device sessions Device 1: Steps, video, logs
39. test_send_eth_in_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
40. test_login_with_new_account
Device sessions Device 1: Steps, video, logs
41. test_send_eth_from_wallet_to_contact
Device sessions Device 1: Steps, video, logs
42. test_add_contact_from_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
43. test_send_request_not_enabled_tokens
Device sessions Device 1: Steps, video, logs
44. test_send_message_to_newly_added_contact
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
45. test_password_in_logcat_creating_account
Device sessions Device 1: Steps, video, logs
46. test_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
47. test_open_google_com_via_open_dapp
Device sessions Device 1: Steps, video, logs
48. test_unread_messages_counter_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
49. test_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
50. test_share_contact_code_and_wallet_address
Device sessions Device 1: Steps, video, logs
51. test_request_eth_in_wallet
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
52. test_refresh_button_browsing_app_webview
Device sessions Device 1: Steps, video, logs
53. test_backup_recovery_phrase_warning_from_wallet
Device sessions Device 1: Steps, video, logs
54. test_recover_account
Device sessions Device 1: Steps, video, logs

SlizkovaGanna · 2018-10-24T15:45:27Z

No issues found. Old issues are indeed fixed.

The failed test #1 is unrelated to those changes.

Tested on MacOS 10.13.4

vkjr · 2018-10-24T15:58:21Z

@yenda, @Maxris, @siphuel, could you please review small change in chat input? I'll remove changes in package.json and package-lock.json before merge.

vkjr · 2018-10-24T15:59:21Z

@SlizkovaGanna, could you please put Tested-OK label if no problems found?

status-comment-bot · 2018-10-25T07:57:34Z

✅ CI BUILD SUCCESSFUL

Jenkins job: #4

Mobile

Android, (e2e)
iOS

Desktop

Signed-off-by: Volodymyr Kozieiev <[email protected]>

status-comment-bot · 2018-10-25T08:21:27Z

✅ CI BUILD SUCCESSFUL

Jenkins job: #5

Mobile

Android, (e2e)
iOS

Desktop

vkjr added the desktop label Oct 10, 2018

vkjr changed the title ~~Switched to rnd branch to test TextInput changes~~ [WIP]Switched to rnd branch to test TextInput changes Oct 10, 2018

vkjr self-assigned this Oct 11, 2018

vkjr changed the title ~~[WIP]Switched to rnd branch to test TextInput changes~~ Test react-native-desktop TextInput changes Oct 11, 2018

vkjr added the RN-related label Oct 11, 2018

churik added the high-priority label Oct 11, 2018

SlizkovaGanna added the Tested - Issues label Oct 11, 2018

churik assigned churik and SlizkovaGanna Oct 11, 2018

vkjr force-pushed the fix/message_input_vkjr3 branch 2 times, most recently from 92fbb68 to d169d28 Compare October 24, 2018 09:22

vkjr requested review from vitvly, yenda and maxhora October 24, 2018 15:57

SlizkovaGanna added Tested - OK and removed Tested - Issues labels Oct 24, 2018

yenda approved these changes Oct 24, 2018

View reviewed changes

maxhora approved these changes Oct 24, 2018

View reviewed changes

vitvly approved these changes Oct 24, 2018

View reviewed changes

vkjr force-pushed the fix/message_input_vkjr3 branch from d169d28 to 7e9d7c7 Compare October 25, 2018 07:36

Adjusted chat input to send text on on-submit-editing

0bc9fb6

Signed-off-by: Volodymyr Kozieiev <[email protected]>

vkjr force-pushed the fix/message_input_vkjr3 branch from 7e9d7c7 to 0bc9fb6 Compare October 25, 2018 08:02

vkjr merged commit 0bc9fb6 into develop Oct 25, 2018

rasom deleted the fix/message_input_vkjr3 branch January 11, 2019 17:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test react-native-desktop TextInput changes #6247

Test react-native-desktop TextInput changes #6247

vkjr commented Oct 10, 2018 •

edited

Loading

ghost commented Oct 10, 2018 •

edited by vkjr

Loading

status-comment-bot commented Oct 10, 2018

vkjr commented Oct 10, 2018

SlizkovaGanna commented Oct 11, 2018 •

edited by churik

Loading

yenda commented Oct 12, 2018

vkjr commented Oct 17, 2018 •

edited

Loading

vkjr commented Oct 17, 2018

yenda commented Oct 18, 2018

yenda commented Oct 18, 2018

vkjr commented Oct 19, 2018

status-comment-bot commented Oct 24, 2018

vkjr commented Oct 24, 2018 •

edited

Loading

statustestbot commented Oct 24, 2018

SlizkovaGanna commented Oct 24, 2018 •

edited

Loading

vkjr commented Oct 24, 2018

vkjr commented Oct 24, 2018

status-comment-bot commented Oct 25, 2018

status-comment-bot commented Oct 25, 2018

Test react-native-desktop TextInput changes #6247

Test react-native-desktop TextInput changes #6247

Conversation

vkjr commented Oct 10, 2018 • edited Loading

ghost commented Oct 10, 2018 • edited by vkjr Loading

Pull Request Checklist

status-comment-bot commented Oct 10, 2018

✅ CI BUILD SUCCESSFUL

Mobile

Desktop

vkjr commented Oct 10, 2018

SlizkovaGanna commented Oct 11, 2018 • edited by churik Loading

yenda commented Oct 12, 2018

vkjr commented Oct 17, 2018 • edited Loading

vkjr commented Oct 17, 2018

yenda commented Oct 18, 2018

yenda commented Oct 18, 2018

vkjr commented Oct 19, 2018

status-comment-bot commented Oct 24, 2018

✅ CI BUILD SUCCESSFUL

Mobile

Desktop

vkjr commented Oct 24, 2018 • edited Loading

statustestbot commented Oct 24, 2018

90% of end-end tests have passed

Failed tests (6)

Passed tests (54)

SlizkovaGanna commented Oct 24, 2018 • edited Loading

vkjr commented Oct 24, 2018

vkjr commented Oct 24, 2018

status-comment-bot commented Oct 25, 2018

✅ CI BUILD SUCCESSFUL

Mobile

Desktop

status-comment-bot commented Oct 25, 2018

✅ CI BUILD SUCCESSFUL

Mobile

Desktop

vkjr commented Oct 10, 2018 •

edited

Loading

ghost commented Oct 10, 2018 •

edited by vkjr

Loading

SlizkovaGanna commented Oct 11, 2018 •

edited by churik

Loading

vkjr commented Oct 17, 2018 •

edited

Loading

vkjr commented Oct 24, 2018 •

edited

Loading

SlizkovaGanna commented Oct 24, 2018 •

edited

Loading