Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/discovery topic filter #7412

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Bug/discovery topic filter #7412

merged 2 commits into from
Feb 4, 2019

Conversation

cammellos
Copy link
Contributor

Fixes #7410
This restore the previous behavior, for 1-to-1 messages we don't set a chat-id in the filter, as multiple chats are listening to the filter. It is only an issue on messages sent through pairing, as otherwise we just use the signature of the user.

status: ready

@cammellos cammellos self-assigned this Feb 4, 2019
@ghost
Copy link

ghost commented Feb 4, 2019

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-im-auto
Copy link
Member

status-im-auto commented Feb 4, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 0215d44 #1 2019-02-04 12:57:58 ~31 sec windows 📄 build log
✔️ 0215d44 #1 2019-02-04 13:13:29 ~16 min ios-e2e 📦 package
✔️ 0215d44 #1 2019-02-04 13:13:43 ~16 min ios 📦 package
✔️ 0215d44 #1 2019-02-04 13:14:09 ~16 min macos 📦 package
✔️ 0215d44 #1 2019-02-04 13:15:12 ~17 min android 📦 package
✔️ 0215d44 #1 2019-02-04 13:17:52 ~20 min android-e2e 📦 package
✔️ 0215d44 #1 2019-02-04 13:18:44 ~21 min linux 📦 package
✔️ 0215d44 #2 2019-02-04 14:29:19 ~24 min windows 📦 package
✔️ 3469a3d #2 2019-02-04 16:44:35 ~19 min android-e2e 📦 package

@churik churik self-assigned this Feb 4, 2019
@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 58
Failed tests: 0
Passed tests: 58

Passed tests (58)

Click to expand
1. test_create_account
Device sessions

2. test_user_can_switch_network
Device sessions

3. test_filters_from_daap
Device sessions

4. test_copy_and_paste_messages
Device sessions

5. test_send_transaction_from_daap
Device sessions

6. test_request_and_receive_tokens_in_1_1_chat
Device sessions

7. test_delete_cut_and_paste_messages
Device sessions

8. test_deploy_contract_from_daap
Device sessions

9. test_offline_login
Device sessions

10. test_pass_phrase_validation
Device sessions

11. test_public_chat_messaging
Device sessions

12. test_password_in_logcat_sign_in
Device sessions

13. test_set_profile_picture
Device sessions

14. test_text_message_1_1_chat
Device sessions

15. test_add_to_contacts
Device sessions

16. test_unread_messages_counter_1_1_chat
Device sessions

17. test_logcat_send_transaction_from_daap
Device sessions

18. test_onboarding_screen_when_requesting_tokens_for_new_account
Device sessions

19. test_logcat_send_transaction_from_wallet
Device sessions

20. test_send_token_with_7_decimals
Device sessions

21. test_modify_transaction_fee_values
Device sessions

22. test_token_with_more_than_allowed_decimals
Device sessions

23. test_send_eth_from_wallet_to_address
Device sessions

24. test_send_transaction_details_in_1_1_chat
Device sessions

25. test_manage_assets
Device sessions

26. test_wallet_set_up
Device sessions

27. test_logcat_send_transaction_in_1_1_chat
Device sessions

28. test_request_and_receive_eth_in_1_1_chat
Device sessions

29. test_swipe_to_delete_public_chat
Device sessions

30. test_passphrase_whitespaces_ignored_while_recovering_access
Device sessions

31. test_send_emoji
Device sessions

32. test_add_contact_by_pasting_public_key
Device sessions

33. test_logcat_recovering_account
Device sessions

34. test_messaging_in_different_networks
Device sessions

35. test_send_tokens_in_1_1_chat
Device sessions

36. test_network_mismatch_for_send_request_commands
Device sessions

37. test_logcat_sign_message_from_daap
Device sessions

38. test_swipe_to_delete_1_1_chat
Device sessions

39. test_switch_users_and_add_new_account
Device sessions

40. test_send_stt_from_wallet
Device sessions

41. test_send_eth_in_1_1_chat
Device sessions

42. test_login_with_new_account
Device sessions

43. test_send_eth_from_wallet_to_contact
Device sessions

44. test_add_contact_from_public_chat
Device sessions

45. test_send_request_not_enabled_tokens
Device sessions

46. test_send_message_to_newly_added_contact
Device sessions

47. test_password_in_logcat_creating_account
Device sessions

48. test_backup_recovery_phrase
Device sessions

49. test_offline_status
Device sessions

50. test_open_google_com_via_open_dapp
Device sessions

51. test_unread_messages_counter_public_chat
Device sessions

52. test_sign_message_from_daap
Device sessions

53. test_user_can_remove_profile_picture
Device sessions

54. test_share_contact_code_and_wallet_address
Device sessions

55. test_request_eth_in_wallet
Device sessions

56. test_refresh_button_browsing_app_webview
Device sessions

57. test_backup_recovery_phrase_warning_from_wallet
Device sessions

58. test_recover_account
Device sessions

@churik
Copy link
Member

churik commented Feb 4, 2019

Tested on Mac Os, Android 7.0 (LG V20), IOS 11.4 (IPhone 7).
investigated #7417, but it is not specific to this PR.
The initial issue was fixed.

@cammellos cammellos force-pushed the bug/discovery-topic-filter branch from 0215d44 to 3469a3d Compare February 4, 2019 16:25
@cammellos cammellos merged commit 3469a3d into develop Feb 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the bug/discovery-topic-filter branch February 4, 2019 16:25
@churik churik mentioned this pull request Feb 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasom rasom rasom approved these changes

@mandrigin mandrigin mandrigin approved these changes

@jeluard jeluard jeluard approved these changes

@yenda yenda Awaiting requested review from yenda

Assignees

@cammellos cammellos

@churik churik

Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cammellos @status-im-auto @statustestbot @churik @jeluard @mandrigin @rasom