Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/hermes camera #8861

Closed
wants to merge 18 commits into from
Closed

Feature/hermes camera #8861

wants to merge 18 commits into from

Conversation

vitvly
Copy link
Contributor

@vitvly vitvly commented Aug 29, 2019 •
edited by StatusWrike
Loading

Updated react-native-camera library version and adjusted APIs as per https://react-native-community.github.io/react-native-camera/docs/migration.

Cherry-picked @flexsurfer 's commits from #8862.

Note: clicking on yellow warnings might trigger facebook/hermes#65

Supercedes #8792

Fixes #8772

@ghost
Copy link

ghost commented Aug 29, 2019

desktop_files/yarn.lock and mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@ghost
Copy link

ghost commented Aug 29, 2019

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@ghost
Copy link

ghost commented Aug 29, 2019

desktop_files/yarn.lock and mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@status-im-auto
Copy link
Member

status-im-auto commented Aug 29, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (21)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 82138ba #1 2019-08-29 09:11:08 ~28 sec android 📄 log
❌ 82138ba #1 2019-08-29 09:11:08 ~27 sec ios 📄 log
❌ 82138ba #1 2019-08-29 09:11:10 ~32 sec android-e2e 📄 log
❌ a68fa3e #2 2019-08-29 09:13:42 ~33 sec android-e2e 📄 log
❌ a68fa3e #2 2019-08-29 09:13:42 ~30 sec ios 📄 log
✔️ a68fa3e #2 2019-08-29 09:25:11 ~12 min android 📦 apk
❌ 3a557e4 #3 2019-09-02 07:44:55 ~23 sec ios 📄 log
❌ 3a557e4 #3 2019-09-02 07:44:55 ~24 sec android 📄 log
❌ 3a557e4 #3 2019-09-02 07:51:50 ~7 min android-e2e 📄 log
❌ 33e714d #4 2019-09-02 08:17:17 ~23 sec android 📄 log
❌ 33e714d #4 2019-09-02 08:17:17 ~22 sec ios 📄 log
❌ 33e714d #4 2019-09-02 08:28:00 ~11 min android-e2e 📄 log
❌ 0b66e69 #5 2019-09-02 12:08:07 ~23 sec android 📄 log
❌ 0b66e69 #5 2019-09-02 12:08:08 ~22 sec ios 📄 log
✔️ 0b66e69 #5 2019-09-02 12:21:02 ~13 min android-e2e 📦 apk
❌ fd0dfeb #6 2019-09-02 14:00:06 ~19 sec android 📄 log
❌ fd0dfeb #6 2019-09-02 14:00:10 ~21 sec ios 📄 log
✔️ fd0dfeb #6 2019-09-02 14:11:30 ~11 min android-e2e 📦 apk
❌ 69f55ab #7 2019-09-02 14:46:11 ~23 sec android 📄 log
❌ 69f55ab #7 2019-09-02 14:46:11 ~22 sec ios 📄 log
✔️ 69f55ab #7 2019-09-02 14:55:40 ~9 min android-e2e 📦 apk
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ de1259d #8 2019-09-04 08:48:38 ~2 min ios 📄 log
❌ de1259d #8 2019-09-04 09:00:42 ~14 min android-e2e 📄 log
❌ de1259d #8 2019-09-04 09:03:35 ~17 min android 📄 log
❌ de1259d #9 2019-09-04 16:12:38 ~19 sec ios 📄 log
❌ f530d05 #10 2019-09-05 08:48:20 ~2 min ios 📄 log
❌ f530d05 #9 2019-09-05 08:53:07 ~6 min android-e2e 📄 log
❌ f530d05 #9 2019-09-05 08:54:13 ~7 min android 📄 log

@vitvly vitvly force-pushed the feature/hermes-camera branch from 82138ba to a68fa3e Compare August 29, 2019 09:13
@ghost
Copy link

ghost commented Aug 29, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@vitvly vitvly self-assigned this Aug 29, 2019
@ghost
Copy link

ghost commented Aug 29, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

1 similar comment
@ghost
Copy link

ghost commented Aug 29, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@pedropombeiro pedropombeiro force-pushed the feature/upgrade-to-rn-hermes branch from c42e160 to 05fe6d4 Compare August 29, 2019 15:32
@pedropombeiro pedropombeiro force-pushed the feature/upgrade-to-rn-hermes branch 5 times, most recently from bd4238c to f4c8e45 Compare August 30, 2019 15:18
@ghost
Copy link

ghost commented Sep 2, 2019

desktop_files/yarn.lock and mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

4 similar comments
@ghost
Copy link

ghost commented Sep 2, 2019

desktop_files/yarn.lock and mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@ghost
Copy link

ghost commented Sep 2, 2019

desktop_files/yarn.lock and mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@ghost
Copy link

ghost commented Sep 2, 2019

desktop_files/yarn.lock and mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@ghost
Copy link

ghost commented Sep 2, 2019

desktop_files/yarn.lock and mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@vitvly vitvly force-pushed the feature/hermes-camera branch from 0b66e69 to fd0dfeb Compare September 2, 2019 13:59
@ghost
Copy link

ghost commented Sep 2, 2019

desktop_files/yarn.lock and mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

2 similar comments
@ghost
Copy link

ghost commented Sep 2, 2019

desktop_files/yarn.lock and mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@ghost
Copy link

ghost commented Sep 2, 2019

desktop_files/yarn.lock and mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@vitvly vitvly marked this pull request as ready for review September 2, 2019 15:00
@pedropombeiro pedropombeiro force-pushed the feature/upgrade-to-rn-hermes branch from ea913dc to 4df927d Compare September 4, 2019 17:33
@pedropombeiro pedropombeiro force-pushed the feature/upgrade-to-rn-hermes branch from 4df927d to fc82a0e Compare September 4, 2019 17:44
@vitvly vitvly force-pushed the feature/hermes-camera branch from de1259d to f530d05 Compare September 5, 2019 08:46
@ghost
Copy link

ghost commented Sep 5, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@pedropombeiro pedropombeiro force-pushed the feature/upgrade-to-rn-hermes branch 2 times, most recently from 10e9ac1 to 778b5fd Compare September 5, 2019 13:12
@yenda yenda mentioned this pull request Sep 5, 2019
Closed
24 tasks
@pedropombeiro pedropombeiro force-pushed the feature/upgrade-to-rn-hermes branch 15 times, most recently from c45e145 to 9242a9d Compare September 6, 2019 16:51
@pedropombeiro
Copy link
Contributor

Closing as it's been integrated in #8943

@ghost
Copy link

ghost commented Apr 30, 2020

desktop_files/yarn.lock and mobile_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@jakubgs jakubgs deleted the feature/hermes-camera branch May 12, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@jakubgs jakubgs Awaiting requested review from jakubgs

@pedropombeiro pedropombeiro Awaiting requested review from pedropombeiro

@vkjr vkjr Awaiting requested review from vkjr

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitvly @status-im-auto @flexsurfer @pedropombeiro