-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security #7 #8906
security #7 #8906
Conversation
Pull Request Checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have access to security-reports repo. Why do we need to delay calls to navigation-state-changed?
to fix #7 ) |
@flexsurfer oh, ok :) |
|
||
(defn debounce [event] | ||
(when @timeout (js/clearTimeout @timeout)) | ||
(reset! timeout (js/setTimeout #(re-frame/dispatch event) 500))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it turns every timeout into a 500ms timeout?
93% of end-end tests have passed
Failed tests (3)Click to expand
Passed tests (42)Click to expand |
@flexsurfer I can't reproduce issue (https://github.com/status-im/security-reports/issues/7#issuecomment-506399457) anymore with iOS 12, Android 6.0.1, Android 8.1, Android 9 |
Signed-off-by: Andrey Shovkoplyas <[email protected]>
c6d525b
to
1475bb6
Compare
https://github.com/status-im/security-reports/issues/7