Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security #7 #8906

Merged
merged 1 commit into from
Sep 4, 2019
Merged

security #7 #8906

merged 1 commit into from
Sep 4, 2019

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Sep 4, 2019

@flexsurfer flexsurfer requested review from dmitryn and vitvly September 4, 2019 10:32
@flexsurfer flexsurfer requested a review from a team as a code owner September 4, 2019 10:32
@flexsurfer flexsurfer self-assigned this Sep 4, 2019
@auto-assign auto-assign bot removed the request for review from a team September 4, 2019 10:32
@ghost
Copy link

ghost commented Sep 4, 2019

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

Copy link
Contributor

@vitvly vitvly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have access to security-reports repo. Why do we need to delay calls to navigation-state-changed?

@status-im-auto
Copy link
Member

status-im-auto commented Sep 4, 2019

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c6d525b #1 2019-09-04 10:43:55 ~11 min android-e2e 📦 apk
✔️ c6d525b #1 2019-09-04 10:44:12 ~11 min ios 📦 ipa
✔️ c6d525b #1 2019-09-04 10:45:29 ~12 min android 📦 apk

@flexsurfer
Copy link
Member Author

to fix #7 )
setInterval(location.assign("https://www.hackerone.com") 5);

@vitvly
Copy link
Contributor

vitvly commented Sep 4, 2019

@flexsurfer oh, ok :)


(defn debounce [event]
(when @timeout (js/clearTimeout @timeout))
(reset! timeout (js/setTimeout #(re-frame/dispatch event) 500)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it turns every timeout into a 500ms timeout?

@Serhy Serhy self-assigned this Sep 4, 2019
@statustestbot
Copy link

93% of end-end tests have passed

Total executed tests: 45
Failed tests: 3
Passed tests: 42

Failed tests (3)

Click to expand
1. test_add_account_to_multiaccount_instance

Device 1: Tap on AddAccountButton
Device 1: Tap on AddAnAccountButton

Device 1: 'GenerateNewAccountButton' is not found on the screen

Device sessions

2. test_backup_recovery_phrase

Device 1: Tap on OkContinueButton
Device 1: Tap on NextButton

2

Device sessions

3. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for BackupRecoveryPhrase
Device 1: Wait for BackupRecoveryPhrase

Device 1: 'BackupRecoveryPhrase' is not found on the screen

Device sessions

Passed tests (42)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message
Device sessions

13. test_unread_messages_counter_1_1_chat
Device sessions

14. test_logcat_send_transaction_from_daap
Device sessions

15. test_send_message_in_group_chat
Device sessions

16. test_logcat_send_transaction_from_wallet
Device sessions

17. test_send_token_with_7_decimals
Device sessions

18. test_offline_messaging_1_1_chat
Device sessions

19. test_modify_transaction_fee_values
Device sessions

20. test_send_eth_from_wallet_to_address
Device sessions

21. test_manage_assets
Device sessions

22. test_long_press_to_delete_public_chat
Device sessions

23. test_send_emoji
Device sessions

24. test_search_chat_on_home
Device sessions

25. test_logcat_recovering_account
Device sessions

26. test_can_add_existing_ens
Device sessions

27. test_messaging_in_different_networks
Device sessions

28. test_logcat_sign_message_from_daap
Device sessions

29. test_switch_users_and_add_new_account
Device sessions

30. test_send_stt_from_wallet
Device sessions

31. test_login_with_new_account
Device sessions

32. test_start_chat_with_ens
Device sessions

33. test_add_contact_from_public_chat
Device sessions

34. test_send_two_transactions_one_after_another_in_dapp
Device sessions

35. test_password_in_logcat_creating_account
Device sessions

36. test_offline_status
Device sessions

37. test_open_google_com_via_open_dapp
Device sessions

38. test_unread_messages_counter_public_chat
Device sessions

39. test_sign_message_from_daap
Device sessions

40. test_user_can_remove_profile_picture
Device sessions

41. test_share_contact_code_and_wallet_address
Device sessions

42. test_refresh_button_browsing_app_webview
Device sessions

@Serhy
Copy link
Contributor

Serhy commented Sep 4, 2019

@flexsurfer I can't reproduce issue (https://github.com/status-im/security-reports/issues/7#issuecomment-506399457) anymore with iOS 12, Android 6.0.1, Android 8.1, Android 9
Can use DApps as before (buy and sell cryptokitty, transactions in SimpleDapp)

Signed-off-by: Andrey Shovkoplyas <[email protected]>
@flexsurfer flexsurfer merged commit 1475bb6 into develop Sep 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the bug/security-7 branch September 4, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants