Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing random capitalization #9149

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Fixing random capitalization #9149

merged 1 commit into from
Oct 9, 2019

Conversation

rachelhamlin
Copy link
Contributor

@rachelhamlin rachelhamlin commented Oct 9, 2019 •
edited by flexsurfer
Loading

"Manage Assets" to "Manage assets"
"Enter Seed phrase" to "Enter seed phrase"

@rachelhamlin rachelhamlin requested a review from a team as a code owner October 9, 2019 15:37
@auto-assign auto-assign bot removed the request for review from a team October 9, 2019 15:37
@ghost
Copy link

ghost commented Oct 9, 2019

Hey @rachelhamlin, and thank you so much for making your first pull request in status-react! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

@ghost
Copy link

ghost commented Oct 9, 2019

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@rachelhamlin @flexsurfer
Fixing random capitalization
0d8d0af 
"Manage Assets" to "Manage assets"
"Enter Seed phrase" to "Enter seed phrase"

Signed-off-by: Andrey Shovkoplyas <[email protected]>
@flexsurfer flexsurfer merged commit 0d8d0af into develop Oct 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-random-caps branch October 9, 2019 15:43
@rachelhamlin rachelhamlin mentioned this pull request Oct 9, 2019
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Oct 9, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 07847c6 #1 2019-10-09 15:48:44 ~11 min ios 📦ipa 📲
✔️ 07847c6 #1 2019-10-09 15:50:00 ~12 min linux 📦App
✔️ 07847c6 #1 2019-10-09 15:50:54 ~13 min android-e2e 📦apk 📲
✔️ 07847c6 #1 2019-10-09 15:50:57 ~13 min windows 📦exe
✔️ 07847c6 #1 2019-10-09 15:50:58 ~13 min android 📦apk 📲
✔️ 07847c6 #1 2019-10-09 15:51:07 ~13 min macos 📦dmg

@weekly-digest weekly-digest bot mentioned this pull request Oct 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rachelhamlin @status-im-auto @flexsurfer