Add new welcome page after generating their key #9170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @elegant651, and thank you so much for making your first pull request in status-react! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2 |
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (63)
|
|
thanks @elegant651 , there is a lint error ,could you please run |
|
@elegant651 could you please rebase onto develop , thanks |
elegant651
force-pushed
the
feature/welcome-screens-8135
branch
from
0014fe3 to
9beb519
Compare
|
@elegant651 is it still wip? could you add a screenshot of welcome chats screen if it's ready, thanks! @errorists could you take a look? |
on ready. I already attached it on the top. |
|
sorry @elegant651 can see only one screenshot, and can't see this one |
ah, I missed this. there's only welcome screen. Will implement on it. |
elegant651
force-pushed
the
feature/welcome-screens-8135
branch
from
9beb519 to
4bd8ee0
Compare
|
@flexsurfer Finished it, can you please check for test? |
|
@elegant651 Awesome. Andrey is out on vacay for a bit - maybe @yenda or @siphiuel can review? |
errorists
approved these changes
Nov 13, 2019
flexsurfer
reviewed
Nov 13, 2019
| (handlers/register-handler-fx | ||
| :multiaccounts.ui/hide-home-tooltip | ||
| (fn [cofx _] | ||
| (multiaccounts/confirm-home-tooltip cofx))) |
There was a problem hiding this comment.
why not use multiaccounts.update/multiaccount-update directly here?
There was a problem hiding this comment.
yenda commented that it should follow 'wallet-set-up-passed?'. : #9170 (comment)
| @@ -88,33 +88,49 @@ | |||
|
|
|||
2% of end-end tests have passedFailed tests (99)Click to expand
Passed tests (2)Click to expand
|
elegant651
force-pushed
the
feature/welcome-screens-8135
branch
from
121e094 to
8cd6de4
Compare
Merged
|
@elegant651 thank you for the contribution, amazing work!
I'm not able to check keycard flows here today, @Serhy can you assist please? |
96% of end-end tests have passedFailed tests (4)Click to expand
Passed tests (97)Click to expand |
100% of end-end tests have passedPassed tests (2)Click to expand
|
|
Merge with #9448 |
|
With the keycard flow I don't see 'Welcome to Status' screen (with Creating new account flow with keycard:
When recover account from key stored on keycard the flow is:
@elegant651 could you please insert navigation to welcome screen after each of last steps in above two flows for keycard? |
elegant651
force-pushed
the
feature/welcome-screens-8135
branch
from
8cd6de4 to
eba9b9f
Compare
I fixed for these issue, pls check it out. |
100% of end-end tests have passedPassed tests (2)Click to expand
|
|
@elegant651 |
flexsurfer
force-pushed
the
feature/welcome-screens-8135
branch
from
eba9b9f to
5b9b13d
Compare
flexsurfer
approved these changes
Nov 18, 2019
formatting to style add accessibility-id & flow for keycard Signed-off-by: Andrey Shovkoplyas <[email protected]>
flexsurfer
force-pushed
the
feature/welcome-screens-8135
branch
from
5b9b13d to
7b14bbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8135
(related with #9054 )
Summary
Add new welcome page after they generate their key.
Review notes
Testing notes
Tested on Nexus5X, Pixel2,3
Functional
Steps to test
status: wip