Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlapping on some screens (onboarding, wallet - English, Galaxy S7) #9233

Closed
churik opened this issue Oct 17, 2019 · 5 comments · Fixed by #9271
Closed

Overlapping on some screens (onboarding, wallet - English, Galaxy S7) #9233

churik opened this issue Oct 17, 2019 · 5 comments · Fixed by #9271

Comments

@churik
Copy link
Member

churik commented Oct 17, 2019 •
edited by StatusWrike
Loading

Bug Report

It is very visible and in happy-path flow, so should be fixed in v1 IMO.

Problem

On "Send Transaction" screen:
App Live Dashboard 2019-10-17 13-54-43

On "Select key storage" (during onboarding):
s7_overlap

Additional Information

  • Status version: nightly 17/10/2019
  • Operating System: Android (small screens)
    For me reproducible on Samsung Galaxy S7 (5,5'')
@churik churik changed the title Overlapping on some screens (onboarding, wallet, English, Galaxy S7) Overlapping on some screens (onboarding, wallet - English, Galaxy S7) Oct 17, 2019
@weekly-digest weekly-digest bot mentioned this issue Oct 20, 2019
Closed
@StatusSceptre
Copy link
Member

@churik can I combine with this issue? #7990

I'll add more DAI to the bounty if so.

@StatusSceptre
Copy link
Member

This is a handy benchmark when thinking about the importance of these two issues - the Samsung Galaxy J7 has popularity under 2% compared to other screen sizes. (Data from Statcounter)

@rasom rasom self-assigned this Oct 23, 2019
@rasom
Copy link
Contributor

rasom commented Oct 23, 2019

I can't find any Figma screens for the first case, would it be fine with a multiline text

@churik
Copy link
Member Author

churik commented Oct 23, 2019

@rasom that's because the whole flow should be fully redesigned according to https://www.figma.com/file/XUehMnhyD1FGcWzvGz6SXqvh/Wallet - but I believe it is out of scope for v1 release.
So seems fine to me for now.

@rasom
Copy link
Contributor

rasom commented Oct 23, 2019

@churik ok thanks

rasom added a commit that referenced this issue Oct 23, 2019
@rasom
[#9233] fix overlapping on some screens
48e632b
rasom added a commit that referenced this issue Oct 24, 2019
@rasom
[#9233] fix overlapping on some screens
85d689d
rasom added a commit that referenced this issue Oct 25, 2019
@rasom
[#9233, #9173] fix some screens
6ba373a
@rasom rasom mentioned this issue Oct 25, 2019
Merged
rasom added a commit that referenced this issue Oct 27, 2019
@rasom
[#9233, #9173] fix some screens
b278970
rasom added a commit that referenced this issue Oct 29, 2019
@rasom
[#9233, #9173] fix some screens
f1e45d3
yenda pushed a commit that referenced this issue Oct 30, 2019
@rasom
[#9233, #9173] fix some screens
e80b08c 
Signed-off-by: yenda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#9233, #9173] fix overlapping on some screens status-im/status-mobile
3 participants
@rasom @churik @StatusSceptre