Weekly Digest (13 October, 2019 - 20 October, 2019)

[weekly-digest]

Here's the Weekly Digest for status-im/status-react:

---

ISSUES

Last week 54 issues were created.
Of these, 25 issues have been closed and 29 issues are still open.

OPEN ISSUES

💚 #9240 Fixes #9238, by acolytec3
💚 #9238 EIP681 does not support ENS_NAME , by 3esmit
💚 #9237 New e2e tests and fix, by Serhy
💚 #9236 [WIP] [#9037] Error states for new Tx overview: contract & network fees, by flexsurfer
💚 #9235 Amount and Network Fee text overlap in 'Sending' screen when there are long values , by Serhy
💚 #9234 "Remove current photo" is shown for new account and profile info is duplicated in header after any change, by churik
💚 #9233 Overlapping on some screens (onboarding, wallet - English, Galaxy S7), by churik
💚 #9231 Recover a key from seed on keycard: a password is asked to the user (it should not), by guylouis
💚 #9230 [DEBUG] disable signals, by cammellos
💚 #9229 Add a 'reset keycard' feature , by guylouis
💚 #9228 Add an unpairing keycard feature , by guylouis
💚 #9227 Remove keycard unpairing for v1 , by guylouis
💚 #9226 Styling + add date seed phrase backed up, by hesterbruikman
💚 #9225 No filter for transaction history, by churik
💚 #9224 Implement designs for sign in screens, by churik
💚 #9222 NFC tapping user experience, by andmironov
💚 #9220 Comment away message.new signal, by siphiuel
💚 #9217 Network fee values fetching takes >1 min, by Serhy
💚 #9216 Use eth.staging as a default fleet for development and nightlies, by adambabik
💚 #9214 Unpairing card doesn't warn user about consequences and there is no automatic logout after unpairing, by churik
💚 #9213 ENS addr is checked instead of owner, by yenda
💚 #9212 MacOS app build lacking "notarization", by jakubgs
💚 #9210 Send transaction page text testnet warning message runs off screen, by acolytec3
💚 #9206 Endless processing spinner after entering wrong PIN when signing message from DApp, by churik
💚 #9205 "Resend" option doesn't resend message on Android, by churik
💚 #9203 No transaction history when address has a lot (100+) of transactions, by Serhy
💚 #9201 A few bugs from the recovery flow (Keycard and seed phrase), by andmironov
💚 #9200 Several Keycard issues while trying to recover an account, by andmironov
💚 #9195 Bump @react-native-community/netinfo from 4.2.2 to 4.4.0 in /mobile/js_files, by dependabot-preview[bot]

CLOSED ISSUES

❤️ #9239 e2e - switching accounts in DApp, by churik
❤️ #9232 fix failing TestFlight clean job, by jakubgs
❤️ #9223 resolve ENS in wallet, by churik
❤️ #9221 Disable spinner when generating multiaccount, by cammellos
❤️ #9219 desktop builds need GnuPG, also s3cmd, by jakubgs
❤️ #9218 add info about MacOS Catalina workaround, by jakubgs
❤️ #9215 [#8940] Redesign Back, swipe-to-the-left and hardware device Back but…, by flexsurfer
❤️ #9211 Fixed several case ids and add test for checking log_level and fleet, by churik
❤️ #9209 Fix #8960, by acolytec3
❤️ #9208 fix navigation reset, by yenda
❤️ #9207 Filter for security updates only in Dependabot, by PombeirP
❤️ #9204 drop les, by flexsurfer
❤️ #9202 Small fix to e2e: deleting dapps, by churik
❤️ #9199 Bump react-native-screens from 1.0.0-alpha.22 to 2.0.0-alpha.4 in /mobile/js_files, by dependabot-preview[bot]
❤️ #9198 Bump web3-utils from 1.0.0-beta.36 to 1.2.1 in /desktop/js_files, by dependabot-preview[bot]
❤️ #9197 Bump events from 1.1.1 to 3.0.0 in /desktop/js_files, by dependabot-preview[bot]
❤️ #9196 Bump react-native-fetch-polyfill from 1.1.2 to 1.1.3 in /desktop/js_files, by dependabot-preview[bot]
❤️ #9194 Bump metro from 0.48.5 to 0.56.0 in /desktop/js_files, by dependabot-preview[bot]
❤️ #9193 Bump react-native-mail from v4.0.0-status to v4.0.0 in /mobile/js_files, by dependabot-preview[bot]
❤️ #9192 Bump @babel/generator from 7.0.0 to 7.6.4 in /mobile/js_files, by dependabot-preview[bot]
❤️ #9191 Bump status-conan from v1.0.0 to v1.0.1 in /desktop/js_files, by dependabot-preview[bot]
❤️ #9190 Bump metro-react-native-babel-preset from 0.45.6 to 0.56.0 in /desktop/js_files, by dependabot-preview[bot]
❤️ #9189 Bump react-native-dialogs from 1.0.4 to 1.1.0 in /mobile/js_files, by dependabot-preview[bot]
❤️ #9188 Bump react-native from 0.60.5 to 0.60.6 in /mobile/js_files, by dependabot-preview[bot]
❤️ #9187 Bump react-dom from 16.4.2 to 16.10.2 in /mobile/js_files, by dependabot-preview[bot]

LIKED ISSUE

👍 #9222 NFC tapping user experience, by andmironov
It received 👍 x2, 😄 x0, 🎉 x0 and ❤️ x0.

NOISY ISSUE

🔈 #9195 Bump @react-native-community/netinfo from 4.2.2 to 4.4.0 in /mobile/js_files, by dependabot-preview[bot]
It received 10 comments.

---

PULL REQUESTS

Last week, 26 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 8 pull requests were updated.
💛 #9237 New e2e tests and fix, by Serhy
💛 #9236 [WIP] [#9037] Error states for new Tx overview: contract & network fees, by flexsurfer
💛 #9230 [DEBUG] disable signals, by cammellos
💛 #9220 Comment away message.new signal, by siphiuel
💛 #9195 Bump @react-native-community/netinfo from 4.2.2 to 4.4.0 in /mobile/js_files, by dependabot-preview[bot]
💛 #9178 Verify ENS names, by cammellos
💛 #9157 FIxes #8951, by acolytec3
💛 #9086 keycard pin screen fixes, by dmitryn

MERGED PULL REQUEST

Last week, 18 pull requests were merged.
💜 #9239 e2e - switching accounts in DApp, by churik
💜 #9223 resolve ENS in wallet, by churik
💜 #9221 Disable spinner when generating multiaccount, by cammellos
💜 #9219 desktop builds need GnuPG, also s3cmd, by jakubgs
💜 #9218 add info about MacOS Catalina workaround, by jakubgs
💜 #9215 [#8940] Redesign Back, swipe-to-the-left and hardware device Back but…, by flexsurfer
💜 #9211 Fixed several case ids and add test for checking log_level and fleet, by churik
💜 #9209 Fix #8960, by acolytec3
💜 #9208 fix navigation reset, by yenda
💜 #9207 Filter for security updates only in Dependabot, by PombeirP
💜 #9204 drop les, by flexsurfer
💜 #9202 Small fix to e2e: deleting dapps, by churik
💜 #9182 [fix 8853] fix change of whisper id in ens registration, by yenda
💜 #9172 Upgrade xcode version to 11.1, by PombeirP
💜 #9171 Enable high priority tests in PRs, by Serhy
💜 #9158 [#8446] [Multi-Account] Build account settings for individual wallet, by flexsurfer
💜 #9150 Clean /tmp and $TMPDIR in make clean, by siphiuel
💜 #9137 Bumps galore, by jakubgs

---

COMMITS

Last week there were 19 commits.
🛠️ [#8940] Redesign Back, swipe-to-the-left and hardware device Back buttons to align the behavior Signed-off-by: Andrey Shovkoplyas [email protected] by flexsurfer
🛠️ e2e about switching accounts in DApp Signed-off-by: Churikova Tetiana [email protected] by churik
🛠️ [#8446] [Multi-Account] Build account settings for individual wallet Signed-off-by: Andrey Shovkoplyas [email protected] by flexsurfer
🛠️ fix type of shell used for s3cmd uploads Signed-off-by: Jakub Sokołowski [email protected] by jakubgs
🛠️ customize TMPDIR and clean it Also: - parallelize upload and achive stages - fix s3cmd uploads for combined Jenkinsfile - fix failing TestFlight clean job Signed-off-by: Jakub Sokołowski [email protected] by siphiuel
🛠️ combined node package upgrade prs Signed-off-by: Jakub Sokołowski [email protected] by jakubgs
🛠️ Filter for security updates only in Dependabot Signed-off-by: Jakub Sokołowski [email protected] by PombeirP
🛠️ desktop builds need GnuPG Signed-off-by: Jakub Sokołowski [email protected] by jakubgs
🛠️ [fix 8853] fix change of whisper id in ens registration A user can type in their existing name in the registration flow. Status can confirm if they own it. After signing a transaction, the user can update the Whisper ID to their new one. Instead of using a hardcoded contract for stateofus, the standard owner method is called to find the resolver contract of a ens name. This allows users to set the pubkey even for ens names that are not subdomains of stateofus Signed-off-by: yenda [email protected] by yenda
🛠️ resolve ENS in wallet Signed-off-by: Churikova Tetiana [email protected] by churik
🛠️ fix navigation reset currently navigation-reset only works properly if you reset to a simple route this fix allows us to use navigation reset with more complex routes, by ensuring that the navigation stack is populated properly so that navigate back doesn't end up emptying the stack. this is temporary as the proper way to do navigation in general would be to get rid of view id and navigation-stack entirely, since it is a duplication of the state of react-navigation Signed-off-by: yenda [email protected] by yenda
🛠️ Disable spinner when generating multiaccount Signed-off-by: Andrea Maria Piana [email protected] by cammellos
🛠️ add info about MacOS Catalina workaround Signed-off-by: Jakub Sokołowski [email protected] by jakubgs
🛠️ nix: Upgrade expected Xcode version to 11.1 Also: - nix: Disable symlink store check - Add comments to dependabot config file Signed-off-by: Jakub Sokołowski [email protected] by PombeirP
🛠️ drop les Signed-off-by: Andrey Shovkoplyas [email protected] by flexsurfer
🛠️ Point network to correct current-network Signed-off-by: Andrey Shovkoplyas [email protected] by acolytec3
🛠️ fix some testrail links and add new test for checking log_level and fleet Signed-off-by: Churikova Tetiana [email protected] by churik
🛠️ fix deleteing dapps Signed-off-by: Churikova Tetiana [email protected] by churik
🛠️ Enable high priority tests in PRs Also: - add ci/tests/Jenkinsfile.e2e-prs - remove maybe_later_button click after new onboarding - update job name for e2e tests - Fix testrail checklist creationg for nightly builds Signed-off-by: Jakub Sokołowski [email protected] by Serhy

---

CONTRIBUTORS

Last week there were 9 contributors.
👤 flexsurfer
👤 churik
👤 jakubgs
👤 siphiuel
👤 PombeirP
👤 yenda
👤 cammellos
👤 acolytec3
👤 Serhy

---

STARGAZERS

Last week there were 3 stagazers.
⭐ sindyyo
⭐ jimmykimani
⭐ cavb
You all are the stars! 🌟

---

RELEASES

Last week there were no releases.

---

That's all for last week, please 👀 Watch and ⭐ Star the repository status-im/status-react to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆