Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add store nodes from shards.test fleet #529

Merged
merged 12 commits into from
Mar 14, 2024
Merged

add store nodes from shards.test fleet #529

merged 12 commits into from
Mar 14, 2024

Conversation

felicio
Copy link
Collaborator

@felicio felicio commented Mar 13, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 640b988

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@status-im/js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 13, 2024

@felicio is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@felicio felicio linked an issue Mar 13, 2024 that may be closed by this pull request
Connect to shards.test #520
Closed
5 tasks
@felicio felicio changed the title draft: add store nodes from shard.test fleet add store nodes from shard.test fleet Mar 13, 2024
@felicio felicio requested review from a team, jkbktl, prichodko and marcelines March 13, 2024 09:23
marcelines
marcelines approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@marcelines marcelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM regarding context and knowledge that i have with this but i left a few notes.

packages/status-js/src/client/chat.ts Show resolved Hide resolved
packages/status-js/src/client/client.ts Show resolved Hide resolved
packages/status-js/src/request-client/request-client.ts Show resolved Hide resolved
@felicio felicio merged commit 9adaeb6 into status-im:main Mar 14, 2024
2 of 4 checks passed
@felicio felicio changed the title add store nodes from shard.test fleet add store nodes from shards.test fleet Mar 14, 2024
@felicio felicio mentioned this pull request Mar 14, 2024
Merged
@felicio felicio self-assigned this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelines marcelines marcelines approved these changes

@jkbktl jkbktl jkbktl approved these changes

@prichodko prichodko prichodko approved these changes

Assignees

@felicio felicio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect to shards.test
4 participants
@felicio @jkbktl @prichodko @marcelines