Create proxy instance for each request

[johannbrynjar]

Global proxy instance make memory leak. So I would like to create proxy for each request.

Every request init proxy so each request add new events:

next-http-proxy-middleware/src/index.ts

Line 65 in 2453215

onProxyInit(proxy);

Also here for each request the code add new event listener:

next-http-proxy-middleware/src/index.ts

Line 89 in 2453215

.once("error", reject)

I think this issue #25 is related to this pull request.

[stegano]

Hi @johannbrynjar

Thanks for your PR

I understood the memory leak you are talking about.
(An event handler is bound for each request, but the binding is maintained if no event (resolve or error) occurs)

However, even after this PR is merged, each instance bound to the event is still in memory, so memory leak is likely.

Let's find another way to solve this memory leak problem.
Please let me know if I'm wrong.

[stegano]

@all-contributors please add @johannbrynjar for bug

[allcontributors]

@stegano

I've put up a pull request to add @johannbrynjar! 🎉

[stegano]

@johannbrynjar
I just released v1.2.3 version that fixed the memory leak problem.
I wouldn't have found this problem without you.
Thank you. 😀

[stegano]

Hi @johannbrynjar

Thanks for your PR

I understand the memory leak you are talking about. (An event handler is bound for each request, but the binding is maintained if no event (resolve or error) occurs)

However, even after this PR is merged, each instance bound to the event is still in memory, so memory leak is likely.

Let's find another way to solve this memory leak problem. Please let me know if I'm wrong.

There was a mistake. Your PR seems fine. Even if the event is bound to the instance, it will be removed from memory by GC when the scope is closed.

• https://developer.mozilla.org/en-US/docs/Web/JavaScript/Memory_Management#mark-and-sweep_algorithm

[stegano]

@all-contributors please add @johannbrynjar for code

[allcontributors]

@stegano

I've put up a pull request to add @johannbrynjar! 🎉