This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
sdk: run integration tests in ci in a simpler way #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change the CI integration test run to use the
-p
flag to limit the number of package tests that run at same time, instead of using a for loop to manually run the package tests one at a time.Why
By default Go runs each packages tests in parallel which causes the logs not to stream which is why we for loop over the packages and run them one by one. Turns out we don't need to bash script it, we can just tell Go to run one package at a time and we'll get the logs streamed.
Dealing with the logs not streaming was a learning for me with Go, so I opened an issue about this on the Go repo (golang/go#46959) because this seems like something that isn't well documented about the go test toolchain.