Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

sdk: run integration tests in ci in a simpler way #119

Merged
merged 4 commits into from
Jun 28, 2021
Merged

Conversation

leighmcculloch
Copy link
Contributor

What

Change the CI integration test run to use the -p flag to limit the number of package tests that run at same time, instead of using a for loop to manually run the package tests one at a time.

Why

By default Go runs each packages tests in parallel which causes the logs not to stream which is why we for loop over the packages and run them one by one. Turns out we don't need to bash script it, we can just tell Go to run one package at a time and we'll get the logs streamed.

Dealing with the logs not streaming was a learning for me with Go, so I opened an issue about this on the Go repo (golang/go#46959) because this seems like something that isn't well documented about the go test toolchain.

@leighmcculloch leighmcculloch marked this pull request as ready for review June 28, 2021 21:20
Copy link
Contributor

@acharb acharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants