Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txnbuild: add deprecate warning to default fee #1443

Merged
merged 6 commits into from
Jun 25, 2019
Merged

txnbuild: add deprecate warning to default fee #1443

merged 6 commits into from
Jun 25, 2019

Conversation

poliha
Copy link
Contributor

@poliha poliha commented Jun 21, 2019

This PR does the following

  • Adds a warning that Transaction.SetDefaultFee is deprecated and will be removed.
  • Adds an example showing how to set Transaction.BaseFee by querying horizon for fee stats.
  • Add an unexported method Transaction.setTransactionFee for setting the transaction fee.
  • Validates accountID before building a transaction

closes #1221

@poliha poliha requested review from ire-and-curses and bartekn June 21, 2019 17:56
@poliha poliha added the txnbuild 2nd-generation transaction build library for Go SDK label Jun 21, 2019
@poliha poliha added this to the horizonclient 1.3.0 milestone Jun 21, 2019
ire-and-curses
ire-and-curses requested changes Jun 21, 2019
View reviewed changes
Copy link
Member

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new checks! Just a few quick things to fix.

txnbuild/example_test.go Outdated Show resolved Hide resolved
txnbuild/transaction.go Show resolved Hide resolved
txnbuild/transaction.go Outdated Show resolved Hide resolved
txnbuild/transaction.go Outdated Show resolved Hide resolved
txnbuild/transaction.go Outdated Show resolved Hide resolved
@Nattakanbar

This comment was marked as spam.

Sign in to view
1 similar comment
@Nattakanbar

This comment was marked as spam.

Sign in to view
@poliha poliha requested a review from ire-and-curses June 24, 2019 16:54
ire-and-curses
ire-and-curses approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks close! Just one comment, feel free to implement as you think is best.

txnbuild/transaction.go Outdated Show resolved Hide resolved
txnbuild/transaction.go Show resolved Hide resolved
@poliha poliha merged commit 4b68069 into release-horizonclient-v1.3.0 Jun 25, 2019
@poliha poliha deleted the txnbuild-default-fee branch June 25, 2019 12:39
@poliha poliha mentioned this pull request Jun 26, 2019
Closed
@bartekn bartekn mentioned this pull request Jun 26, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ire-and-curses ire-and-curses ire-and-curses approved these changes

@bartekn bartekn Awaiting requested review from bartekn

Assignees
No one assigned
Labels
txnbuild 2nd-generation transaction build library for Go SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@poliha @Nattakanbar @bartekn @ire-and-curses