Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/horizon: history archive url + accounts for signer feature flag #1490

Merged
merged 4 commits into from
Jul 10, 2019
Merged

services/horizon: history archive url + accounts for signer feature flag #1490

merged 4 commits into from
Jul 10, 2019

Conversation

ire-and-curses
Copy link
Contributor

PR Checklist

PR Structure

  • [x ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • [x ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • [x ] This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • [x ] I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

Summary

This PR adds two new flags to support the accounts for signer MVP. history-archive-url specifies the history archive to use. enable-accounts-for-signer adds a feature flag for the new feature. Closes #1484 and #1487.

Goal and scope

Two flags added. They are currently unused.

This was suspiciously quick and easy. Let me know if I misunderstood anything with the requirements.

@ire-and-curses ire-and-curses requested review from bartekn and tamirms July 8, 2019 22:24
bartekn
bartekn approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@bartekn bartekn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe we should set default value of history-archive-url to SDF history archives? Also, this should be merged into release branch (going to create it when 0.18.1 is released - today).

@bartekn bartekn changed the base branch from master to release-horizon-v0.19.0 July 10, 2019 12:20
bartekn
bartekn approved these changes Jul 10, 2019
View reviewed changes
services/horizon/cmd/root.go Outdated
ConfigKey: &config.HistoryArchiveURLs,
OptType: types.String,
Required: false,
FlagDefault: "http://history.stellar.org/prd/core-live/core_live_001/,http://history.stellar.org/prd/core-live/core_live_002/,http://history.stellar.org/prd/core-live/core_live_003/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use HTTPS URLs.

@bartekn
Copy link
Contributor

bartekn commented Jul 10, 2019

Base changed to release-horizon-v0.19.0.

@ire-and-curses ire-and-curses merged commit 3ffe179 into stellar:release-horizon-v0.19.0 Jul 10, 2019
@ire-and-curses ire-and-curses deleted the es-1484-ha_url branch July 10, 2019 16:14
@bartekn bartekn mentioned this pull request Jul 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartekn bartekn bartekn approved these changes

@tamirms tamirms tamirms approved these changes

Assignees
No one assigned
Labels
horizon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ire-and-curses @bartekn @tamirms