Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txnbuild: add AddSignatureBase64 function #2586

Merged
merged 3 commits into from
May 13, 2020

Conversation

howardtw
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This PR adds AddSignatureBase64 function to both Transaction object and FeeBumpTransaction object.

Why

In JS SDK, there is addSignature function to add a base64 signature to a transaction. However, there is nothing like this in Go SDK.

In SEP 30, the response of the sign endpoint contains a signature in base64. It would be helpful if there is a function in txnbuild that adds a signature in base64 to the transaction.

Known limitations

N/A

Close #2440

@cla-bot cla-bot bot added the cla: yes label May 12, 2020
@howardtw howardtw merged commit 4392d16 into stellar:master May 13, 2020
Copy link
Member

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@howardtw Sorry, I saw this too late. Can you update the txnbuild changelog, unreleased section, to include this?

@howardtw
Copy link
Contributor Author

@ire-and-curses #2590

howardtw added a commit that referenced this pull request May 13, 2020
What
This PR amends #2586 to include the update to the changelog.

Why
Keep changelog updated.
@howardtw howardtw deleted the add-signature branch June 15, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

txnbuild: add function to add base64 signature
3 participants