Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txnbuild: Add support for new CAP-21 preconditions. #4303

Merged
merged 19 commits into from
Mar 25, 2022
Merged

txnbuild: Add support for new CAP-21 preconditions. #4303

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
16a6c44
Add first draft of new tx preconditions
Shaptic Mar 23, 2022
194b03b
Improve timebound precondition testing
Shaptic Mar 23, 2022
f52acac
Drop extra code, improve tests
Shaptic Mar 23, 2022
25ecc36
Add a way to compare timebounds
Shaptic Mar 23, 2022
918fc4c
Improve timebound check, more tests
Shaptic Mar 23, 2022
d3b9e88
Absolutely elite Golang coding
Shaptic Mar 23, 2022
59b6fc8
etc
Shaptic Mar 23, 2022
df7b4c2
Remove global variables from tests: isolate to each case
Shaptic Mar 24, 2022
468e7de
Breaking change: move TransactionParams.Timebounds
Shaptic Mar 24, 2022
cf15638
Add round-trip to ensure decoding from XDR works correctly
Shaptic Mar 24, 2022
f6ffe3f
Simplify validation, more tests
Shaptic Mar 24, 2022
1ff9f67
Clean up validation
Shaptic Mar 24, 2022
8de0e23
Drop Preconditions constructors
Shaptic Mar 24, 2022
84d44db
Properly unpack preconditions from transaction xdr
Shaptic Mar 24, 2022
a0306fc
Adds changelog entry
Shaptic Mar 24, 2022
757aa14
Code cleanup, use fixtures over cloning :+1:
Shaptic Mar 24, 2022
31aeb48
Rename Timebounds -> TimeBounds but keep type alias
Shaptic Mar 24, 2022
bd421aa
Rename Ledgerbounds -> LedgerBounds
Shaptic Mar 24, 2022
32e78f1
Uncomment type alias...?
Shaptic Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions txnbuild/timebounds.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@ func (tb *Timebounds) Validate() error {
return nil
}

func (tb *Timebounds) IsEmpty() bool {
return tb == nil || *tb == Timebounds{}
}

Shaptic marked this conversation as resolved.
Show resolved Hide resolved
// NewTimebounds is a factory method that constructs a Timebounds object from a min and max time.
// A Transaction cannot be built unless a Timebounds object is provided through a factory method.
func NewTimebounds(minTime, maxTime int64) Timebounds {
Expand Down
2 changes: 1 addition & 1 deletion txnbuild/transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,7 +827,7 @@ func NewTransaction(params TransactionParams) (*Transaction, error) {
// to introduce a breaking change by dropping
// `TransactionParams.Timebounds`, nor require users to set up the
// `AdditionalPreconditions`, we need to coalesce the two values here.
if !params.Timebounds.IsEmpty() {
if params.Timebounds != (Timebounds{}) {
err = params.AdditionalPreconditions.SetTimebounds(&params.Timebounds)
if err != nil {
return nil, errors.Wrap(err, "invalid timebounds")
Expand Down