Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocols/horizon: Change Account.Sequence to int64 #4438

Merged
merged 7 commits into from
Jun 24, 2022

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jun 24, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Change protocols/horizon/Account.Sequence to int64 from string.

Why

There shouldn't be any extra parsing required in Go since Account.Sequence returned by Horizon will be always a valid int64 value. We can make sure the value is rendered as a string to support JS using string tag.

Similar to: #4409

Known limitations

[TODO or N/A]

@bartekn bartekn requested a review from a team June 24, 2022 09:49
@bartekn bartekn merged commit 79683d8 into stellar:master Jun 24, 2022
@bartekn bartekn deleted the protocol-horizon-account-sequence branch June 24, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants