clients/stellarcore: Add support for Core's new /getledgerentry HTTP endpoint
#5542
+102
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
changed the title
/getledgerentry HTTP endpoint
Shaptic
force-pushed
the
p23-core-endpoints
branch
from
a126a16 to
4db05df
Compare
2opremio
approved these changes
Jan 24, 2025
|
Looks good! |
tamirms
reviewed
Jan 24, 2025
| @@ -250,6 +250,11 @@ func (c *Client) GetLedgerEntryRaw(ctx context.Context, ledgerSeq uint32, keys . | |||
| return resp, c.makeLedgerKeyRequest(ctx, &resp, "getledgerentryraw", ledgerSeq, keys...) | |||
| } | |||
|
|
|||
| func (c *Client) GetLedgerEntries(ctx context.Context, ledgerSeq uint32, keys ...xdr.LedgerKey) (*proto.GetLedgerEntryResponse, error) { | |||
| var resp *proto.GetLedgerEntryResponse | |||
There was a problem hiding this comment.
Suggested change
| var resp *proto.GetLedgerEntryResponse | |
| var resp proto.GetLedgerEntryResponse |
I think this should not be a pointer
sreuland
reviewed
Jan 24, 2025
| require.EqualValues(t, "live", resp.Entries[0].State) | ||
| require.EqualValues(t, "archived", resp.Entries[1].State) | ||
|
|
||
| key.Type = xdr.LedgerEntryTypeTtl |
There was a problem hiding this comment.
nice coverage on the not so happy path!
sreuland
approved these changes
Jan 24, 2025
SirTyson
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add support for Core's
/getledgerentryas implemented in CAP-66.Why
See #5426