Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop expiration workaround in lieu of new TTL in schema #168

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Drop expiration workaround in lieu of new TTL in schema #168

merged 3 commits into from
Nov 30, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Oct 26, 2023 •
edited
Loading

The response schema now includes liveUntilLedgerSeq by default, so we no longer need to inject the expiration ledgers into requests and parse that information.

(Note that this is targeting the stable branch.)

Closes this part of stellar/js-stellar-sdk#869.

@Shaptic Shaptic requested a review from sreuland October 26, 2023 16:49
@Shaptic Shaptic self-assigned this Oct 26, 2023
@Shaptic Shaptic added this to the Soroban Stable P20 Release milestone Oct 31, 2023
stellarsaur
stellarsaur approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@stellarsaur stellarsaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM

@Shaptic Shaptic merged commit 68fb5f4 into stable Nov 30, 2023
@Shaptic Shaptic deleted the drop-ttl-workaround branch November 30, 2023 21:24
@Shaptic Shaptic mentioned this pull request Nov 30, 2023
Merged
3 tasks
Shaptic added a commit that referenced this pull request Dec 6, 2023
@Shaptic
Prepare release w/ support for stable Protocol 20 and RPC. (#167)
4caf267 
* Update library to latest stellar-base
* Drop expiration workaround in lieu of new TTL in schema (#168)
* Upgrade minimum Node version to 18, add fixups for Node 20
* Update API in accordance with new RPC schemas (#173)
* Mark as stable version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellarsaur stellarsaur stellarsaur approved these changes

@sreuland sreuland Awaiting requested review from sreuland

Assignees

@Shaptic Shaptic

Labels
None yet
Projects
Platform Scrum
Status: Done
Milestone
Soroban Stable P20 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@Shaptic @stellarsaur