Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In manageBuyOffer operation, Can we set a parameter of source? #269

Closed
park2h83 opened this issue Sep 9, 2019 · 2 comments
Closed

In manageBuyOffer operation, Can we set a parameter of source? #269

park2h83 opened this issue Sep 9, 2019 · 2 comments
Labels

Comments

@park2h83
Copy link
Contributor

park2h83 commented Sep 9, 2019

Describe the bug
In manageBuyOffer operation, we can't set 'source' parameter.
However in api docs(https://stellar.github.io/js-stellar-sdk/Operation.html#.manageBuyOffer), it says we can set.

What version are you on?
stellar-sdk : 3.0.0

Additional context
In stellar-base > types > index.d.ts

interface BaseOptions {
source?: string;
}

interface CreatePassiveSellOffer extends BaseOptions {
selling: Asset;
buying: Asset;
amount: string;
price: number | string | object /* bignumber.js */;
}

interface ManageSellOffer extends CreatePassiveSellOffer {
offerId?: number | string;
}

In this interface, there is no 'source' parameter.

interface ManageBuyOffer {
selling: Asset;
buying: Asset;
buyAmount: string;
price: number | string | object /* bignumber.js */;
offerId?: number | string;
}

@park2h83 park2h83 added the bug label Sep 9, 2019
NovichikhinAlexey added a commit to NovichikhinAlexey/js-stellar-base that referenced this issue Sep 9, 2019
Fix issue stellar#269. ManageBuyOffer should extend BaseOptions and inherited property "source"
stellar#269
@NovichikhinAlexey
Copy link
Contributor

Look like error here:
https://github.com/stellar/js-stellar-base/pull/270/files

Guys please check this and update library asap if this is right and if it possible

abuiles pushed a commit that referenced this issue Sep 9, 2019
Fix issue #269. ManageBuyOffer should extend BaseOptions and inherited property "source"
#269
@abuiles abuiles mentioned this issue Sep 9, 2019
@abuiles
Copy link
Contributor

abuiles commented Sep 9, 2019

@NovichikhinAlexey thanks for the PR! I just released [email protected] which should address this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants