We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug In manageBuyOffer operation, we can't set 'source' parameter. However in api docs(https://stellar.github.io/js-stellar-sdk/Operation.html#.manageBuyOffer), it says we can set.
What version are you on? stellar-sdk : 3.0.0
Additional context In stellar-base > types > index.d.ts
interface BaseOptions { source?: string; }
interface CreatePassiveSellOffer extends BaseOptions { selling: Asset; buying: Asset; amount: string; price: number | string | object /* bignumber.js */; }
interface ManageSellOffer extends CreatePassiveSellOffer { offerId?: number | string; }
In this interface, there is no 'source' parameter.
interface ManageBuyOffer { selling: Asset; buying: Asset; buyAmount: string; price: number | string | object /* bignumber.js */; offerId?: number | string; }
The text was updated successfully, but these errors were encountered:
Update index.d.ts
be3a46b
Fix issue stellar#269. ManageBuyOffer should extend BaseOptions and inherited property "source" stellar#269
Look like error here: https://github.com/stellar/js-stellar-base/pull/270/files
Guys please check this and update library asap if this is right and if it possible
Sorry, something went wrong.
Update index.d.ts (#270)
601f738
Fix issue #269. ManageBuyOffer should extend BaseOptions and inherited property "source" #269
@NovichikhinAlexey thanks for the PR! I just released [email protected] which should address this issue
No branches or pull requests
Describe the bug
In manageBuyOffer operation, we can't set 'source' parameter.
However in api docs(https://stellar.github.io/js-stellar-sdk/Operation.html#.manageBuyOffer), it says we can set.
What version are you on?
stellar-sdk : 3.0.0
Additional context
In stellar-base > types > index.d.ts
interface BaseOptions {
source?: string;
}
interface CreatePassiveSellOffer extends BaseOptions {
selling: Asset;
buying: Asset;
amount: string;
price: number | string | object /* bignumber.js */;
}
interface ManageSellOffer extends CreatePassiveSellOffer {
offerId?: number | string;
}
In this interface, there is no 'source' parameter.
interface ManageBuyOffer {
selling: Asset;
buying: Asset;
buyAmount: string;
price: number | string | object /* bignumber.js */;
offerId?: number | string;
}
The text was updated successfully, but these errors were encountered: