Extend StrKey to handle xdr.MuxedAccount #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
reviewed
Apr 17, 2020
tamirms
approved these changes
Apr 17, 2020
abuiles
added a commit
that referenced
this pull request
Apr 20, 2020
* Extend decodeMuxedAccount to support ed25519 or muxed ed25519. * Remove unnecessary helper and fix tests. * Remove unused import. * Move _source and _feeSource back to constructor.
This was referenced Apr 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation was not compatible with an
xdr.MuxedAccountbut rather themuxedEd25119discriminant.This PR:
encodeMuxedAccountto handle the raw data forxdr.MuxedAccount, it can return aG..orM...account.decodeMuxedAccountto handleG..orM..accounts, the result can be used to create a validxdr.MuxedAccount.