Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum versions in Karma-Sauce for JavaScript compatibility. #419

Merged
merged 3 commits into from
May 1, 2021
Merged

Update minimum versions in Karma-Sauce for JavaScript compatibility. #419

merged 3 commits into from
May 1, 2021

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Apr 27, 2021 •
edited
Loading

Updates the following minimum compatibilities to prevent build errors:

  • The platform has been bumped to Windows 8.1, since Windows 7 is EOL.
  • Firefox and Chrome have been bumped to versions 44 and 49, respectively, which are the minimum versions that support the let identifier.

As you can see, the builds finally pass.

@Shaptic Shaptic changed the title Force IE11 to test on Windows 8. Force IE11 to test on Windows 8.1 and bump Firefox version to support let. Apr 28, 2021
@Shaptic Shaptic changed the title Force IE11 to test on Windows 8.1 and bump Firefox version to support let. Force IE11 to test on Windows 8.1 and bump Firefox version. Apr 28, 2021
@Shaptic Shaptic changed the title Force IE11 to test on Windows 8.1 and bump Firefox version. Update minimum versions in Karma-Sauce for JavaScript compatibility. Apr 28, 2021
@Shaptic Shaptic merged commit 66be578 into master May 1, 2021
@Shaptic Shaptic deleted the update-windows branch May 1, 2021 02:25
Shaptic added a commit that referenced this pull request Aug 3, 2021
@Shaptic
Update minimum versions in Karma-Sauce for JavaScript compatibility. (#…
5b90699 
…419)

Specifically, we bump the Windows version to be 8.1 (since 7 is EOL) and also
bump the browsers to the minimum version to support `let`.
@Shaptic Shaptic mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quietbits quietbits quietbits approved these changes

@morleyzhi morleyzhi morleyzhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shaptic @morleyzhi @quietbits