Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Node 16 the minimum version. #651

Merged
merged 3 commits into from
Jul 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/gh_pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ jobs:
with:
fetch-depth: 0

- name: Install Node (14.x)
- name: Install Node (16.x)
uses: actions/setup-node@v3
with:
node-version: '14.x'
node-version: 16

- name: Install Dependencies
run: yarn install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: '14.x'
node-version: 16
registry-url: 'https://registry.npmjs.org'

- name: Install Depencencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
fail-fast: false
max-parallel: 4
matrix:
node-version: [14, 16, 18]
node-version: [16, 18, 20]

steps:
- name: Checkout
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ Make sure that you are using the latest version number. They can be found on the

### To develop and test js-stellar-base itself

1. Install Node 14.x
1. Install Node 16.x

We support the oldest LTS release of Node, which is [currently 14.x](https://nodejs.org/en/about/releases/). Please likewise install and develop on Node 14 so you don't get surprised when your code works locally but breaks in CI.
We support the oldest LTS release of Node, which is [currently 16.x](https://nodejs.org/en/about/releases/). Please likewise install and develop on Node 16 so you don't get surprised when your code works locally but breaks in CI.

If you work on several projects that use different Node versions, you might find helpful to install a NodeJS version manager:

Expand Down
46 changes: 24 additions & 22 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
{
"name": "stellar-base",
"version": "9.0.0",
"version": "10.0.0-beta.0",
"description": "Low-level support library for the Stellar network.",
"main": "./lib/index.js",
"browser": "./dist/stellar-base.min.js",
"browser": {
"main": "./dist/stellar-base.min.js",
"sodium-native": false
},
"types": "./types/index.d.ts",
"scripts": {
"build": "yarn build:node && yarn build:browser",
Expand All @@ -13,14 +16,15 @@
"build:browser:prod": "cross-env NODE_ENV=production yarn build:browser",
"build:prod": "cross-env NODE_ENV=production yarn build",
"test": "yarn build && yarn test:node && yarn test:browser",
"test:node": "nyc --nycrc-path ./config/.nycrc mocha",
"test:node": "yarn _nyc mocha",
"test:browser": "karma start ./config/karma.conf.js",
"docs": "jsdoc -c ./config/.jsdoc.json --verbose",
"lint": "eslint -c ./config/.eslintrc.js src/ && dtslint --localTs node_modules/typescript/lib types/",
"preversion": "yarn clean && yarn fmt && yarn lint && yarn build:prod && yarn test",
"fmt": "prettier --config ./config/prettier.config.js --ignore-path ./config/.prettierignore --write './**/*.js'",
"prepare": "yarn build:prod",
"clean": "rm -rf lib/ dist/ coverage/ .nyc_output/"
"clean": "rm -rf lib/ dist/ coverage/ .nyc_output/",
"_nyc": "nyc --nycrc-path ./config/.nycrc"
},
"mocha": {
"require": [
Expand Down Expand Up @@ -52,9 +56,6 @@
"yarn lint"
]
},
"browser": {
"sodium-native": false
},
"repository": {
"type": "git",
"url": "https://github.com/stellar/js-stellar-base.git"
Expand All @@ -69,22 +70,21 @@
},
"homepage": "https://github.com/stellar/js-stellar-base",
"devDependencies": {
"@babel/cli": "^7.21.0",
"@babel/core": "^7.12.0",
"@babel/eslint-parser": "^7.21.3",
"@babel/cli": "^7.22.9",
"@babel/core": "^7.22.9",
"@babel/eslint-parser": "^7.22.9",
"@babel/eslint-plugin": "^7.19.1",
"@babel/preset-env": "^7.21.4",
"@babel/preset-env": "^7.22.9",
"@babel/register": "^7.21.0",
"@definitelytyped/dtslint": "^0.0.163",
"@istanbuljs/nyc-config-babel": "3.0.0",
"@types/node": "^20.1.4",
"@typescript-eslint/parser": "^5.59.6",
"babel-loader": "^9.1.2",
"@types/node": "^20.4.2",
"@typescript-eslint/parser": "^5.61.0",
"babel-loader": "^9.1.3",
"babel-plugin-istanbul": "^6.1.1",
"buffer": "^6.0.3",
"chai": "^4.3.7",
"cross-env": "^7.0.3",
"eslint": "^8.37.0",
"eslint": "^8.45.0",
"eslint-config-airbnb-base": "^15.0.0",
"eslint-config-prettier": "^8.8.0",
"eslint-plugin-import": "^2.25.2",
Expand All @@ -95,24 +95,24 @@
"ghooks": "^2.0.4",
"husky": "^8.0.3",
"jsdoc": "^4.0.2",
"karma": "^6.4.1",
"karma": "^6.4.2",
"karma-chrome-launcher": "^3.1.0",
"karma-coverage": "^2.2.0",
"karma-coverage": "^2.2.1",
"karma-firefox-launcher": "^2.1.1",
"karma-mocha": "^2.0.0",
"karma-sinon-chai": "^2.0.2",
"karma-webpack": "^5.0.0",
"lint-staged": "^13.2.0",
"lint-staged": "^13.2.2",
"minami": "^1.1.1",
"mocha": "^10.2.0",
"node-polyfill-webpack-plugin": "^2.0.1",
"nyc": "^15.1.0",
"prettier": "^2.8.7",
"prettier": "^2.8.8",
"randombytes": "^2.1.0",
"sinon": "^15.0.3",
"sinon-chai": "^3.7.0",
"taffydb": "^2.7.3",
"terser-webpack-plugin": "^5.3.7",
"terser-webpack-plugin": "^5.3.8",
"ts-node": "^10.9.1",
"typescript": "^5.0.3",
"webpack": "^5.82.1",
Expand All @@ -121,8 +121,10 @@
"dependencies": {
"base32.js": "^0.1.0",
"bignumber.js": "^9.1.1",
"buffer": "^6.0.3",
"crc": "^4.3.2",
"crypto-browserify": "^3.12.0",
"js-xdr": "^2.0.0",
"js-xdr": "^3.0.0",
"sha.js": "^2.3.6",
"tweetnacl": "^1.0.3"
},
Expand Down
Loading