Add async txsub endpoint in Horizon #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
reviewed
Jun 11, 2024
Co-authored-by: George <[email protected]>
Co-authored-by: George <[email protected]>
Co-authored-by: George <[email protected]>
Co-authored-by: George <[email protected]>
Co-authored-by: George <[email protected]>
Co-authored-by: George <[email protected]>
Shaptic
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Looks like there's a conflict in server.ts after the linting PR merge. I recommend just copying your submitAsyncTransaction implementation somewhere, checkout out the server.ts from master, then pasting your endpoint back in and running the linter on that new version. Otherwise LGTM! Great work! 👍
# Conflicts: # src/horizon/server.ts
This was referenced Jul 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added a new async transaction submission in Horizon: stellar/go#5188
This PR adds support for it in the JS SDK along with the relevant unittests.