soroban-rpc: Add auth-next information to simulateTransaction response #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
simulate-tx-auth-next
branch
from
c393bff to
7b2cef8
Compare
2opremio
commented
Feb 6, 2023
paulbellamy
reviewed
Feb 6, 2023
|
The soroban rpc tests are passing. The system test and soroban-cli tests are failing (as expected since that’s dealt with at #391) After adding a simulateTransaction test which exercises auth next (current tests don’t) we should be ready to go. |
tsachiherman
reviewed
Feb 6, 2023
2opremio
force-pushed
the
simulate-tx-auth-next
branch
from
e1aca13 to
155c319
Compare
2opremio
force-pushed
the
simulate-tx-auth-next
branch
from
155c319 to
00937d3
Compare
|
This should be ready to go. Note that the soroban-cli tests (including the Rust tests) and system tests are broken. |
tamirms
reviewed
Feb 7, 2023
tamirms
reviewed
Feb 7, 2023
paulbellamy
approved these changes
Feb 7, 2023
paulbellamy
approved these changes
Feb 7, 2023
tamirms
pushed a commit
that referenced
this pull request
Feb 7, 2023
#395) Co-authored-by: Paul Bellamy <[email protected]>
tamirms
pushed a commit
that referenced
this pull request
Feb 10, 2023
#395) Co-authored-by: Paul Bellamy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #348
TODO: