-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEP-0010: Add new manage data op containing server hostname #741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2020
JakeUrban
reviewed
Oct 8, 2020
accordeiro
reviewed
Oct 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left a few suggestions :)
JakeUrban
reviewed
Oct 8, 2020
leighmcculloch
changed the title
SEP-0010: Add new manage data op containing server hostname (v3.0.0)
SEP-0010: Add new manage data op containing server hostname (v3.1.0)
Oct 20, 2020
This change was superseded by #746. |
This change is being reopened to be a sequel to #746 instead. |
Actually, this change needs separating into two releases, so I'll close it and open two new PRs. |
leighmcculloch
changed the title
SEP-0010: Add new manage data op containing server hostname (v3.1.0)
SEP-0010: Add new manage data op containing server hostname
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a new manage data op containing server hostname.
Why
To use in place of the home domain verification changed in #740.