SEP-0010: Clarify the first manage data operation is the operation containing the client account, home domain, etc #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What Clarify that the first manage data operation is the operation containing the client account, nonce, and home domain. ### Why The first manage data operation has always been the first operation. This is stated explicitly further down in the SEP when the challenge transaction structure is described. All SDKs I have reviewed also follow this pattern. The abstract is somewhat ambiguous though because it states that there is a single manage data operation with those values without stating it is the first. ### Note This change is only improving the language and is not adding or changing the functionality of the SEP.
leighmcculloch
changed the title
nebolsin
reviewed
Oct 26, 2020
JakeUrban
approved these changes
Oct 26, 2020
|
@JakeUrban The first operation must be the auth op so it must be ordered. Any other ops the order is not defined. |
|
This should be merged prior to 3.0, can I merge it? @leighmcculloch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Clarify that the first manage data operation is the operation containing the client account, nonce, and home domain.
Why
The first manage data operation has always been the first operation. This is stated explicitly further down in the SEP when the challenge transaction structure is described. All SDKs I have reviewed also follow this pattern. The abstract is somewhat ambiguous though because it states that there is a single manage data operation with those values without stating it is the first.
This change is in response to the discussion here:
#746 (comment)
Note
This change is only improving the language and is not adding or changing the functionality of the SEP. This change is not urgent and may end up being merged before or after the v3 changes being proposed. If it is merged after the PR needs updating with an appropriate version and timestamp.
cc @nebolsin @JakeUrban @accordeiro