-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mantaining the version after the full length commit SHA is generated #1087
Comments
Thanks @n-th for creating the issue! We did add such a comment earlier. Then a user suggested that we should remove the comment, because when dependabot updates the Action, it does not update the comment. So the comment does not remain in sync with the commit SHA. Renovatebot does have an option to specify tag in comment and it uses that tag to update the commit SHA. So, we could do this if the project uses renovatebot. In addition, if you want this feature either when dependabot is used, or there is no update tool configured, we can do that and expose it as a configurable option. So, by default, it will not add a comment. But you can set a configuration (exposed as a checkbox in the UI) to add the comment. Please let me know your preference... |
@varunsh-coder given the lack of support for updating the comment by certain dependency management tooling, I think exposing an option to include/exclude it makes sense 👍 If this will be supported, I'd advocate for including some information on which dependency management tooling does/doesn't support it so it's easier for the user to decide what's right for them.
|
Thanks @ericcornelissen for the comment. Yes, I think this sort of config makes sense. I think we will need to explicitly ask/check what dependency management tool is being used, since RenovateBot has its own particular format. We can also auto-detect this in some cases. |
Closing this and #1360 as this has been implemented. Feel free to re-open if something is missing. Thanks! |
I would like to make a suggestion. Could we maintain the version of the commit SHA as a comment after the workflow is processed?
I mean something like this:
I think it would help us keep track of the human-readable version of the tools we are using.
The text was updated successfully, but these errors were encountered: