Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: include tag name in comment when pinning actions #1151

Closed
ericcornelissen opened this issue Sep 11, 2022 · 2 comments
Closed

suggestion: include tag name in comment when pinning actions #1151

ericcornelissen opened this issue Sep 11, 2022 · 2 comments

Comments

@ericcornelissen
Copy link
Contributor

This is a suggestion based on a tool called Ratchet1 I've tried in the past. A thing I liked about this tool is that when it changes an action version tag to a SHA, it includes the tag name in a comment after the SHA.

Current

This is an example of a diff produced by this project at the moment:

       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@7884fcad6b5d53d10323aee724dc68d8b9096a2e
         with:
           fetch-depth: 0

Suggested

This is an example of a diff I'm suggesting this project should produce:

       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@7884fcad6b5d53d10323aee724dc68d8b9096a2e # v2.0.3
         with:
           fetch-depth: 0

Footnotes

  1. Ratchet essentially provides the same pinning functionality as this project, but it also supports other CIs as well as the ability to update the SHA to a newer version. I didn't end up using Ratchet because it messes with the formatting of YAML files.

@varunsh-coder
Copy link
Member

Thanks @ericcornelissen for the suggestion. I believe this is duplicate of #1087.

If so, can you please close this one, and we can continue conversation in the other issue. Thanks!

@ericcornelissen
Copy link
Contributor Author

Looks like you're right. I didn't manage to find that issue somehow - apologies for the noise 🙂

@ericcornelissen ericcornelissen closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants