[portsorch] add more attributes on port creation #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanblyschak
force-pushed
the
port-create-attrs
branch
4 times, most recently
from
34257d7 to
39f1342
Compare
stepanblyschak
changed the title
stepanblyschak
force-pushed
the
port-create-attrs
branch
7 times, most recently
from
cf1b967 to
8ec55bb
Compare
Signed-off-by: Stepan Blyschak <[email protected]>
stepanblyschak
force-pushed
the
port-create-attrs
branch
from
8ec55bb to
33b6381
Compare
nazariig
approved these changes
Feb 18, 2025
Signed-off-by: Stepan Blyschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Extend create_ports() supported attribute list with FEC, TPID, asymetric PFC configuration.
Why I did it
On platforms which start with no ports on fast-reboot
sai_port_api->create_ports()is called as it is much more efficient to configure desired port attributes rather then have SAI driver to create default ports with default SAI attribute settings as required by SAI spec. Therefore, the most effective approach is to create ports and pass as much configuration at the time of port creation and not have to callsai_port_api->set_port_attributefor every attribute that needs to change its value.How I verified it
Manual tests, unit tests, run fast-reboot test.
Details if related