Skip to content

Commit

Permalink
fix validators not registered when VC is used with web3signer (status…
Browse files Browse the repository at this point in the history
…-im#5730)

This change ensures that suggested-fee-recipient will be used as default even if the validator directory does not exist when a web3-signer-url is specified.
  • Loading branch information
stephanep committed Jan 17, 2024
1 parent 0e63f8f commit 4a17668
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions beacon_chain/validator_client/common.nim
Original file line number Diff line number Diff line change
Expand Up @@ -967,6 +967,10 @@ proc getFeeRecipient*(vc: ValidatorClientRef, pubkey: ValidatorPubKey,
vc.config.validatorsDir, pubkey, perValidatorDefaultFeeRecipient)
if staticRecipient.isOk():
Opt.some(staticRecipient.get())
elif len(vc.config.web3SignerUrls) > 0 or len(vc.config.verifyingWeb3Signers) > 0:
# See issue 5730: getSuggestedFeeRecipient returns err if the validator directory
# does not exist, which is the case when a web3signer is used
Opt.some(perValidatorDefaultFeeRecipient)
else:
Opt.none(Eth1Address)

Expand Down

0 comments on commit 4a17668

Please sign in to comment.