Skip to content

Commit

Permalink
stephanrauh/ngx-extended-pdf-viewer#1864 remove await import because …
Browse files Browse the repository at this point in the history
…it confuses the Angular 17 compiler
  • Loading branch information
stephanrauh committed Dec 8, 2023
1 parent c1eb566 commit e3ade77
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 1 deletion.
5 changes: 5 additions & 0 deletions src/display/node_stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,18 @@ if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) {
}

let fs, http, https, url;
// #1976 modified by ngx-extended-pdf-viewer - removed because this code
// confuses Vite
/**
if (isNodeJS) {
// Native packages.
fs = await __non_webpack_import__("fs");
http = await __non_webpack_import__("http");
https = await __non_webpack_import__("https");
url = await __non_webpack_import__("url");
}
*/
// #1976 end of modification by ngx-extended-pdf-viewer

const fileUriRegex = /^file:\/\/\/[a-zA-Z]:\//;

Expand Down
5 changes: 5 additions & 0 deletions src/display/node_utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) {
}

let fs, canvas, path2d_polyfill;
// #1976 modified by ngx-extended-pdf-viewer - removed because this code
// confuses Vite
/*
if (isNodeJS) {
// Native packages.
fs = await __non_webpack_import__("fs");
Expand All @@ -39,6 +42,8 @@ if (isNodeJS) {
path2d_polyfill = await __non_webpack_import__("path2d-polyfill");
} catch {}
}
*/
// #1976 end of modification by ngx-extended-pdf-viewer

if (typeof PDFJSDev !== "undefined" && !PDFJSDev.test("SKIP_BABEL")) {
(function checkDOMMatrix() {
Expand Down
5 changes: 5 additions & 0 deletions web/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -2360,11 +2360,16 @@ async function loadFakeWorker() {
GlobalWorkerOptions.workerSrc = GlobalWorkerOptions.workerSrc();
}
// end of modification
// #1864 modified by ngx-extended-pdf-viewer because the code confused Vite
/*
if (typeof PDFJSDev === "undefined") {
globalThis.pdfjsWorker = await import("pdfjs/pdf.worker.js");
return;
}
await __non_webpack_import__(PDFWorker.workerSrc);
*/
// #1864 end of modification by ngx-extended-pdf-viewer

}

async function loadPDFBug(self) {
Expand Down
2 changes: 1 addition & 1 deletion web/ngx-extended-pdf-viewer-version.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const ngxExtendedPdfViewerVersion = '19.0.0-alpha.0';
export const ngxExtendedPdfViewerVersion = '19.0.0-alpha.1';

0 comments on commit e3ade77

Please sign in to comment.