Profiles #805
Profiles #805
Conversation
|
Hey Ross, I've tried this and it looks great - keen to merge it in. One thing though, we're just about to merge a large body of work in #777 around updating the default templates to use bootstrap 3. I strongly suspect that your changes will conflict with that branch of work. Would it be possible to base your changes on the bootstrap3 branch of @jerivas fork and send him a pull request? |
|
I encountered this one too while working on #777. My approach was to use BS3 classes to pull the image and button to the right. Should we go with left? Should we use BS classes or write our own CSS rules? Let me know and I'll update it ASAP. You can see the current state of the profiles at http://dev.jerivas.com/users/admin/. You can go ahead and create your own dummy users to test the button too. |
|
Whoops, just read Ross' message in the mailing list. It seems the other change that needs to be implemented is wrapping the field name in |
|
Thanks for the input, guys. My main motivation was to get the tag wrapping done properly, but beyond that (which will get done either way we go with this), I have no particular stylistic preferences. I like the way it looks in both examples from this thread. If Bootstrap is the default for so much else, maybe those are the classes we should use. Also, in both of our examples, the Update Profile button will appear twice, if the user visits the profile page while logged in: once in the profile div, and once in the user panel right beside it (in the right sidebar). So, the button in the profile div is actually redundant in the default Mezzanine setup. Not everyone uses the default page layout, of course, but if they do, the redundant button will be there. |
|
After comparing left and right layouts, I must say I prefer the left-aligned one. It feels much more consistent with the rest of the site which naturally "floats" to the left. I have another question, though: should content go below the image when it's taller than it? In Ross' example the space below the image is left blank, while in my site the content goes below it. |
|
I think when the image is left-aligned (which I agree looks better) then it looks awkward if the content wraps underneath it. |
|
I'll close this pull request for now and if we want to revisit it further once #777 is merged in, we can do that then. Thanks guys. |
|
Just wanted to add that I've committed the revised changes to #777, you can see them in action at http://dev.jerivas.com/users/admin. Looks pretty neat! Thanks @rosslaird |
This will format the main profile page so that the gravatar is on the left, the text is organized to the right (and beneath), and the update button (if logged in) is positioned to the top right. Example here, with just one field. This approach should be a bit cleaner than the previous version. Some new css was required to properly position and float the various elements.